location: Migrate to AWS SDK v2

[kamilturek]

Description

This PR migrates the location resources to AWS SDK v2.

Relations

Closes #36183.
Relates #32976

Output from Acceptance Testing

% make testacc PKG=location ACCTEST_PARALLELISM=1 TESTARGS="-run=TestAccLocation"
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.4 test ./internal/service/location/... -v -count 1 -parallel 1  -run=TestAccLocation -timeout 360m
=== RUN   TestAccLocationGeofenceCollectionDataSource_basic
=== PAUSE TestAccLocationGeofenceCollectionDataSource_basic
=== RUN   TestAccLocationGeofenceCollection_basic
=== PAUSE TestAccLocationGeofenceCollection_basic
=== RUN   TestAccLocationGeofenceCollection_disappears
=== PAUSE TestAccLocationGeofenceCollection_disappears
=== RUN   TestAccLocationGeofenceCollection_description
=== PAUSE TestAccLocationGeofenceCollection_description
=== RUN   TestAccLocationGeofenceCollection_kmsKeyID
=== PAUSE TestAccLocationGeofenceCollection_kmsKeyID
=== RUN   TestAccLocationGeofenceCollection_tags
=== PAUSE TestAccLocationGeofenceCollection_tags
=== RUN   TestAccLocationMapDataSource_mapName
=== PAUSE TestAccLocationMapDataSource_mapName
=== RUN   TestAccLocationMap_basic
=== PAUSE TestAccLocationMap_basic
=== RUN   TestAccLocationMap_disappears
=== PAUSE TestAccLocationMap_disappears
=== RUN   TestAccLocationMap_description
=== PAUSE TestAccLocationMap_description
=== RUN   TestAccLocationMap_tags
=== PAUSE TestAccLocationMap_tags
=== RUN   TestAccLocationPlaceIndexDataSource_indexName
=== PAUSE TestAccLocationPlaceIndexDataSource_indexName
=== RUN   TestAccLocationPlaceIndex_basic
=== PAUSE TestAccLocationPlaceIndex_basic
=== RUN   TestAccLocationPlaceIndex_disappears
=== PAUSE TestAccLocationPlaceIndex_disappears
=== RUN   TestAccLocationPlaceIndex_dataSourceConfigurationIntendedUse
=== PAUSE TestAccLocationPlaceIndex_dataSourceConfigurationIntendedUse
=== RUN   TestAccLocationPlaceIndex_description
=== PAUSE TestAccLocationPlaceIndex_description
=== RUN   TestAccLocationPlaceIndex_tags
=== PAUSE TestAccLocationPlaceIndex_tags
=== RUN   TestAccLocationRouteCalculatorDataSource_basic
=== PAUSE TestAccLocationRouteCalculatorDataSource_basic
=== RUN   TestAccLocationRouteCalculator_basic
=== PAUSE TestAccLocationRouteCalculator_basic
=== RUN   TestAccLocationRouteCalculator_disappears
=== PAUSE TestAccLocationRouteCalculator_disappears
=== RUN   TestAccLocationRouteCalculator_description
=== PAUSE TestAccLocationRouteCalculator_description
=== RUN   TestAccLocationRouteCalculator_tags
=== PAUSE TestAccLocationRouteCalculator_tags
=== RUN   TestAccLocationTrackerAssociationDataSource_basic
=== PAUSE TestAccLocationTrackerAssociationDataSource_basic
=== RUN   TestAccLocationTrackerAssociation_basic
=== PAUSE TestAccLocationTrackerAssociation_basic
=== RUN   TestAccLocationTrackerAssociation_disappears
=== PAUSE TestAccLocationTrackerAssociation_disappears
=== RUN   TestAccLocationTrackerAssociationsDataSource_basic
=== PAUSE TestAccLocationTrackerAssociationsDataSource_basic
=== RUN   TestAccLocationTrackerDataSource_indexName
=== PAUSE TestAccLocationTrackerDataSource_indexName
=== RUN   TestAccLocationTracker_basic
=== PAUSE TestAccLocationTracker_basic
=== RUN   TestAccLocationTracker_disappears
=== PAUSE TestAccLocationTracker_disappears
=== RUN   TestAccLocationTracker_description
=== PAUSE TestAccLocationTracker_description
=== RUN   TestAccLocationTracker_kmsKeyID
=== PAUSE TestAccLocationTracker_kmsKeyID
=== RUN   TestAccLocationTracker_positionFiltering
=== PAUSE TestAccLocationTracker_positionFiltering
=== RUN   TestAccLocationTracker_tags
=== PAUSE TestAccLocationTracker_tags
=== CONT  TestAccLocationGeofenceCollectionDataSource_basic
--- PASS: TestAccLocationGeofenceCollectionDataSource_basic (18.71s)
=== CONT  TestAccLocationRouteCalculatorDataSource_basic
--- PASS: TestAccLocationRouteCalculatorDataSource_basic (17.56s)
=== CONT  TestAccLocationTracker_tags
--- PASS: TestAccLocationTracker_tags (41.74s)
=== CONT  TestAccLocationTracker_positionFiltering
--- PASS: TestAccLocationTracker_positionFiltering (29.15s)
=== CONT  TestAccLocationTracker_kmsKeyID
--- PASS: TestAccLocationTracker_kmsKeyID (21.71s)
=== CONT  TestAccLocationTrackerAssociation_basic
--- PASS: TestAccLocationTrackerAssociation_basic (20.71s)
=== CONT  TestAccLocationTrackerAssociationDataSource_basic
--- PASS: TestAccLocationTrackerAssociationDataSource_basic (18.00s)
=== CONT  TestAccLocationRouteCalculator_tags
--- PASS: TestAccLocationRouteCalculator_tags (45.34s)
=== CONT  TestAccLocationTrackerAssociation_disappears
--- PASS: TestAccLocationTrackerAssociation_disappears (18.28s)
=== CONT  TestAccLocationTracker_description
--- PASS: TestAccLocationTracker_description (29.19s)
=== CONT  TestAccLocationTracker_disappears
--- PASS: TestAccLocationTracker_disappears (15.37s)
=== CONT  TestAccLocationTracker_basic
--- PASS: TestAccLocationTracker_basic (17.96s)
=== CONT  TestAccLocationTrackerDataSource_indexName
--- PASS: TestAccLocationTrackerDataSource_indexName (19.63s)
=== CONT  TestAccLocationTrackerAssociationsDataSource_basic
--- PASS: TestAccLocationTrackerAssociationsDataSource_basic (18.09s)
=== CONT  TestAccLocationRouteCalculator_disappears
--- PASS: TestAccLocationRouteCalculator_disappears (16.72s)
=== CONT  TestAccLocationMap_description
--- PASS: TestAccLocationMap_description (30.71s)
=== CONT  TestAccLocationPlaceIndex_tags
--- PASS: TestAccLocationPlaceIndex_tags (41.58s)
=== CONT  TestAccLocationPlaceIndex_description
--- PASS: TestAccLocationPlaceIndex_description (29.21s)
=== CONT  TestAccLocationPlaceIndex_dataSourceConfigurationIntendedUse
--- PASS: TestAccLocationPlaceIndex_dataSourceConfigurationIntendedUse (29.27s)
=== CONT  TestAccLocationPlaceIndex_disappears
--- PASS: TestAccLocationPlaceIndex_disappears (17.52s)
=== CONT  TestAccLocationPlaceIndex_basic
--- PASS: TestAccLocationPlaceIndex_basic (18.14s)
=== CONT  TestAccLocationPlaceIndexDataSource_indexName
--- PASS: TestAccLocationPlaceIndexDataSource_indexName (15.92s)
=== CONT  TestAccLocationMap_tags
--- PASS: TestAccLocationMap_tags (42.24s)
=== CONT  TestAccLocationMap_basic
--- PASS: TestAccLocationMap_basic (18.10s)
=== CONT  TestAccLocationMap_disappears
--- PASS: TestAccLocationMap_disappears (15.76s)
=== CONT  TestAccLocationGeofenceCollection_description
--- PASS: TestAccLocationGeofenceCollection_description (33.55s)
=== CONT  TestAccLocationGeofenceCollection_kmsKeyID
--- PASS: TestAccLocationGeofenceCollection_kmsKeyID (23.55s)
=== CONT  TestAccLocationGeofenceCollection_disappears
--- PASS: TestAccLocationGeofenceCollection_disappears (16.05s)
=== CONT  TestAccLocationRouteCalculator_basic
--- PASS: TestAccLocationRouteCalculator_basic (20.37s)
=== CONT  TestAccLocationMapDataSource_mapName
--- PASS: TestAccLocationMapDataSource_mapName (15.99s)
=== CONT  TestAccLocationGeofenceCollection_basic
--- PASS: TestAccLocationGeofenceCollection_basic (20.42s)
=== CONT  TestAccLocationRouteCalculator_description
--- PASS: TestAccLocationRouteCalculator_description (33.70s)
=== CONT  TestAccLocationGeofenceCollection_tags
--- PASS: TestAccLocationGeofenceCollection_tags (45.63s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/location   824.534s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

• Check open pull requests with the dependencies label to view other dependency updates.
• If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
• If this pull request is for supporting a new AWS service:
  • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
  • If this pull request is already a separate pull request from the above item, you can ignore this message.

[kamilturek]

Hey @ewbankkit. Could you please advise regarding the TestEndpointConfiguration failure?
https://github.com/hashicorp/terraform-provider-aws/actions/runs/10063229597/job/27817894448?pr=38395

I'm not quite sure what's the reason.

[johnsonaj]

LGTM 🚀

% make testacc TESTARGS="-run=TestAccLocation" PKG=location

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/location/... -v -count 1 -parallel 20  -run=TestAccLocation -timeout 360m
--- PASS: TestAccLocationTrackerDataSource_indexName (33.09s)
--- PASS: TestAccLocationRouteCalculatorDataSource_basic (35.43s)
--- PASS: TestAccLocationGeofenceCollectionDataSource_basic (35.98s)
--- PASS: TestAccLocationTrackerAssociationsDataSource_basic (36.10s)
--- PASS: TestAccLocationTracker_disappears (36.66s)
--- PASS: TestAccLocationRouteCalculator_disappears (37.77s)
--- PASS: TestAccLocationPlaceIndex_disappears (37.77s)
--- PASS: TestAccLocationTrackerAssociation_disappears (38.22s)
--- PASS: TestAccLocationTracker_basic (45.26s)
--- PASS: TestAccLocationTracker_kmsKeyID (45.36s)
--- PASS: TestAccLocationTrackerAssociation_basic (45.62s)
--- PASS: TestAccLocationTracker_positionFiltering (62.29s)
--- PASS: TestAccLocationPlaceIndex_dataSourceConfigurationIntendedUse (62.33s)
--- PASS: TestAccLocationPlaceIndexDataSource_indexName (27.37s)
--- PASS: TestAccLocationPlaceIndex_description (68.01s)
--- PASS: TestAccLocationMap_description (68.14s)
--- PASS: TestAccLocationTracker_description (68.19s)
--- PASS: TestAccLocationMapDataSource_mapName (29.99s)
--- PASS: TestAccLocationRouteCalculator_description (68.63s)
--- PASS: TestAccLocationMap_disappears (32.17s)
--- PASS: TestAccLocationPlaceIndex_basic (37.12s)
--- PASS: TestAccLocationRouteCalculator_basic (34.56s)
--- PASS: TestAccLocationTrackerAssociationDataSource_basic (26.85s)
--- PASS: TestAccLocationMap_basic (35.13s)
--- PASS: TestAccLocationGeofenceCollection_kmsKeyID (31.13s)
--- PASS: TestAccLocationPlaceIndex_tags (78.91s)
--- PASS: TestAccLocationRouteCalculator_tags (79.04s)
--- PASS: TestAccLocationTracker_tags (79.49s)
--- PASS: TestAccLocationGeofenceCollection_disappears (17.66s)
--- PASS: TestAccLocationGeofenceCollection_basic (21.07s)
--- PASS: TestAccLocationGeofenceCollection_description (38.98s)
--- PASS: TestAccLocationMap_tags (51.67s)
--- PASS: TestAccLocationGeofenceCollection_tags (53.35s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/location	96.342s

[johnsonaj]

@kamilturek thank you for the contribution! 🎉

[github-actions]

This functionality has been released in v5.62.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.