Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed deprecated base_policy_region attribute in r/aws_networkmanager_core_network #38398

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aayushsss1
Copy link

Description

Removed the deprecated base_policy_region attribute from core_network and core_network_test

Relations

Closes #29780

References

Deprecated due to the addition of - #29623

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

Signed-off-by: aayushsss1 <aayushsubramaniam@gmail.com>
@aayushsss1 aayushsss1 requested a review from a team as a code owner July 17, 2024 19:04
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@terraform-aws-provider terraform-aws-provider bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/networkmanager Issues and PRs that pertain to the networkmanager service. size/M Managed by automation to categorize the size of a PR. labels Jul 17, 2024
@jar-b
Copy link
Member

jar-b commented Jul 17, 2024

Hi @aayushsss1 - Thanks for opening this!

To set expectations appropriately - the linked issue is a breaking change slated for inclusion with the next major version of the AWS provider (v6.0.0). We have not yet begun work or planning for this effort, so this PR won't be reviewed by maintainers until work for v6 begins, likely later this year.

@jar-b jar-b added this to the v6.0.0 milestone Jul 17, 2024
@jar-b jar-b added the breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. label Jul 17, 2024
@aayushsss1
Copy link
Author

Hey @jar-b sure, thanks for letting me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. documentation Introduces or discusses updates to documentation. service/networkmanager Issues and PRs that pertain to the networkmanager service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

r/aws_networkmanager_core_network: Remove deprecated base_policy_region attribute
2 participants