Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lexmodels: Migrate to AWS SDK v2 #38474

Merged
merged 24 commits into from
Aug 21, 2024

Conversation

mattburgess
Copy link
Collaborator

Description

Relations

Closes #36181

References

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

@mattburgess mattburgess requested a review from a team as a code owner July 22, 2024 19:30
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@terraform-aws-provider terraform-aws-provider bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/lexmodels Issues and PRs that pertain to the lexmodels service. sweeper Pertains to changes to or issues with the sweeper. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. size/XL Managed by automation to categorize the size of a PR. labels Jul 22, 2024
@mattburgess mattburgess added the aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. label Jul 22, 2024
@justinretzolk justinretzolk added the external-maintainer Contribution from a trusted external contributor. label Jul 29, 2024
# Conflicts:
#	go.mod
#	go.sum
#	internal/conns/awsclient_gen.go
#	names/names.go
Copy link

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

@ewbankkit ewbankkit self-assigned this Aug 21, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 21, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccLexModels' PKG=lexmodels ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/lexmodels/... -v -count 1 -parallel 3  -run=TestAccLexModels -timeout 720m
=== RUN   TestAccLexModelsBotAlias_basic
=== PAUSE TestAccLexModelsBotAlias_basic
=== RUN   TestAccLexModelsBotAlias_conversationLogsText
=== PAUSE TestAccLexModelsBotAlias_conversationLogsText
=== RUN   TestAccLexModelsBotAlias_conversationLogsAudio
=== PAUSE TestAccLexModelsBotAlias_conversationLogsAudio
=== RUN   TestAccLexModelsBotAlias_conversationLogsBoth
=== PAUSE TestAccLexModelsBotAlias_conversationLogsBoth
=== RUN   TestAccLexModelsBotAlias_description
=== PAUSE TestAccLexModelsBotAlias_description
=== RUN   TestAccLexModelsBotAlias_disappears
=== PAUSE TestAccLexModelsBotAlias_disappears
=== RUN   TestAccLexModelsBotDataSource_basic
=== PAUSE TestAccLexModelsBotDataSource_basic
=== RUN   TestAccLexModelsBot_basic
=== PAUSE TestAccLexModelsBot_basic
=== RUN   TestAccLexModelsBot_Version_serial
=== PAUSE TestAccLexModelsBot_Version_serial
=== RUN   TestAccLexModelsBot_abortStatement
=== PAUSE TestAccLexModelsBot_abortStatement
=== RUN   TestAccLexModelsBot_clarificationPrompt
=== PAUSE TestAccLexModelsBot_clarificationPrompt
=== RUN   TestAccLexModelsBot_childDirected
=== PAUSE TestAccLexModelsBot_childDirected
=== RUN   TestAccLexModelsBot_description
=== PAUSE TestAccLexModelsBot_description
=== RUN   TestAccLexModelsBot_detectSentiment
=== PAUSE TestAccLexModelsBot_detectSentiment
=== RUN   TestAccLexModelsBot_enableModelImprovements
=== PAUSE TestAccLexModelsBot_enableModelImprovements
=== RUN   TestAccLexModelsBot_idleSessionTTLInSeconds
=== PAUSE TestAccLexModelsBot_idleSessionTTLInSeconds
=== RUN   TestAccLexModelsBot_intents
=== PAUSE TestAccLexModelsBot_intents
=== RUN   TestAccLexModelsBot_computeVersion
--- PASS: TestAccLexModelsBot_computeVersion (141.92s)
=== RUN   TestAccLexModelsBot_locale
=== PAUSE TestAccLexModelsBot_locale
=== RUN   TestAccLexModelsBot_voiceID
=== PAUSE TestAccLexModelsBot_voiceID
=== RUN   TestAccLexModelsBot_disappears
=== PAUSE TestAccLexModelsBot_disappears
=== RUN   TestAccLexModelsIntentDataSource_basic
=== PAUSE TestAccLexModelsIntentDataSource_basic
=== RUN   TestAccLexModelsIntentDataSource_withVersion
=== PAUSE TestAccLexModelsIntentDataSource_withVersion
=== RUN   TestAccLexModelsIntent_basic
=== PAUSE TestAccLexModelsIntent_basic
=== RUN   TestAccLexModelsIntent_createVersion
=== PAUSE TestAccLexModelsIntent_createVersion
=== RUN   TestAccLexModelsIntent_conclusionStatement
=== PAUSE TestAccLexModelsIntent_conclusionStatement
=== RUN   TestAccLexModelsIntent_confirmationPromptAndRejectionStatement
=== PAUSE TestAccLexModelsIntent_confirmationPromptAndRejectionStatement
=== RUN   TestAccLexModelsIntent_dialogCodeHook
=== PAUSE TestAccLexModelsIntent_dialogCodeHook
=== RUN   TestAccLexModelsIntent_followUpPrompt
=== PAUSE TestAccLexModelsIntent_followUpPrompt
=== RUN   TestAccLexModelsIntent_fulfillmentActivity
=== PAUSE TestAccLexModelsIntent_fulfillmentActivity
=== RUN   TestAccLexModelsIntent_sampleUtterances
=== PAUSE TestAccLexModelsIntent_sampleUtterances
=== RUN   TestAccLexModelsIntent_slots
=== PAUSE TestAccLexModelsIntent_slots
=== RUN   TestAccLexModelsIntent_slotsCustom
=== PAUSE TestAccLexModelsIntent_slotsCustom
=== RUN   TestAccLexModelsIntent_disappears
=== PAUSE TestAccLexModelsIntent_disappears
=== RUN   TestAccLexModelsIntent_updateWithExternalChange
=== PAUSE TestAccLexModelsIntent_updateWithExternalChange
=== RUN   TestAccLexModelsIntent_computeVersion
=== PAUSE TestAccLexModelsIntent_computeVersion
=== RUN   TestAccLexModelsSlotTypeDataSource_basic
=== PAUSE TestAccLexModelsSlotTypeDataSource_basic
=== RUN   TestAccLexModelsSlotTypeDataSource_withVersion
=== PAUSE TestAccLexModelsSlotTypeDataSource_withVersion
=== RUN   TestAccLexModelsSlotType_basic
=== PAUSE TestAccLexModelsSlotType_basic
=== RUN   TestAccLexModelsSlotType_createVersion
=== PAUSE TestAccLexModelsSlotType_createVersion
=== RUN   TestAccLexModelsSlotType_description
=== PAUSE TestAccLexModelsSlotType_description
=== RUN   TestAccLexModelsSlotType_enumerationValues
=== PAUSE TestAccLexModelsSlotType_enumerationValues
=== RUN   TestAccLexModelsSlotType_name
=== PAUSE TestAccLexModelsSlotType_name
=== RUN   TestAccLexModelsSlotType_valueSelectionStrategy
=== PAUSE TestAccLexModelsSlotType_valueSelectionStrategy
=== RUN   TestAccLexModelsSlotType_disappears
=== PAUSE TestAccLexModelsSlotType_disappears
=== RUN   TestAccLexModelsSlotType_computeVersion
=== PAUSE TestAccLexModelsSlotType_computeVersion
=== CONT  TestAccLexModelsBotAlias_basic
=== CONT  TestAccLexModelsIntent_createVersion
=== CONT  TestAccLexModelsBot_description
--- PASS: TestAccLexModelsBotAlias_basic (17.20s)
=== CONT  TestAccLexModelsBotDataSource_basic
--- PASS: TestAccLexModelsIntent_createVersion (21.51s)
=== CONT  TestAccLexModelsBotAlias_disappears
--- PASS: TestAccLexModelsBot_description (23.29s)
=== CONT  TestAccLexModelsBotAlias_description
--- PASS: TestAccLexModelsBotDataSource_basic (13.45s)
=== CONT  TestAccLexModelsBotAlias_conversationLogsBoth
--- PASS: TestAccLexModelsBotAlias_disappears (15.12s)
=== CONT  TestAccLexModelsBotAlias_conversationLogsAudio
--- PASS: TestAccLexModelsBotAlias_description (49.78s)
=== CONT  TestAccLexModelsBotAlias_conversationLogsText
--- PASS: TestAccLexModelsBotAlias_conversationLogsBoth (24.28s)
=== CONT  TestAccLexModelsBot_voiceID
--- PASS: TestAccLexModelsBotAlias_conversationLogsAudio (24.44s)
=== CONT  TestAccLexModelsIntent_basic
--- PASS: TestAccLexModelsBotAlias_conversationLogsText (22.84s)
=== CONT  TestAccLexModelsIntentDataSource_withVersion
--- PASS: TestAccLexModelsIntent_basic (11.08s)
=== CONT  TestAccLexModelsIntentDataSource_basic
--- PASS: TestAccLexModelsBot_voiceID (21.99s)
=== CONT  TestAccLexModelsBot_disappears
--- PASS: TestAccLexModelsIntentDataSource_withVersion (9.67s)
=== CONT  TestAccLexModelsBot_abortStatement
--- PASS: TestAccLexModelsIntentDataSource_basic (9.82s)
=== CONT  TestAccLexModelsBot_clarificationPrompt
--- PASS: TestAccLexModelsBot_disappears (10.24s)
=== CONT  TestAccLexModelsBot_Version_serial
=== RUN   TestAccLexModelsBot_Version_serial/LexBotAlias_botVersion
--- PASS: TestAccLexModelsBot_abortStatement (49.17s)
=== CONT  TestAccLexModelsBot_idleSessionTTLInSeconds
--- PASS: TestAccLexModelsBot_clarificationPrompt (53.35s)
=== CONT  TestAccLexModelsBot_locale
=== RUN   TestAccLexModelsBot_Version_serial/DataSourceLexBot_withVersion
--- PASS: TestAccLexModelsBot_idleSessionTTLInSeconds (24.94s)
=== CONT  TestAccLexModelsBot_intents
--- PASS: TestAccLexModelsBot_intents (73.26s)
=== CONT  TestAccLexModelsBot_basic
--- PASS: TestAccLexModelsBot_basic (18.57s)
=== CONT  TestAccLexModelsIntent_computeVersion
--- PASS: TestAccLexModelsBot_locale (101.37s)
=== CONT  TestAccLexModelsSlotType_computeVersion
=== RUN   TestAccLexModelsBot_Version_serial/DataSourceLexBotAlias_basic
=== RUN   TestAccLexModelsBot_Version_serial/LexBot_createVersion
--- PASS: TestAccLexModelsIntent_computeVersion (162.20s)
=== CONT  TestAccLexModelsSlotType_disappears
--- PASS: TestAccLexModelsSlotType_computeVersion (165.43s)
=== CONT  TestAccLexModelsBot_childDirected
--- PASS: TestAccLexModelsBot_childDirected (30.35s)
=== CONT  TestAccLexModelsSlotType_valueSelectionStrategy
--- PASS: TestAccLexModelsSlotType_disappears (45.65s)
=== CONT  TestAccLexModelsIntent_sampleUtterances
--- PASS: TestAccLexModelsBot_Version_serial (359.51s)
    --- PASS: TestAccLexModelsBot_Version_serial/LexBotAlias_botVersion (60.38s)
    --- PASS: TestAccLexModelsBot_Version_serial/DataSourceLexBot_withVersion (158.33s)
    --- PASS: TestAccLexModelsBot_Version_serial/DataSourceLexBotAlias_basic (81.92s)
    --- PASS: TestAccLexModelsBot_Version_serial/LexBot_createVersion (58.89s)
=== CONT  TestAccLexModelsSlotType_name
--- PASS: TestAccLexModelsSlotType_valueSelectionStrategy (20.18s)
=== CONT  TestAccLexModelsSlotType_enumerationValues
--- PASS: TestAccLexModelsIntent_sampleUtterances (20.27s)
=== CONT  TestAccLexModelsIntent_updateWithExternalChange
--- PASS: TestAccLexModelsSlotType_name (21.15s)
=== CONT  TestAccLexModelsSlotType_description
--- PASS: TestAccLexModelsSlotType_enumerationValues (20.42s)
=== CONT  TestAccLexModelsIntent_disappears
--- PASS: TestAccLexModelsIntent_updateWithExternalChange (15.99s)
=== CONT  TestAccLexModelsSlotType_createVersion
--- PASS: TestAccLexModelsIntent_disappears (9.27s)
=== CONT  TestAccLexModelsIntent_slotsCustom
--- PASS: TestAccLexModelsSlotType_description (20.13s)
=== CONT  TestAccLexModelsSlotType_basic
--- PASS: TestAccLexModelsIntent_slotsCustom (12.48s)
=== CONT  TestAccLexModelsIntent_slots
--- PASS: TestAccLexModelsSlotType_createVersion (20.36s)
=== CONT  TestAccLexModelsSlotTypeDataSource_withVersion
--- PASS: TestAccLexModelsSlotType_basic (11.49s)
=== CONT  TestAccLexModelsIntent_dialogCodeHook
--- PASS: TestAccLexModelsSlotTypeDataSource_withVersion (9.08s)
=== CONT  TestAccLexModelsSlotTypeDataSource_basic
--- PASS: TestAccLexModelsIntent_slots (21.36s)
=== CONT  TestAccLexModelsIntent_conclusionStatement
--- PASS: TestAccLexModelsSlotTypeDataSource_basic (8.93s)
=== CONT  TestAccLexModelsIntent_fulfillmentActivity
--- PASS: TestAccLexModelsIntent_dialogCodeHook (27.42s)
=== CONT  TestAccLexModelsIntent_followUpPrompt
--- PASS: TestAccLexModelsIntent_conclusionStatement (20.62s)
=== CONT  TestAccLexModelsBot_enableModelImprovements
--- PASS: TestAccLexModelsIntent_followUpPrompt (21.48s)
=== CONT  TestAccLexModelsBot_detectSentiment
--- PASS: TestAccLexModelsIntent_fulfillmentActivity (27.15s)
=== CONT  TestAccLexModelsIntent_confirmationPromptAndRejectionStatement
--- PASS: TestAccLexModelsIntent_confirmationPromptAndRejectionStatement (22.10s)
--- PASS: TestAccLexModelsBot_enableModelImprovements (23.14s)
--- PASS: TestAccLexModelsBot_detectSentiment (22.66s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lexmodels	707.731s

@ewbankkit
Copy link
Contributor

@mattburgess Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit e9713db into hashicorp:main Aug 21, 2024
28 checks passed
@github-actions github-actions bot added this to the v5.64.0 milestone Aug 21, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 22, 2024
Copy link

This functionality has been released in v5.64.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. client-connections Pertains to the AWS Client and service connections. external-maintainer Contribution from a trusted external contributor. generators Relates to code generators. service/lexmodels Issues and PRs that pertain to the lexmodels service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AWS SDK for Go Migration] Lex Model Building Service
3 participants