Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rd/aws_cloudwatch_event_bus: Add kms_key_identifier argument #38492

Merged

Conversation

kamilturek
Copy link
Collaborator

@kamilturek kamilturek commented Jul 23, 2024

Description

This PR adds the kms_key_identifier argument to the aws_cloudwatch_event_bus resource and data source.

Relations

Closes #37531.

References

https://docs.aws.amazon.com/eventbridge/latest/APIReference/API_CreateEventBus.html
https://docs.aws.amazon.com/eventbridge/latest/APIReference/API_DescribeEventBus.html
https://docs.aws.amazon.com/eventbridge/latest/APIReference/API_UpdateEventBus.html

Output from Acceptance Testing

% make testacc PKG=events ACCTEST_PARALLELISM=1 TESTARGS="-run=TestAccEventsBus"
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/events/... -v -count 1 -parallel 1  -run=TestAccEventsBus -timeout 360m
=== RUN   TestAccEventsBusDataSource_basic
=== PAUSE TestAccEventsBusDataSource_basic
=== RUN   TestAccEventsBusDataSource_kmsKeyIdentifier
=== PAUSE TestAccEventsBusDataSource_kmsKeyIdentifier
=== RUN   TestAccEventsBusPolicy_basic
=== PAUSE TestAccEventsBusPolicy_basic
=== RUN   TestAccEventsBusPolicy_ignoreEquivalent
=== PAUSE TestAccEventsBusPolicy_ignoreEquivalent
=== RUN   TestAccEventsBusPolicy_disappears
=== PAUSE TestAccEventsBusPolicy_disappears
=== RUN   TestAccEventsBusPolicy_disappears_EventBus
=== PAUSE TestAccEventsBusPolicy_disappears_EventBus
=== RUN   TestAccEventsBus_basic
=== PAUSE TestAccEventsBus_basic
=== RUN   TestAccEventsBus_kmsKeyIdentifier
=== PAUSE TestAccEventsBus_kmsKeyIdentifier
=== RUN   TestAccEventsBus_tags
=== PAUSE TestAccEventsBus_tags
=== RUN   TestAccEventsBus_default
=== PAUSE TestAccEventsBus_default
=== RUN   TestAccEventsBus_disappears
=== PAUSE TestAccEventsBus_disappears
=== RUN   TestAccEventsBus_partnerEventSource
    bus_test.go:206: Environment variable EVENT_BRIDGE_PARTNER_EVENT_SOURCE_NAME is not set
--- SKIP: TestAccEventsBus_partnerEventSource (0.00s)
=== CONT  TestAccEventsBusDataSource_basic
--- PASS: TestAccEventsBusDataSource_basic (17.10s)
=== CONT  TestAccEventsBus_basic
--- PASS: TestAccEventsBus_basic (45.97s)
=== CONT  TestAccEventsBus_disappears
--- PASS: TestAccEventsBus_disappears (16.96s)
=== CONT  TestAccEventsBus_default
--- PASS: TestAccEventsBus_default (0.97s)
=== CONT  TestAccEventsBus_tags
--- PASS: TestAccEventsBus_tags (45.42s)
=== CONT  TestAccEventsBus_kmsKeyIdentifier
--- PASS: TestAccEventsBus_kmsKeyIdentifier (57.15s)
=== CONT  TestAccEventsBusPolicy_ignoreEquivalent
--- PASS: TestAccEventsBusPolicy_ignoreEquivalent (22.98s)
=== CONT  TestAccEventsBusPolicy_disappears_EventBus
--- PASS: TestAccEventsBusPolicy_disappears_EventBus (19.16s)
=== CONT  TestAccEventsBusPolicy_disappears
--- PASS: TestAccEventsBusPolicy_disappears (18.18s)
=== CONT  TestAccEventsBusPolicy_basic
--- PASS: TestAccEventsBusPolicy_basic (34.35s)
=== CONT  TestAccEventsBusDataSource_kmsKeyIdentifier
--- PASS: TestAccEventsBusDataSource_kmsKeyIdentifier (28.41s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/events     314.546s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@terraform-aws-provider terraform-aws-provider bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/events Issues and PRs that pertain to the events service. size/L Managed by automation to categorize the size of a PR. labels Jul 23, 2024
@kamilturek kamilturek marked this pull request as ready for review July 23, 2024 18:43
@kamilturek kamilturek requested a review from a team as a code owner July 23, 2024 18:43
jar-b added 2 commits July 24, 2024 16:34
```console
% make testacc PKG=events TESTS=TestAccEventsBus_kmsKeyIdentifier
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/events/... -v -count 1 -parallel 20 -run='TestAccEventsBus_kmsKeyIdentifier'  -timeout 360m
=== RUN   TestAccEventsBus_kmsKeyIdentifier
=== PAUSE TestAccEventsBus_kmsKeyIdentifier
=== CONT  TestAccEventsBus_kmsKeyIdentifier
--- PASS: TestAccEventsBus_kmsKeyIdentifier (55.82s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/events     61.663s
```
@jar-b jar-b self-assigned this Jul 24, 2024
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make testacc PKG=events TESTS=TestAccEventsBus
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/events/... -v -count 1 -parallel 20 -run='TestAccEventsBus'  -timeout 360m

--- PASS: TestAccEventsBus_default (2.27s)
--- PASS: TestAccEventsBusDataSource_basic (14.96s)
--- PASS: TestAccEventsBus_disappears (16.39s)
--- PASS: TestAccEventsBusPolicy_disappears (16.72s)
--- PASS: TestAccEventsBusPolicy_disappears_EventBus (16.96s)
--- PASS: TestAccEventsBusPolicy_ignoreEquivalent (20.12s)
--- PASS: TestAccEventsBusDataSource_kmsKeyIdentifier (24.75s)
--- PASS: TestAccEventsBusPolicy_basic (26.11s)
--- PASS: TestAccEventsBus_tags (33.05s)
--- PASS: TestAccEventsBus_basic (33.08s)
--- PASS: TestAccEventsBus_kmsKeyIdentifier (36.00s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/events     41.769s

@jar-b
Copy link
Member

jar-b commented Jul 24, 2024

Thanks for your contribution, @kamilturek! 👍

@jar-b jar-b merged commit 2369532 into hashicorp:main Jul 25, 2024
41 checks passed
@github-actions github-actions bot added this to the v5.60.0 milestone Jul 25, 2024
Copy link

This functionality has been released in v5.60.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@justinretzolk justinretzolk added the external-maintainer Contribution from a trusted external contributor. label Jul 29, 2024
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. external-maintainer Contribution from a trusted external contributor. service/events Issues and PRs that pertain to the events service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

r/aws_cloudwatch_event_bus: Support KMS CMKs
3 participants