Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Storage Gateway resources to AWS SDK V2 #38554

Merged
merged 42 commits into from
Jul 31, 2024

Conversation

DanielRieske
Copy link
Contributor

@DanielRieske DanielRieske commented Jul 26, 2024

Description

This PR migrates the Storage Gateway resources to AWS SDKv2.

Relations

Closes #36215
Relates #32976

References

Output from Acceptance Testing

Currently running tests

% make testacc TESTS=TestAccXXX PKG=ec2

...

Verified

This commit was signed with the committer’s verified signature.
DanielRieske Daniel Rieske

Verified

This commit was signed with the committer’s verified signature.
DanielRieske Daniel Rieske

Verified

This commit was signed with the committer’s verified signature.
DanielRieske Daniel Rieske

Verified

This commit was signed with the committer’s verified signature.
DanielRieske Daniel Rieske

Verified

This commit was signed with the committer’s verified signature.
DanielRieske Daniel Rieske

Verified

This commit was signed with the committer’s verified signature.
DanielRieske Daniel Rieske

Verified

This commit was signed with the committer’s verified signature.
DanielRieske Daniel Rieske

Verified

This commit was signed with the committer’s verified signature.
DanielRieske Daniel Rieske

Verified

This commit was signed with the committer’s verified signature.
DanielRieske Daniel Rieske

Verified

This commit was signed with the committer’s verified signature.
DanielRieske Daniel Rieske

Verified

This commit was signed with the committer’s verified signature.
DanielRieske Daniel Rieske

Verified

This commit was signed with the committer’s verified signature.
DanielRieske Daniel Rieske

Verified

This commit was signed with the committer’s verified signature.
DanielRieske Daniel Rieske

Verified

This commit was signed with the committer’s verified signature.
DanielRieske Daniel Rieske

Verified

This commit was signed with the committer’s verified signature.
DanielRieske Daniel Rieske

Verified

This commit was signed with the committer’s verified signature.
DanielRieske Daniel Rieske

Verified

This commit was signed with the committer’s verified signature.
DanielRieske Daniel Rieske

Verified

This commit was signed with the committer’s verified signature.
DanielRieske Daniel Rieske

Verified

This commit was signed with the committer’s verified signature.
DanielRieske Daniel Rieske

Verified

This commit was signed with the committer’s verified signature.
DanielRieske Daniel Rieske
@DanielRieske DanielRieske requested a review from a team as a code owner July 26, 2024 13:00
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@terraform-aws-provider terraform-aws-provider bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/storagegateway Issues and PRs that pertain to the storagegateway service. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. size/XL Managed by automation to categorize the size of a PR. labels Jul 26, 2024

Verified

This commit was signed with the committer’s verified signature.
DanielRieske Daniel Rieske
ewbankkit added 10 commits July 27, 2024 17:54

Verified

This commit was signed with the committer’s verified signature.
ewbankkit Kit Ewbank

Verified

This commit was signed with the committer’s verified signature.
ewbankkit Kit Ewbank

Verified

This commit was signed with the committer’s verified signature.
ewbankkit Kit Ewbank

Verified

This commit was signed with the committer’s verified signature.
ewbankkit Kit Ewbank

Verified

This commit was signed with the committer’s verified signature.
ewbankkit Kit Ewbank

Verified

This commit was signed with the committer’s verified signature.
ewbankkit Kit Ewbank

Verified

This commit was signed with the committer’s verified signature.
ewbankkit Kit Ewbank

Verified

This commit was signed with the committer’s verified signature.
ewbankkit Kit Ewbank

Verified

This commit was signed with the committer’s verified signature.
ewbankkit Kit Ewbank

Verified

This commit was signed with the committer’s verified signature.
ewbankkit Kit Ewbank
@justinretzolk justinretzolk added the external-maintainer Contribution from a trusted external contributor. label Jul 29, 2024

Verified

This commit was signed with the committer’s verified signature.
ewbankkit Kit Ewbank

Verified

This commit was signed with the committer’s verified signature.
ewbankkit Kit Ewbank
…TwoPartKey'.

Verified

This commit was signed with the committer’s verified signature.
ewbankkit Kit Ewbank

Verified

This commit was signed with the committer’s verified signature.
ewbankkit Kit Ewbank
# Conflicts:
#	go.mod

Verified

This commit was signed with the committer’s verified signature.
ewbankkit Kit Ewbank

Verified

This commit was signed with the committer’s verified signature.
ewbankkit Kit Ewbank
Copy link

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

@ewbankkit ewbankkit self-assigned this Jul 31, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jul 31, 2024

Verified

This commit was signed with the committer’s verified signature.
ewbankkit Kit Ewbank
…torageGatewayLocalDiskDataSource_diskPath'.
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccStorageGateway' PKG=storagegateway ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/storagegateway/... -v -count 1 -parallel 3  -run=TestAccStorageGateway -timeout 720m
=== RUN   TestAccStorageGatewayCache_fileGateway
=== PAUSE TestAccStorageGatewayCache_fileGateway
=== RUN   TestAccStorageGatewayCache_tapeAndVolumeGateway
=== PAUSE TestAccStorageGatewayCache_tapeAndVolumeGateway
=== RUN   TestAccStorageGatewayCachediSCSIVolume_basic
=== PAUSE TestAccStorageGatewayCachediSCSIVolume_basic
=== RUN   TestAccStorageGatewayCachediSCSIVolume_kms
=== PAUSE TestAccStorageGatewayCachediSCSIVolume_kms
=== RUN   TestAccStorageGatewayCachediSCSIVolume_tags
=== PAUSE TestAccStorageGatewayCachediSCSIVolume_tags
=== RUN   TestAccStorageGatewayCachediSCSIVolume_snapshotID
=== PAUSE TestAccStorageGatewayCachediSCSIVolume_snapshotID
=== RUN   TestAccStorageGatewayCachediSCSIVolume_sourceVolumeARN
    cached_iscsi_volume_test.go:240: This test can cause Storage Gateway 2.0.10.0 to enter an irrecoverable state during volume deletion.
--- SKIP: TestAccStorageGatewayCachediSCSIVolume_sourceVolumeARN (0.00s)
=== RUN   TestAccStorageGatewayCachediSCSIVolume_disappears
=== PAUSE TestAccStorageGatewayCachediSCSIVolume_disappears
=== RUN   TestAccStorageGatewayFileSystemAssociation_basic
=== PAUSE TestAccStorageGatewayFileSystemAssociation_basic
=== RUN   TestAccStorageGatewayFileSystemAssociation_tags
=== PAUSE TestAccStorageGatewayFileSystemAssociation_tags
=== RUN   TestAccStorageGatewayFileSystemAssociation_cacheAttributes
=== PAUSE TestAccStorageGatewayFileSystemAssociation_cacheAttributes
=== RUN   TestAccStorageGatewayFileSystemAssociation_auditDestination
=== PAUSE TestAccStorageGatewayFileSystemAssociation_auditDestination
=== RUN   TestAccStorageGatewayFileSystemAssociation_disappears
=== PAUSE TestAccStorageGatewayFileSystemAssociation_disappears
=== RUN   TestAccStorageGatewayFileSystemAssociation_Disappears_storageGateway
=== PAUSE TestAccStorageGatewayFileSystemAssociation_Disappears_storageGateway
=== RUN   TestAccStorageGatewayFileSystemAssociation_Disappears_fsxFileSystem
    file_system_association_test.go:251: A bug in the service API has been reported. Deleting the FSx file system before the association prevents association from being deleted.
--- SKIP: TestAccStorageGatewayFileSystemAssociation_Disappears_fsxFileSystem (0.00s)
=== RUN   TestAccStorageGatewayGateway_GatewayType_cached
=== PAUSE TestAccStorageGatewayGateway_GatewayType_cached
=== RUN   TestAccStorageGatewayGateway_GatewayType_fileFSxSMB
=== PAUSE TestAccStorageGatewayGateway_GatewayType_fileFSxSMB
=== RUN   TestAccStorageGatewayGateway_GatewayType_fileS3
=== PAUSE TestAccStorageGatewayGateway_GatewayType_fileS3
=== RUN   TestAccStorageGatewayGateway_GatewayType_stored
=== PAUSE TestAccStorageGatewayGateway_GatewayType_stored
=== RUN   TestAccStorageGatewayGateway_GatewayType_vtl
=== PAUSE TestAccStorageGatewayGateway_GatewayType_vtl
=== RUN   TestAccStorageGatewayGateway_tags
=== PAUSE TestAccStorageGatewayGateway_tags
=== RUN   TestAccStorageGatewayGateway_gatewayName
=== PAUSE TestAccStorageGatewayGateway_gatewayName
=== RUN   TestAccStorageGatewayGateway_cloudWatchLogs
=== PAUSE TestAccStorageGatewayGateway_cloudWatchLogs
=== RUN   TestAccStorageGatewayGateway_gatewayTimezone
=== PAUSE TestAccStorageGatewayGateway_gatewayTimezone
=== RUN   TestAccStorageGatewayGateway_gatewayVPCEndpoint
=== PAUSE TestAccStorageGatewayGateway_gatewayVPCEndpoint
=== RUN   TestAccStorageGatewayGateway_smbActiveDirectorySettings
=== PAUSE TestAccStorageGatewayGateway_smbActiveDirectorySettings
=== RUN   TestAccStorageGatewayGateway_SMBActiveDirectorySettings_timeout
=== PAUSE TestAccStorageGatewayGateway_SMBActiveDirectorySettings_timeout
=== RUN   TestAccStorageGatewayGateway_smbMicrosoftActiveDirectorySettings
=== PAUSE TestAccStorageGatewayGateway_smbMicrosoftActiveDirectorySettings
=== RUN   TestAccStorageGatewayGateway_SMBMicrosoftActiveDirectorySettings_timeout
=== PAUSE TestAccStorageGatewayGateway_SMBMicrosoftActiveDirectorySettings_timeout
=== RUN   TestAccStorageGatewayGateway_smbGuestPassword
=== PAUSE TestAccStorageGatewayGateway_smbGuestPassword
=== RUN   TestAccStorageGatewayGateway_smbSecurityStrategy
=== PAUSE TestAccStorageGatewayGateway_smbSecurityStrategy
=== RUN   TestAccStorageGatewayGateway_smbVisibility
=== PAUSE TestAccStorageGatewayGateway_smbVisibility
=== RUN   TestAccStorageGatewayGateway_disappears
=== PAUSE TestAccStorageGatewayGateway_disappears
=== RUN   TestAccStorageGatewayGateway_bandwidthUpload
=== PAUSE TestAccStorageGatewayGateway_bandwidthUpload
=== RUN   TestAccStorageGatewayGateway_bandwidthDownload
=== PAUSE TestAccStorageGatewayGateway_bandwidthDownload
=== RUN   TestAccStorageGatewayGateway_bandwidthAll
=== PAUSE TestAccStorageGatewayGateway_bandwidthAll
=== RUN   TestAccStorageGatewayGateway_maintenanceStartTime
=== PAUSE TestAccStorageGatewayGateway_maintenanceStartTime
=== RUN   TestAccStorageGatewayLocalDiskDataSource_diskNode
=== PAUSE TestAccStorageGatewayLocalDiskDataSource_diskNode
=== RUN   TestAccStorageGatewayLocalDiskDataSource_diskPath
=== PAUSE TestAccStorageGatewayLocalDiskDataSource_diskPath
=== RUN   TestAccStorageGatewayNFSFileShare_basic
=== PAUSE TestAccStorageGatewayNFSFileShare_basic
=== RUN   TestAccStorageGatewayNFSFileShare_audit
=== PAUSE TestAccStorageGatewayNFSFileShare_audit
=== RUN   TestAccStorageGatewayNFSFileShare_tags
=== PAUSE TestAccStorageGatewayNFSFileShare_tags
=== RUN   TestAccStorageGatewayNFSFileShare_fileShareName
=== PAUSE TestAccStorageGatewayNFSFileShare_fileShareName
=== RUN   TestAccStorageGatewayNFSFileShare_clientList
=== PAUSE TestAccStorageGatewayNFSFileShare_clientList
=== RUN   TestAccStorageGatewayNFSFileShare_defaultStorageClass
=== PAUSE TestAccStorageGatewayNFSFileShare_defaultStorageClass
=== RUN   TestAccStorageGatewayNFSFileShare_guessMIMETypeEnabled
=== PAUSE TestAccStorageGatewayNFSFileShare_guessMIMETypeEnabled
=== RUN   TestAccStorageGatewayNFSFileShare_kmsEncrypted
=== PAUSE TestAccStorageGatewayNFSFileShare_kmsEncrypted
=== RUN   TestAccStorageGatewayNFSFileShare_kmsKeyARN
=== PAUSE TestAccStorageGatewayNFSFileShare_kmsKeyARN
=== RUN   TestAccStorageGatewayNFSFileShare_nFSFileShareDefaults
=== PAUSE TestAccStorageGatewayNFSFileShare_nFSFileShareDefaults
=== RUN   TestAccStorageGatewayNFSFileShare_objectACL
=== PAUSE TestAccStorageGatewayNFSFileShare_objectACL
=== RUN   TestAccStorageGatewayNFSFileShare_readOnly
=== PAUSE TestAccStorageGatewayNFSFileShare_readOnly
=== RUN   TestAccStorageGatewayNFSFileShare_requesterPays
=== PAUSE TestAccStorageGatewayNFSFileShare_requesterPays
=== RUN   TestAccStorageGatewayNFSFileShare_squash
=== PAUSE TestAccStorageGatewayNFSFileShare_squash
=== RUN   TestAccStorageGatewayNFSFileShare_notificationPolicy
=== PAUSE TestAccStorageGatewayNFSFileShare_notificationPolicy
=== RUN   TestAccStorageGatewayNFSFileShare_cacheAttributes
=== PAUSE TestAccStorageGatewayNFSFileShare_cacheAttributes
=== RUN   TestAccStorageGatewayNFSFileShare_disappears
=== PAUSE TestAccStorageGatewayNFSFileShare_disappears
=== RUN   TestAccStorageGatewaySMBFileShare_Authentication_activeDirectory
=== PAUSE TestAccStorageGatewaySMBFileShare_Authentication_activeDirectory
=== RUN   TestAccStorageGatewaySMBFileShare_Authentication_guestAccess
=== PAUSE TestAccStorageGatewaySMBFileShare_Authentication_guestAccess
=== RUN   TestAccStorageGatewaySMBFileShare_accessBasedEnumeration
=== PAUSE TestAccStorageGatewaySMBFileShare_accessBasedEnumeration
=== RUN   TestAccStorageGatewaySMBFileShare_notificationPolicy
=== PAUSE TestAccStorageGatewaySMBFileShare_notificationPolicy
=== RUN   TestAccStorageGatewaySMBFileShare_defaultStorageClass
=== PAUSE TestAccStorageGatewaySMBFileShare_defaultStorageClass
=== RUN   TestAccStorageGatewaySMBFileShare_encryptedUpdate
=== PAUSE TestAccStorageGatewaySMBFileShare_encryptedUpdate
=== RUN   TestAccStorageGatewaySMBFileShare_fileShareName
=== PAUSE TestAccStorageGatewaySMBFileShare_fileShareName
=== RUN   TestAccStorageGatewaySMBFileShare_tags
=== PAUSE TestAccStorageGatewaySMBFileShare_tags
=== RUN   TestAccStorageGatewaySMBFileShare_guessMIMETypeEnabled
=== PAUSE TestAccStorageGatewaySMBFileShare_guessMIMETypeEnabled
=== RUN   TestAccStorageGatewaySMBFileShare_invalidUserList
=== PAUSE TestAccStorageGatewaySMBFileShare_invalidUserList
=== RUN   TestAccStorageGatewaySMBFileShare_kmsEncrypted
=== PAUSE TestAccStorageGatewaySMBFileShare_kmsEncrypted
=== RUN   TestAccStorageGatewaySMBFileShare_kmsKeyARN
=== PAUSE TestAccStorageGatewaySMBFileShare_kmsKeyARN
=== RUN   TestAccStorageGatewaySMBFileShare_objectACL
=== PAUSE TestAccStorageGatewaySMBFileShare_objectACL
=== RUN   TestAccStorageGatewaySMBFileShare_readOnly
=== PAUSE TestAccStorageGatewaySMBFileShare_readOnly
=== RUN   TestAccStorageGatewaySMBFileShare_requesterPays
=== PAUSE TestAccStorageGatewaySMBFileShare_requesterPays
=== RUN   TestAccStorageGatewaySMBFileShare_validUserList
=== PAUSE TestAccStorageGatewaySMBFileShare_validUserList
=== RUN   TestAccStorageGatewaySMBFileShare_SMB_acl
=== PAUSE TestAccStorageGatewaySMBFileShare_SMB_acl
=== RUN   TestAccStorageGatewaySMBFileShare_audit
=== PAUSE TestAccStorageGatewaySMBFileShare_audit
=== RUN   TestAccStorageGatewaySMBFileShare_cacheAttributes
=== PAUSE TestAccStorageGatewaySMBFileShare_cacheAttributes
=== RUN   TestAccStorageGatewaySMBFileShare_caseSensitivity
=== PAUSE TestAccStorageGatewaySMBFileShare_caseSensitivity
=== RUN   TestAccStorageGatewaySMBFileShare_disappears
=== PAUSE TestAccStorageGatewaySMBFileShare_disappears
=== RUN   TestAccStorageGatewaySMBFileShare_adminUserList
=== PAUSE TestAccStorageGatewaySMBFileShare_adminUserList
=== RUN   TestAccStorageGatewayStorediSCSIVolume_basic
=== PAUSE TestAccStorageGatewayStorediSCSIVolume_basic
=== RUN   TestAccStorageGatewayStorediSCSIVolume_kms
=== PAUSE TestAccStorageGatewayStorediSCSIVolume_kms
=== RUN   TestAccStorageGatewayStorediSCSIVolume_tags
=== PAUSE TestAccStorageGatewayStorediSCSIVolume_tags
=== RUN   TestAccStorageGatewayStorediSCSIVolume_snapshotID
=== PAUSE TestAccStorageGatewayStorediSCSIVolume_snapshotID
=== RUN   TestAccStorageGatewayStorediSCSIVolume_disappears
=== PAUSE TestAccStorageGatewayStorediSCSIVolume_disappears
=== RUN   TestAccStorageGatewayTapePool_basic
=== PAUSE TestAccStorageGatewayTapePool_basic
=== RUN   TestAccStorageGatewayTapePool_retention
=== PAUSE TestAccStorageGatewayTapePool_retention
=== RUN   TestAccStorageGatewayTapePool_tags
=== PAUSE TestAccStorageGatewayTapePool_tags
=== RUN   TestAccStorageGatewayTapePool_disappears
=== PAUSE TestAccStorageGatewayTapePool_disappears
=== RUN   TestAccStorageGatewayUploadBuffer_basic
=== PAUSE TestAccStorageGatewayUploadBuffer_basic
=== RUN   TestAccStorageGatewayUploadBuffer_diskPath
=== PAUSE TestAccStorageGatewayUploadBuffer_diskPath
=== RUN   TestAccStorageGatewayWorkingStorage_basic
=== PAUSE TestAccStorageGatewayWorkingStorage_basic
=== CONT  TestAccStorageGatewayCache_fileGateway
=== CONT  TestAccStorageGatewayNFSFileShare_kmsEncrypted
=== CONT  TestAccStorageGatewaySMBFileShare_objectACL
--- PASS: TestAccStorageGatewayCache_fileGateway (284.62s)
=== CONT  TestAccStorageGatewaySMBFileShare_Authentication_guestAccess
--- PASS: TestAccStorageGatewayNFSFileShare_kmsEncrypted (289.45s)
=== CONT  TestAccStorageGatewaySMBFileShare_kmsKeyARN
--- PASS: TestAccStorageGatewaySMBFileShare_objectACL (326.88s)
=== CONT  TestAccStorageGatewaySMBFileShare_kmsEncrypted
--- PASS: TestAccStorageGatewaySMBFileShare_Authentication_guestAccess (228.74s)
=== CONT  TestAccStorageGatewaySMBFileShare_invalidUserList
--- PASS: TestAccStorageGatewaySMBFileShare_kmsEncrypted (219.49s)
=== CONT  TestAccStorageGatewaySMBFileShare_guessMIMETypeEnabled
--- PASS: TestAccStorageGatewaySMBFileShare_kmsKeyARN (318.55s)
=== CONT  TestAccStorageGatewaySMBFileShare_tags
--- PASS: TestAccStorageGatewaySMBFileShare_guessMIMETypeEnabled (270.40s)
=== CONT  TestAccStorageGatewayStorediSCSIVolume_kms
--- PASS: TestAccStorageGatewaySMBFileShare_tags (293.91s)
=== CONT  TestAccStorageGatewaySMBFileShare_fileShareName
--- PASS: TestAccStorageGatewayStorediSCSIVolume_kms (303.25s)
=== CONT  TestAccStorageGatewayWorkingStorage_basic
--- PASS: TestAccStorageGatewaySMBFileShare_fileShareName (326.15s)
=== CONT  TestAccStorageGatewaySMBFileShare_encryptedUpdate
--- PASS: TestAccStorageGatewayWorkingStorage_basic (229.50s)
=== CONT  TestAccStorageGatewayUploadBuffer_diskPath
--- PASS: TestAccStorageGatewaySMBFileShare_encryptedUpdate (302.24s)
=== CONT  TestAccStorageGatewayTapePool_retention
--- PASS: TestAccStorageGatewayTapePool_retention (10.74s)
=== CONT  TestAccStorageGatewaySMBFileShare_defaultStorageClass
--- PASS: TestAccStorageGatewayUploadBuffer_diskPath (257.09s)
=== CONT  TestAccStorageGatewaySMBFileShare_notificationPolicy
--- PASS: TestAccStorageGatewaySMBFileShare_invalidUserList (1198.32s)
=== CONT  TestAccStorageGatewaySMBFileShare_accessBasedEnumeration
--- PASS: TestAccStorageGatewaySMBFileShare_defaultStorageClass (302.83s)
=== CONT  TestAccStorageGatewayTapePool_basic
--- PASS: TestAccStorageGatewayTapePool_basic (11.17s)
=== CONT  TestAccStorageGatewayGateway_gatewayVPCEndpoint
--- PASS: TestAccStorageGatewaySMBFileShare_notificationPolicy (302.82s)
=== CONT  TestAccStorageGatewayStorediSCSIVolume_disappears
--- PASS: TestAccStorageGatewaySMBFileShare_accessBasedEnumeration (351.81s)
=== CONT  TestAccStorageGatewayNFSFileShare_guessMIMETypeEnabled
--- PASS: TestAccStorageGatewayGateway_gatewayVPCEndpoint (286.04s)
=== CONT  TestAccStorageGatewayStorediSCSIVolume_snapshotID
--- PASS: TestAccStorageGatewayStorediSCSIVolume_disappears (244.01s)
=== CONT  TestAccStorageGatewayNFSFileShare_defaultStorageClass
--- PASS: TestAccStorageGatewayNFSFileShare_guessMIMETypeEnabled (294.69s)
=== CONT  TestAccStorageGatewayStorediSCSIVolume_tags
--- PASS: TestAccStorageGatewayNFSFileShare_defaultStorageClass (258.12s)
=== CONT  TestAccStorageGatewayNFSFileShare_clientList
--- PASS: TestAccStorageGatewayStorediSCSIVolume_snapshotID (430.13s)
=== CONT  TestAccStorageGatewayNFSFileShare_fileShareName
--- PASS: TestAccStorageGatewayStorediSCSIVolume_tags (328.60s)
=== CONT  TestAccStorageGatewayFileSystemAssociation_disappears
--- PASS: TestAccStorageGatewayNFSFileShare_clientList (362.26s)
=== CONT  TestAccStorageGatewayGateway_gatewayTimezone
--- PASS: TestAccStorageGatewayNFSFileShare_fileShareName (304.76s)
=== CONT  TestAccStorageGatewayGateway_cloudWatchLogs
--- PASS: TestAccStorageGatewayGateway_gatewayTimezone (221.89s)
=== CONT  TestAccStorageGatewayGateway_gatewayName
--- PASS: TestAccStorageGatewayGateway_cloudWatchLogs (210.90s)
=== CONT  TestAccStorageGatewayGateway_tags
--- PASS: TestAccStorageGatewayGateway_tags (306.04s)
=== CONT  TestAccStorageGatewayGateway_GatewayType_vtl
--- PASS: TestAccStorageGatewayGateway_GatewayType_vtl (228.48s)
=== CONT  TestAccStorageGatewayGateway_GatewayType_stored
--- PASS: TestAccStorageGatewayGateway_GatewayType_stored (245.56s)
=== CONT  TestAccStorageGatewayUploadBuffer_basic
=== NAME  TestAccStorageGatewayGateway_gatewayName
    gateway_test.go:292: Step 2/3 error: Error running apply: exit status 1
        
        Error: deleting Security Group (sg-0c6b22432e0a4be2e): operation error EC2: DeleteSecurityGroup, https response error StatusCode: 400, RequestID: a82c4458-18b0-4c8c-82cb-dc90842f6ab5, api error DependencyViolation: resource sg-0c6b22432e0a4be2e has a dependent object
        
--- PASS: TestAccStorageGatewayUploadBuffer_basic (261.96s)
=== CONT  TestAccStorageGatewayTapePool_disappears
--- PASS: TestAccStorageGatewayTapePool_disappears (8.97s)
=== CONT  TestAccStorageGatewayNFSFileShare_squash
--- FAIL: TestAccStorageGatewayGateway_gatewayName (1146.77s)
=== CONT  TestAccStorageGatewayTapePool_tags
--- PASS: TestAccStorageGatewayTapePool_tags (23.62s)
=== CONT  TestAccStorageGatewaySMBFileShare_Authentication_activeDirectory
--- PASS: TestAccStorageGatewayNFSFileShare_squash (309.93s)
=== CONT  TestAccStorageGatewayNFSFileShare_objectACL
--- PASS: TestAccStorageGatewayNFSFileShare_objectACL (319.15s)
=== CONT  TestAccStorageGatewayNFSFileShare_disappears
--- PASS: TestAccStorageGatewayNFSFileShare_disappears (227.51s)
=== CONT  TestAccStorageGatewayNFSFileShare_requesterPays
--- PASS: TestAccStorageGatewaySMBFileShare_Authentication_activeDirectory (878.98s)
=== CONT  TestAccStorageGatewayNFSFileShare_cacheAttributes
--- PASS: TestAccStorageGatewayNFSFileShare_requesterPays (313.79s)
=== CONT  TestAccStorageGatewayNFSFileShare_readOnly
--- PASS: TestAccStorageGatewayNFSFileShare_cacheAttributes (321.04s)
=== CONT  TestAccStorageGatewayNFSFileShare_notificationPolicy
--- PASS: TestAccStorageGatewayNFSFileShare_readOnly (323.24s)
=== CONT  TestAccStorageGatewayNFSFileShare_tags
--- PASS: TestAccStorageGatewayNFSFileShare_notificationPolicy (386.96s)
=== CONT  TestAccStorageGatewayGateway_GatewayType_cached
--- PASS: TestAccStorageGatewayNFSFileShare_tags (278.48s)
=== CONT  TestAccStorageGatewayGateway_disappears
--- PASS: TestAccStorageGatewayGateway_GatewayType_cached (274.87s)
=== CONT  TestAccStorageGatewayGateway_GatewayType_fileFSxSMB
--- PASS: TestAccStorageGatewayGateway_disappears (260.93s)
=== CONT  TestAccStorageGatewayGateway_smbVisibility
--- PASS: TestAccStorageGatewayGateway_GatewayType_fileFSxSMB (222.76s)
=== CONT  TestAccStorageGatewayLocalDiskDataSource_diskNode
--- PASS: TestAccStorageGatewayGateway_smbVisibility (274.48s)
=== CONT  TestAccStorageGatewayGateway_smbMicrosoftActiveDirectorySettings
--- PASS: TestAccStorageGatewayLocalDiskDataSource_diskNode (282.47s)
=== CONT  TestAccStorageGatewayGateway_SMBActiveDirectorySettings_timeout
--- PASS: TestAccStorageGatewayGateway_SMBActiveDirectorySettings_timeout (911.01s)
=== CONT  TestAccStorageGatewayGateway_smbActiveDirectorySettings
=== NAME  TestAccStorageGatewayFileSystemAssociation_disappears
    file_system_association_test.go:206: Step 1/1 error: Error running apply: exit status 1
        
        Error: waiting for Storage Gateway File System Association (arn:aws:storagegateway:us-west-2:123456789012:fs-association/fsa-0356456A319CFA3B4) create: timeout while waiting for state to become 'AVAILABLE' (last state: 'CREATING', timeout: 30m0s)
        
          with aws_storagegateway_file_system_association.test,
          on terraform_plugin_test.tf line 175, in resource "aws_storagegateway_file_system_association" "test":
         175: resource "aws_storagegateway_file_system_association" "test" {
        
--- PASS: TestAccStorageGatewayGateway_smbActiveDirectorySettings (899.21s)
=== CONT  TestAccStorageGatewayGateway_SMBMicrosoftActiveDirectorySettings_timeout
--- PASS: TestAccStorageGatewayGateway_smbMicrosoftActiveDirectorySettings (1941.61s)
=== CONT  TestAccStorageGatewayNFSFileShare_nFSFileShareDefaults
--- PASS: TestAccStorageGatewayNFSFileShare_nFSFileShareDefaults (291.04s)
=== CONT  TestAccStorageGatewayGateway_GatewayType_fileS3
--- PASS: TestAccStorageGatewayGateway_GatewayType_fileS3 (232.92s)
=== CONT  TestAccStorageGatewayFileSystemAssociation_Disappears_storageGateway
--- PASS: TestAccStorageGatewayGateway_SMBMicrosoftActiveDirectorySettings_timeout (942.96s)
=== CONT  TestAccStorageGatewayCachediSCSIVolume_disappears
--- PASS: TestAccStorageGatewayCachediSCSIVolume_disappears (370.81s)
=== CONT  TestAccStorageGatewayFileSystemAssociation_auditDestination
=== NAME  TestAccStorageGatewayFileSystemAssociation_disappears
    panic.go:626: Error running post-test destroy, there may be dangling resources: exit status 1
        
        Error: waiting for Storage Gateway File System Association (arn:aws:storagegateway:us-west-2:123456789012:fs-association/fsa-0356456A319CFA3B4) delete: timeout while waiting for resource to be gone (last state: 'DELETING', timeout: 30m0s)
        
--- FAIL: TestAccStorageGatewayFileSystemAssociation_disappears (7168.09s)
=== CONT  TestAccStorageGatewayFileSystemAssociation_cacheAttributes
=== NAME  TestAccStorageGatewayFileSystemAssociation_Disappears_storageGateway
    file_system_association_test.go:232: Step 1/1 error: Error running apply: exit status 1
        
        Error: waiting for Storage Gateway File System Association (arn:aws:storagegateway:us-west-2:123456789012:fs-association/fsa-0D9E4865DF26EBCAA) create: timeout while waiting for state to become 'AVAILABLE' (last state: 'CREATING', timeout: 30m0s)
        
          with aws_storagegateway_file_system_association.test,
          on terraform_plugin_test.tf line 175, in resource "aws_storagegateway_file_system_association" "test":
         175: resource "aws_storagegateway_file_system_association" "test" {
        
=== NAME  TestAccStorageGatewayFileSystemAssociation_auditDestination
    file_system_association_test.go:162: Step 1/4 error: Error running apply: exit status 1
        
        Error: waiting for Storage Gateway File System Association (arn:aws:storagegateway:us-west-2:123456789012:fs-association/fsa-04032B35DCBC3E986) create: timeout while waiting for state to become 'AVAILABLE' (last state: 'CREATING', timeout: 30m0s)
        
          with aws_storagegateway_file_system_association.test,
          on terraform_plugin_test.tf line 175, in resource "aws_storagegateway_file_system_association" "test":
         175: resource "aws_storagegateway_file_system_association" "test" {
        
=== NAME  TestAccStorageGatewayFileSystemAssociation_Disappears_storageGateway
    panic.go:626: Error running post-test destroy, there may be dangling resources: exit status 1
        
        Error: waiting for Storage Gateway File System Association (arn:aws:storagegateway:us-west-2:123456789012:fs-association/fsa-0D9E4865DF26EBCAA) delete: timeout while waiting for resource to be gone (last state: 'DELETING', timeout: 30m0s)
        
--- FAIL: TestAccStorageGatewayFileSystemAssociation_Disappears_storageGateway (6270.86s)
=== CONT  TestAccStorageGatewayFileSystemAssociation_tags
=== NAME  TestAccStorageGatewayFileSystemAssociation_cacheAttributes
    file_system_association_test.go:122: Step 1/3 error: Error running apply: exit status 1
        
        Error: waiting for Storage Gateway File System Association (arn:aws:storagegateway:us-west-2:123456789012:fs-association/fsa-0E6772A58B8CED5AC) create: timeout while waiting for state to become 'AVAILABLE' (last state: 'CREATING', timeout: 30m0s)
        
          with aws_storagegateway_file_system_association.test,
          on terraform_plugin_test.tf line 175, in resource "aws_storagegateway_file_system_association" "test":
         175: resource "aws_storagegateway_file_system_association" "test" {
        
=== NAME  TestAccStorageGatewayFileSystemAssociation_auditDestination
    panic.go:626: Error running post-test destroy, there may be dangling resources: exit status 1
        
        Error: waiting for Storage Gateway File System Association (arn:aws:storagegateway:us-west-2:123456789012:fs-association/fsa-04032B35DCBC3E986) delete: timeout while waiting for resource to be gone (last state: 'DELETING', timeout: 30m0s)
        
--- FAIL: TestAccStorageGatewayFileSystemAssociation_auditDestination (6327.60s)
=== CONT  TestAccStorageGatewayFileSystemAssociation_basic
=== NAME  TestAccStorageGatewayFileSystemAssociation_cacheAttributes
    panic.go:626: Error running post-test destroy, there may be dangling resources: exit status 1
        
        Error: waiting for Storage Gateway File System Association (arn:aws:storagegateway:us-west-2:123456789012:fs-association/fsa-0E6772A58B8CED5AC) delete: timeout while waiting for resource to be gone (last state: 'DELETING', timeout: 30m0s)
        
--- FAIL: TestAccStorageGatewayFileSystemAssociation_cacheAttributes (7649.44s)
=== CONT  TestAccStorageGatewayGateway_bandwidthAll
--- PASS: TestAccStorageGatewayGateway_bandwidthAll (323.22s)
=== CONT  TestAccStorageGatewayGateway_maintenanceStartTime
--- PASS: TestAccStorageGatewayGateway_maintenanceStartTime (283.11s)
=== CONT  TestAccStorageGatewaySMBFileShare_cacheAttributes
--- PASS: TestAccStorageGatewaySMBFileShare_cacheAttributes (379.45s)
=== CONT  TestAccStorageGatewayStorediSCSIVolume_basic
--- PASS: TestAccStorageGatewayStorediSCSIVolume_basic (278.98s)
=== CONT  TestAccStorageGatewaySMBFileShare_adminUserList
=== NAME  TestAccStorageGatewayFileSystemAssociation_tags
    file_system_association_test.go:70: Step 1/4 error: Error running apply: exit status 1
        
        Error: waiting for Storage Gateway File System Association (arn:aws:storagegateway:us-west-2:123456789012:fs-association/fsa-00312392648901608) create: timeout while waiting for state to become 'AVAILABLE' (last state: 'CREATING', timeout: 30m0s)
        
          with aws_storagegateway_file_system_association.test,
          on terraform_plugin_test.tf line 175, in resource "aws_storagegateway_file_system_association" "test":
         175: resource "aws_storagegateway_file_system_association" "test" {
        
--- PASS: TestAccStorageGatewaySMBFileShare_adminUserList (1327.55s)
=== CONT  TestAccStorageGatewayGateway_smbGuestPassword
=== NAME  TestAccStorageGatewayFileSystemAssociation_basic
    file_system_association_test.go:34: Step 1/2 error: Error running apply: exit status 1
        
        Error: waiting for Storage Gateway File System Association (arn:aws:storagegateway:us-west-2:123456789012:fs-association/fsa-09BA654260F2E33FD) create: timeout while waiting for state to become 'AVAILABLE' (last state: 'CREATING', timeout: 30m0s)
        
          with aws_storagegateway_file_system_association.test,
          on terraform_plugin_test.tf line 175, in resource "aws_storagegateway_file_system_association" "test":
         175: resource "aws_storagegateway_file_system_association" "test" {
        
--- PASS: TestAccStorageGatewayGateway_smbGuestPassword (249.04s)
=== CONT  TestAccStorageGatewaySMBFileShare_disappears
--- PASS: TestAccStorageGatewaySMBFileShare_disappears (226.94s)
=== CONT  TestAccStorageGatewaySMBFileShare_caseSensitivity
--- PASS: TestAccStorageGatewaySMBFileShare_caseSensitivity (352.80s)
=== CONT  TestAccStorageGatewayNFSFileShare_kmsKeyARN
--- PASS: TestAccStorageGatewayNFSFileShare_kmsKeyARN (325.18s)
=== CONT  TestAccStorageGatewayLocalDiskDataSource_diskPath
=== NAME  TestAccStorageGatewayFileSystemAssociation_tags
    panic.go:626: Error running post-test destroy, there may be dangling resources: exit status 1
        
        Error: waiting for Storage Gateway File System Association (arn:aws:storagegateway:us-west-2:123456789012:fs-association/fsa-00312392648901608) delete: timeout while waiting for resource to be gone (last state: 'DELETING', timeout: 30m0s)
        
--- FAIL: TestAccStorageGatewayFileSystemAssociation_tags (6209.19s)
=== CONT  TestAccStorageGatewayCachediSCSIVolume_kms
--- PASS: TestAccStorageGatewayLocalDiskDataSource_diskPath (282.45s)
=== CONT  TestAccStorageGatewayCachediSCSIVolume_snapshotID
--- PASS: TestAccStorageGatewayCachediSCSIVolume_kms (273.81s)
=== CONT  TestAccStorageGatewayCachediSCSIVolume_basic
--- PASS: TestAccStorageGatewayCachediSCSIVolume_snapshotID (286.60s)
=== CONT  TestAccStorageGatewayCachediSCSIVolume_tags
=== NAME  TestAccStorageGatewayFileSystemAssociation_basic
    panic.go:626: Error running post-test destroy, there may be dangling resources: exit status 1
        
        Error: waiting for Storage Gateway File System Association (arn:aws:storagegateway:us-west-2:123456789012:fs-association/fsa-09BA654260F2E33FD) delete: timeout while waiting for resource to be gone (last state: 'DELETING', timeout: 30m0s)
        
--- FAIL: TestAccStorageGatewayFileSystemAssociation_basic (6001.29s)
=== CONT  TestAccStorageGatewayCache_tapeAndVolumeGateway
--- PASS: TestAccStorageGatewayCachediSCSIVolume_basic (279.39s)
=== CONT  TestAccStorageGatewaySMBFileShare_validUserList
--- PASS: TestAccStorageGatewayCachediSCSIVolume_tags (282.30s)
=== CONT  TestAccStorageGatewaySMBFileShare_audit
--- PASS: TestAccStorageGatewayCache_tapeAndVolumeGateway (369.85s)
=== CONT  TestAccStorageGatewaySMBFileShare_SMB_acl
--- PASS: TestAccStorageGatewaySMBFileShare_audit (300.16s)
=== CONT  TestAccStorageGatewayGateway_bandwidthDownload
--- PASS: TestAccStorageGatewayGateway_bandwidthDownload (270.34s)
=== CONT  TestAccStorageGatewaySMBFileShare_requesterPays
--- PASS: TestAccStorageGatewaySMBFileShare_requesterPays (324.75s)
=== CONT  TestAccStorageGatewaySMBFileShare_readOnly
--- PASS: TestAccStorageGatewaySMBFileShare_validUserList (1051.78s)
=== CONT  TestAccStorageGatewayNFSFileShare_audit
--- PASS: TestAccStorageGatewayNFSFileShare_audit (280.65s)
=== CONT  TestAccStorageGatewayGateway_smbSecurityStrategy
--- PASS: TestAccStorageGatewaySMBFileShare_readOnly (317.49s)
=== CONT  TestAccStorageGatewayNFSFileShare_basic
--- PASS: TestAccStorageGatewaySMBFileShare_SMB_acl (1074.85s)
=== CONT  TestAccStorageGatewayGateway_bandwidthUpload
--- PASS: TestAccStorageGatewayNFSFileShare_basic (224.24s)
--- PASS: TestAccStorageGatewayGateway_smbSecurityStrategy (259.92s)
--- PASS: TestAccStorageGatewayGateway_bandwidthUpload (272.60s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/storagegateway	23659.152s
FAIL
make: *** [testacc] Error 1

Errors are unrelated to this change and are occurring in CI.

@ewbankkit
Copy link
Contributor

@DanielRieske Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 91837ec into hashicorp:main Jul 31, 2024
48 checks passed
@github-actions github-actions bot added this to the v5.61.0 milestone Jul 31, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 2, 2024
Copy link

github-actions bot commented Aug 2, 2024

This functionality has been released in v5.61.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Sep 1, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. client-connections Pertains to the AWS Client and service connections. external-maintainer Contribution from a trusted external contributor. generators Relates to code generators. service/storagegateway Issues and PRs that pertain to the storagegateway service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AWS SDK for Go Migration] Storage Gateway Service
3 participants