Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_sagemaker_user_profile: add studio_web_portal_settings #38567

Conversation

deepakbshetty
Copy link
Contributor

Description

r/aws_sagemaker_user_profile
Add user_settings.studio_web_portal_settings block

Relations

Depends #38457
Closes #38240

References

StudioWebPortalSettings API

Output from Acceptance Testing

$ make testacc TESTS=TestAccSageMaker_serial/UserProfile/studioWebPortalSettings_hiddenAppTypes PKG=sagemaker
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/sagemaker/... -v -count 1 -parallel 20 -run='TestAccSageMaker_serial/UserProfile/studioWebPortalSettings_hiddenAppTypes'  -timeout 360m
=== RUN   TestAccSageMaker_serial
=== PAUSE TestAccSageMaker_serial
=== CONT  TestAccSageMaker_serial
=== RUN   TestAccSageMaker_serial/UserProfile
=== RUN   TestAccSageMaker_serial/UserProfile/studioWebPortalSettings_hiddenAppTypes
--- PASS: TestAccSageMaker_serial (407.73s)
    --- PASS: TestAccSageMaker_serial/UserProfile (407.73s)
        --- PASS: TestAccSageMaker_serial/UserProfile/studioWebPortalSettings_hiddenAppTypes (407.72s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker  443.613s

$ make testacc TESTS=TestAccSageMaker_serial/UserProfile/studioWebPortalSettings_hiddenMlTools PKG=sagemaker
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/sagemaker/... -v -count 1 -parallel 20 -run='TestAccSageMaker_serial/UserProfile/studioWebPortalSettings_hiddenMlTools'  -timeout 360m
=== RUN   TestAccSageMaker_serial
=== PAUSE TestAccSageMaker_serial
=== CONT  TestAccSageMaker_serial
=== RUN   TestAccSageMaker_serial/UserProfile
=== RUN   TestAccSageMaker_serial/UserProfile/studioWebPortalSettings_hiddenMlTools
--- PASS: TestAccSageMaker_serial (378.38s)
    --- PASS: TestAccSageMaker_serial/UserProfile (378.38s)
        --- PASS: TestAccSageMaker_serial/UserProfile/studioWebPortalSettings_hiddenMlTools (378.37s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker  413.253s


@deepakbshetty deepakbshetty requested a review from a team as a code owner July 26, 2024 22:26
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@terraform-aws-provider terraform-aws-provider bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/sagemaker Issues and PRs that pertain to the sagemaker service. size/L Managed by automation to categorize the size of a PR. labels Jul 26, 2024
@deepakbshetty deepakbshetty force-pushed the f-aws_sagemaker_user_profile-studio_web_portal_settings branch from ba5586f to 1d24b41 Compare July 26, 2024 22:30
@deepakbshetty
Copy link
Contributor Author

Dear @DrFaust92 For your kind review.

@deepakbshetty deepakbshetty changed the title r/aws_sagemaker_userprofile: add studio_web_portal_settings r/aws_sagemaker_user_profile: add studio_web_portal_settings Jul 26, 2024
Copy link
Collaborator

@DrFaust92 DrFaust92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deepakbshetty deepakbshetty force-pushed the f-aws_sagemaker_user_profile-studio_web_portal_settings branch from 61b43d1 to 2f210fb Compare August 31, 2024 10:32
@ewbankkit ewbankkit self-assigned this Sep 9, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 9, 2024
@deepakbshetty
Copy link
Contributor Author

Depends on sagemaker domain PR for functions #38457

Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccSageMaker_serial/UserProfile' PKG=sagemaker
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.0 test ./internal/service/sagemaker/... -v -count 1 -parallel 20  -run=TestAccSageMaker_serial/UserProfile -timeout 720m
=== RUN   TestAccSageMaker_serial
=== PAUSE TestAccSageMaker_serial
=== CONT  TestAccSageMaker_serial
=== RUN   TestAccSageMaker_serial/UserProfile
=== RUN   TestAccSageMaker_serial/UserProfile/jupyterServerAppSettings
=== RUN   TestAccSageMaker_serial/UserProfile/studioWebPortalSettings_hiddenAppTypes
=== RUN   TestAccSageMaker_serial/UserProfile/basic
=== RUN   TestAccSageMaker_serial/UserProfile/disappears
=== RUN   TestAccSageMaker_serial/UserProfile/tags
=== RUN   TestAccSageMaker_serial/UserProfile/kernelGatewayAppSettings_lifecycleConfig
=== RUN   TestAccSageMaker_serial/UserProfile/kernelGatewayAppSettings_imageConfig
    user_profile_test.go:244: Environment variable SAGEMAKER_IMAGE_VERSION_BASE_IMAGE is not set
=== RUN   TestAccSageMaker_serial/UserProfile/codeEditorAppSettings_customImage
    user_profile_test.go:282: Environment variable SAGEMAKER_IMAGE_VERSION_BASE_IMAGE is not set
=== RUN   TestAccSageMaker_serial/UserProfile/studioWebPortalSettings_hiddenMlTools
=== RUN   TestAccSageMaker_serial/UserProfile/tensorboardAppSettings
=== RUN   TestAccSageMaker_serial/UserProfile/tensorboardAppSettingsWithImage
=== RUN   TestAccSageMaker_serial/UserProfile/kernelGatewayAppSettings
--- PASS: TestAccSageMaker_serial (2642.35s)
    --- PASS: TestAccSageMaker_serial/UserProfile (2642.35s)
        --- PASS: TestAccSageMaker_serial/UserProfile/jupyterServerAppSettings (262.20s)
        --- PASS: TestAccSageMaker_serial/UserProfile/studioWebPortalSettings_hiddenAppTypes (272.84s)
        --- PASS: TestAccSageMaker_serial/UserProfile/basic (261.39s)
        --- PASS: TestAccSageMaker_serial/UserProfile/disappears (284.68s)
        --- PASS: TestAccSageMaker_serial/UserProfile/tags (258.75s)
        --- PASS: TestAccSageMaker_serial/UserProfile/kernelGatewayAppSettings_lifecycleConfig (263.87s)
        --- SKIP: TestAccSageMaker_serial/UserProfile/kernelGatewayAppSettings_imageConfig (0.00s)
        --- SKIP: TestAccSageMaker_serial/UserProfile/codeEditorAppSettings_customImage (0.00s)
        --- PASS: TestAccSageMaker_serial/UserProfile/studioWebPortalSettings_hiddenMlTools (263.07s)
        --- PASS: TestAccSageMaker_serial/UserProfile/tensorboardAppSettings (251.60s)
        --- PASS: TestAccSageMaker_serial/UserProfile/tensorboardAppSettingsWithImage (263.09s)
        --- PASS: TestAccSageMaker_serial/UserProfile/kernelGatewayAppSettings (260.85s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker	2647.375s

@ewbankkit
Copy link
Contributor

@deepakbshetty Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit f14ae23 into hashicorp:main Sep 9, 2024
40 checks passed
@github-actions github-actions bot added this to the v5.67.0 milestone Sep 9, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 13, 2024
Copy link

This functionality has been released in v5.67.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/sagemaker Issues and PRs that pertain to the sagemaker service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: aws_sagemaker_domain customize user interface
3 participants