-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/aws_sagemaker_user_profile: add studio_web_portal_settings #38567
r/aws_sagemaker_user_profile: add studio_web_portal_settings #38567
Conversation
Community NoteVoting for Prioritization
For Submitters
|
ba5586f
to
1d24b41
Compare
Dear @DrFaust92 For your kind review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
61b43d1
to
2f210fb
Compare
Depends on sagemaker domain PR for functions #38457 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccSageMaker_serial/UserProfile' PKG=sagemaker
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.0 test ./internal/service/sagemaker/... -v -count 1 -parallel 20 -run=TestAccSageMaker_serial/UserProfile -timeout 720m
=== RUN TestAccSageMaker_serial
=== PAUSE TestAccSageMaker_serial
=== CONT TestAccSageMaker_serial
=== RUN TestAccSageMaker_serial/UserProfile
=== RUN TestAccSageMaker_serial/UserProfile/jupyterServerAppSettings
=== RUN TestAccSageMaker_serial/UserProfile/studioWebPortalSettings_hiddenAppTypes
=== RUN TestAccSageMaker_serial/UserProfile/basic
=== RUN TestAccSageMaker_serial/UserProfile/disappears
=== RUN TestAccSageMaker_serial/UserProfile/tags
=== RUN TestAccSageMaker_serial/UserProfile/kernelGatewayAppSettings_lifecycleConfig
=== RUN TestAccSageMaker_serial/UserProfile/kernelGatewayAppSettings_imageConfig
user_profile_test.go:244: Environment variable SAGEMAKER_IMAGE_VERSION_BASE_IMAGE is not set
=== RUN TestAccSageMaker_serial/UserProfile/codeEditorAppSettings_customImage
user_profile_test.go:282: Environment variable SAGEMAKER_IMAGE_VERSION_BASE_IMAGE is not set
=== RUN TestAccSageMaker_serial/UserProfile/studioWebPortalSettings_hiddenMlTools
=== RUN TestAccSageMaker_serial/UserProfile/tensorboardAppSettings
=== RUN TestAccSageMaker_serial/UserProfile/tensorboardAppSettingsWithImage
=== RUN TestAccSageMaker_serial/UserProfile/kernelGatewayAppSettings
--- PASS: TestAccSageMaker_serial (2642.35s)
--- PASS: TestAccSageMaker_serial/UserProfile (2642.35s)
--- PASS: TestAccSageMaker_serial/UserProfile/jupyterServerAppSettings (262.20s)
--- PASS: TestAccSageMaker_serial/UserProfile/studioWebPortalSettings_hiddenAppTypes (272.84s)
--- PASS: TestAccSageMaker_serial/UserProfile/basic (261.39s)
--- PASS: TestAccSageMaker_serial/UserProfile/disappears (284.68s)
--- PASS: TestAccSageMaker_serial/UserProfile/tags (258.75s)
--- PASS: TestAccSageMaker_serial/UserProfile/kernelGatewayAppSettings_lifecycleConfig (263.87s)
--- SKIP: TestAccSageMaker_serial/UserProfile/kernelGatewayAppSettings_imageConfig (0.00s)
--- SKIP: TestAccSageMaker_serial/UserProfile/codeEditorAppSettings_customImage (0.00s)
--- PASS: TestAccSageMaker_serial/UserProfile/studioWebPortalSettings_hiddenMlTools (263.07s)
--- PASS: TestAccSageMaker_serial/UserProfile/tensorboardAppSettings (251.60s)
--- PASS: TestAccSageMaker_serial/UserProfile/tensorboardAppSettingsWithImage (263.09s)
--- PASS: TestAccSageMaker_serial/UserProfile/kernelGatewayAppSettings (260.85s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker 2647.375s
@deepakbshetty Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.67.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
r/aws_sagemaker_user_profile
Add
user_settings.studio_web_portal_settings
blockRelations
Depends #38457
Closes #38240
References
StudioWebPortalSettings API
Output from Acceptance Testing