[New Resource]: DataZone Glossary #38602

ThomasZalewski · 2024-07-30T19:23:11Z

Description

This resource will allow practitioners to create DataZone Glossary for a DataZone Domain via Terraform.

Relations

References

Output from Acceptance Testing

% make testacc TESTS=TestAccDataZoneGlossary PKG=datazone
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/datazone/... -v -count 1 -parallel 20 -run='TestAccDataZoneGlossary'  -timeout 360m
=== RUN   TestAccDataZoneGlossary_basic
=== PAUSE TestAccDataZoneGlossary_basic
=== RUN   TestAccDataZoneGlossary_update
=== PAUSE TestAccDataZoneGlossary_update
=== RUN   TestAccDataZoneGlossary_disappears
=== PAUSE TestAccDataZoneGlossary_disappears
=== CONT  TestAccDataZoneGlossary_basic
=== CONT  TestAccDataZoneGlossary_disappears
=== CONT  TestAccDataZoneGlossary_update
--- PASS: TestAccDataZoneGlossary_disappears (27.28s)
--- PASS: TestAccDataZoneGlossary_basic (28.41s)
--- PASS: TestAccDataZoneGlossary_update (38.86s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/datazone   44.480s

github-actions · 2024-07-30T19:23:26Z

Community Note

Voting for Prioritization

Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
Please see our prioritization guide for information on how we prioritize.
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

internal/service/datazone/glossary.go

johnsonaj · 2024-08-01T15:13:50Z

internal/service/datazone/glossary.go

+	if resp.Diagnostics.HasError() {
+		return
+	}
+	in.DomainIdentifier = plan.DomainId.ValueStringPointer()


I think we should name the input value to match what AWS has named it. In the event that the API changes it minimizes the possibility of collisions

johnsonaj · 2024-08-01T15:15:02Z

internal/service/datazone/glossary.go

+		return
+	}
+
+	if !plan.Description.Equal(state.Description) || !plan.Name.Equal(state.Name) || !plan.Description.Equal(state.Description) {


plan.Description.Equal(state.Description) is repeated in this condition

johnsonaj · 2024-08-01T15:17:40Z

internal/service/datazone/glossary_test.go

+
+
+
+


cleanup spacing

Co-authored-by: Adrian Johnson <adrian.johnson@hashicorp.com>

github-actions · 2024-08-01T15:19:31Z

Thank you for your contribution! 🚀

A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored.

For additional information refer to the AWS SDK for Go Versions page in the contributor guide.

johnsonaj · 2024-08-01T15:19:35Z

website/docs/r/datazone_glossary.html.markdown

+
+
+resource "aws_datazone_glossary" "test" {
+  client_token              = "example_token"


client_token should be set on the request by the provider. It should not be mentioned as an input value

johnsonaj · 2024-08-01T15:19:59Z

website/docs/r/datazone_glossary.html.markdown

+
+The following arguments are required:
+
+* `client_token` - (Required) Unique case-sensitive identifier that is provided to ensure the idempotency of the request. Must follow regex pattern of ^[\x21-\x7E]+$ and have length between 1 and 128.


^ similar to previous comment

johnsonaj

LGTM 🚀

% make testacc TESTS=TestAccDataZoneGlossary PKG=datazone

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/datazone/... -v -count 1 -parallel 20 -run='TestAccDataZoneGlossary'  -timeout 360m
=== RUN   TestAccDataZoneGlossary_basic
=== PAUSE TestAccDataZoneGlossary_basic
=== RUN   TestAccDataZoneGlossary_update
=== PAUSE TestAccDataZoneGlossary_update
=== RUN   TestAccDataZoneGlossary_disappears
=== PAUSE TestAccDataZoneGlossary_disappears
=== CONT  TestAccDataZoneGlossary_basic
=== CONT  TestAccDataZoneGlossary_disappears
=== CONT  TestAccDataZoneGlossary_update
--- PASS: TestAccDataZoneGlossary_basic (27.48s)
--- PASS: TestAccDataZoneGlossary_disappears (30.31s)
--- PASS: TestAccDataZoneGlossary_update (44.13s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/datazone	50.175s

github-actions · 2024-08-02T00:24:51Z

This functionality has been released in v5.61.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2024-09-01T02:24:39Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

Added support for datazone glossary resource.

cbf9852

ThomasZalewski requested a review from a team as a code owner July 30, 2024 19:23

ThomasZalewski added 5 commits July 30, 2024 15:44

Documentation changes

e6654ab

Ci formatting

9e123f9

Commentt removal

10945ab

Make gen changes

96d6a38

Added changelog

06e567a

johnsonaj reviewed Aug 1, 2024

View reviewed changes

internal/service/datazone/glossary.go Outdated Show resolved Hide resolved

johnsonaj reviewed Aug 1, 2024

View reviewed changes

Update internal/service/datazone/glossary.go

dafa43e

Co-authored-by: Adrian Johnson <adrian.johnson@hashicorp.com>

johnsonaj reviewed Aug 1, 2024

View reviewed changes

ThomasZalewski added 4 commits August 1, 2024 11:31

Changes to naming and documentation

cc4dda9

schema reordering + document changes

656ccec

test cleanup

034ed5d

Test cleanup 2

17ce18a

johnsonaj approved these changes Aug 1, 2024

View reviewed changes

ThomasZalewski merged commit 220214f into main Aug 1, 2024
42 checks passed

ThomasZalewski deleted the f/datazone-glossary-resource branch August 1, 2024 20:43

github-actions bot added this to the v5.61.0 milestone Aug 1, 2024

github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 2, 2024

github-actions bot locked as resolved and limited conversation to collaborators Sep 1, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[New Resource]: DataZone Glossary #38602

[New Resource]: DataZone Glossary #38602

ThomasZalewski commented Jul 30, 2024

github-actions bot commented Jul 30, 2024

johnsonaj Aug 1, 2024

johnsonaj Aug 1, 2024

johnsonaj Aug 1, 2024

github-actions bot commented Aug 1, 2024

johnsonaj Aug 1, 2024

johnsonaj Aug 1, 2024

johnsonaj left a comment

github-actions bot commented Aug 2, 2024

github-actions bot commented Sep 1, 2024



		resource "aws_datazone_glossary" "test" {
		client_token = "example_token"


		The following arguments are required:

		* `client_token` - (Required) Unique case-sensitive identifier that is provided to ensure the idempotency of the request. Must follow regex pattern of ^[\x21-\x7E]+$ and have length between 1 and 128.

[New Resource]: DataZone Glossary #38602

[New Resource]: DataZone Glossary #38602

Conversation

ThomasZalewski commented Jul 30, 2024

Description

Relations

References

Output from Acceptance Testing

github-actions bot commented Jul 30, 2024

Community Note

johnsonaj Aug 1, 2024

Choose a reason for hiding this comment

johnsonaj Aug 1, 2024

Choose a reason for hiding this comment

johnsonaj Aug 1, 2024

Choose a reason for hiding this comment

github-actions bot commented Aug 1, 2024

johnsonaj Aug 1, 2024

Choose a reason for hiding this comment

johnsonaj Aug 1, 2024

Choose a reason for hiding this comment

johnsonaj left a comment

Choose a reason for hiding this comment

github-actions bot commented Aug 2, 2024

github-actions bot commented Sep 1, 2024