fix: empty tags drift on fwprovider resources

[kkopachev]

Description

Fixing constant drift in resources which use fwprovider when supplied configuration has empty tags.

resource "aws_networkmonitor_monitor" "example" {
  aggregation_period = 30
  monitor_name       = "example"

  tags = {}
}

There are multiple resources affected by this, however I only tested aws_networkmonitor_monitor and aws_eks_pod_identity_association

Relations

Closes #38173

References

Same issue reported previously

Output from Acceptance Testing

Before

% make testacc TESTS=TestAccNetworkMonitorMonitor_tags PKG=networkmonitor
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.4 test ./internal/service/networkmonitor/... -v -count 1 -parallel 20 -run='TestAccNetworkMonitorMonitor_tags'  -timeout 360m
=== RUN   TestAccNetworkMonitorMonitor_tags
=== PAUSE TestAccNetworkMonitorMonitor_tags
=== CONT  TestAccNetworkMonitorMonitor_tags
    monitor_test.go:62: Step 1/5 error: After applying this test step, the refresh plan was not empty.
        stdout
        
        
        Terraform used the selected providers to generate the following execution
        plan. Resource actions are indicated with the following symbols:
          ~ update in-place
        
        Terraform will perform the following actions:
        
          # aws_networkmonitor_monitor.test will be updated in-place
          ~ resource "aws_networkmonitor_monitor" "test" {
                id                 = "tf-acc-test-8125989460679217634"
              + tags               = {}
                # (4 unchanged attributes hidden)
            }
        
        Plan: 0 to add, 1 to change, 0 to destroy.
--- FAIL: TestAccNetworkMonitorMonitor_tags (21.91s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/networkmonitor	22.183s
FAIL
make: *** [GNUmakefile:626: testacc] Error 1

After

% make testacc TESTS=TestAccNetworkMonitorMonitor_tags PKG=networkmonitor
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/networkmonitor/... -v -count 1 -parallel 20 -run='TestAccNetworkMonitorMonitor_tags'  -timeout 360m
=== RUN   TestAccNetworkMonitorMonitor_tags
=== PAUSE TestAccNetworkMonitorMonitor_tags
=== CONT  TestAccNetworkMonitorMonitor_tags
--- PASS: TestAccNetworkMonitorMonitor_tags (68.52s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/networkmonitor	68.781s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[kkopachev]

Pulled in latest changes from main, including #38869
This issue is still relevant

[gdavison]

Thanks for the PR, @kkopachev 🚀

[github-actions]

This functionality has been released in v5.67.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!