Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_lexmodelsv2(test): handle PreconditionFailedException on delete #38661

Merged
merged 1 commit into from
Aug 5, 2024
Merged

r/aws_lexmodelsv2(test): handle PreconditionFailedException on delete #38661

merged 1 commit into from
Aug 5, 2024

Commits on Aug 2, 2024

  1. r/aws_lexmodelsv2(test): handle PreconditionFailedException on delete 

    Fixes `_disappears` tests for the bot, bot locale, and bot version resources which were not handling `PreconditionFailedException` errors.

Before:

```console
% make testacc PKG=lexv2models TESTS="TestAccLexV2ModelsBot_disappears|TestAccLexV2ModelsBotLocale_disappears|TestAccLexV2ModelsBotVersion_disappears"
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/lexv2models/... -v -count 1 -parallel 20 -run='TestAccLexV2ModelsBot_disappears|TestAccLexV2ModelsBotLocale_disappears|TestAccLexV2ModelsBotVersion_disappears'  -timeout 360m

    bot_test.go:124: Error running post-test destroy, there may be dangling resources: exit status 1

        Error: deleting AWS Lex V2 Models Bot ("5FUXN7KX75"): operation error Lex Models V2: DeleteBot, https response error StatusCode: 412, RequestID: 91556c02-7ceb-4af4-81a8-c3480eede6d1, PreconditionFailedException: Failed to retrieve resource since it does not exist

        operation error Lex Models V2: DeleteBot, https response error StatusCode:
        412, RequestID: 91556c02-7ceb-4af4-81a8-c3480eede6d1,
        PreconditionFailedException: Failed to retrieve resource since it does not
        exist
--- FAIL: TestAccLexV2ModelsBot_disappears (16.42s)
=== NAME  TestAccLexV2ModelsBotLocale_disappears
    bot_locale_test.go:69: Error running post-test destroy, there may be dangling resources: exit status 1

        Error: deleting AWS Lex V2 Models Bot Locale ("en_US"): operation error Lex Models V2: DeleteBotLocale, https response error StatusCode: 412, RequestID: 7aca0765-3185-491b-8196-a0047c3aac3f, PreconditionFailedException: Failed to retrieve resource since it does not exist

        operation error Lex Models V2: DeleteBotLocale, https response error
        StatusCode: 412, RequestID: 7aca0765-3185-491b-8196-a0047c3aac3f,
        PreconditionFailedException: Failed to retrieve resource since it does not
        exist
--- FAIL: TestAccLexV2ModelsBotLocale_disappears (26.23s)
=== NAME  TestAccLexV2ModelsBotVersion_disappears
    bot_version_test.go:69: Error running post-test destroy, there may be dangling resources: exit status 1

        Error: deleting AWS Lex V2 Models Bot Version ("R8R6LBARQ7,1"): operation error Lex Models V2: DeleteBotVersion, https response error StatusCode: 412, RequestID: 2389c15b-6fa0-4793-9694-1f9553f93953, PreconditionFailedException: Failed to retrieve resource since it does not exist

        operation error Lex Models V2: DeleteBotVersion, https response error
        StatusCode: 412, RequestID: 2389c15b-6fa0-4793-9694-1f9553f93953,
        PreconditionFailedException: Failed to retrieve resource since it does not
        exist
--- FAIL: TestAccLexV2ModelsBotVersion_disappears (34.46s)
FAIL
FAIL    github.com/hashicorp/terraform-provider-aws/internal/service/lexv2models        40.510s

```

After:

```console
% make testacc PKG=lexv2models TESTS="TestAccLexV2ModelsBot_disappears|TestAccLexV2ModelsBotLocale_disappears|TestAccLexV2ModelsBotVersion_disappears"
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/lexv2models/... -v -count 1 -parallel 20 -run='TestAccLexV2ModelsBot_disappears|TestAccLexV2ModelsBotLocale_disappears|TestAccLexV2ModelsBotVersion_disappears'  -timeout 360m

--- PASS: TestAccLexV2ModelsBot_disappears (26.59s)
--- PASS: TestAccLexV2ModelsBotLocale_disappears (41.12s)
--- PASS: TestAccLexV2ModelsBotVersion_disappears (49.95s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lexv2models        56.721s
```
    @jar-b
    jar-b committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    5de07ad View commit details
    Browse the repository at this point in the history