[New Resource]: DataZone Form Type #38668

ThomasZalewski · 2024-08-02T20:14:33Z

Added support for the datazone form type resource

Description

This resource will allow practitioners to create DataZone Form Types for DataZone via Terraform.

Relations

Relates #37423

References

https://docs.aws.amazon.com/datazone/latest/APIReference/API_CreateFormType.html#datazone-CreateFormType-request-model

Output from Acceptance Testing

make testacc TESTS=TestAccDataZoneFormType PKG=datazone                           
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/datazone/... -v -count 1 -parallel 20 -run='TestAccDataZoneFormType'  -timeout 360m
=== RUN   TestAccDataZoneFormType_basic
=== PAUSE TestAccDataZoneFormType_basic
=== RUN   TestAccDataZoneFormType_disappears
=== PAUSE TestAccDataZoneFormType_disappears
=== CONT  TestAccDataZoneFormType_basic
=== CONT  TestAccDataZoneFormType_disappears
--- PASS: TestAccDataZoneFormType_disappears (28.49s)
--- PASS: TestAccDataZoneFormType_basic (29.51s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/datazone   34.489s

This commit has the provider consume default_tags from environment variables with the form `TF_AWS_DEFAULT_TAGS_<tag_name>=<tag_value>`. If the same tag is defined in both an environment variable and the Terraform config, the Terraform takes precedence.

Bumps [golang.org/x/tools](https://github.com/golang/tools) from 0.23.0 to 0.24.0. - [Release notes](https://github.com/golang/tools/releases) - [Commits](golang/tools@v0.23.0...v0.24.0) --- updated-dependencies: - dependency-name: golang.org/x/tools dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.25.0 to 0.26.0. - [Commits](golang/crypto@v0.25.0...v0.26.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…etypes (#38729) Bumps [github.com/hashicorp/terraform-plugin-framework-timetypes](https://github.com/hashicorp/terraform-plugin-framework-timetypes) from 0.4.0 to 0.5.0. - [Release notes](https://github.com/hashicorp/terraform-plugin-framework-timetypes/releases) - [Changelog](https://github.com/hashicorp/terraform-plugin-framework-timetypes/blob/main/CHANGELOG.md) - [Commits](hashicorp/terraform-plugin-framework-timetypes@v0.4.0...v0.5.0) --- updated-dependencies: - dependency-name: github.com/hashicorp/terraform-plugin-framework-timetypes dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…8739) Bumps the terraform-devex group with 1 update in the /tools/tfsdk2fw directory: [github.com/hashicorp/terraform-plugin-framework](https://github.com/hashicorp/terraform-plugin-framework). Updates `github.com/hashicorp/terraform-plugin-framework` from 1.10.0 to 1.11.0 - [Release notes](https://github.com/hashicorp/terraform-plugin-framework/releases) - [Changelog](https://github.com/hashicorp/terraform-plugin-framework/blob/main/CHANGELOG.md) - [Commits](hashicorp/terraform-plugin-framework@v1.10.0...v1.11.0) --- updated-dependencies: - dependency-name: github.com/hashicorp/terraform-plugin-framework dependency-type: indirect update-type: version-update:semver-minor dependency-group: terraform-devex ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [golang.org/x/tools](https://github.com/golang/tools) from 0.23.0 to 0.24.0. - [Release notes](https://github.com/golang/tools/releases) - [Commits](golang/tools@v0.23.0...v0.24.0) --- updated-dependencies: - dependency-name: golang.org/x/tools dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…dates (#38725) Bumps the aws-sdk-go group with 3 updates in the / directory: [github.com/aws/aws-sdk-go-v2/service/cognitoidentityprovider](https://github.com/aws/aws-sdk-go-v2), [github.com/aws/aws-sdk-go-v2/service/costoptimizationhub](https://github.com/aws/aws-sdk-go-v2) and [github.com/aws/aws-sdk-go-v2/service/workspaces](https://github.com/aws/aws-sdk-go-v2). Bumps the aws-sdk-go group with 3 updates in the /tools/tfsdk2fw directory: [github.com/aws/aws-sdk-go-v2/service/cognitoidentityprovider](https://github.com/aws/aws-sdk-go-v2), [github.com/aws/aws-sdk-go-v2/service/costoptimizationhub](https://github.com/aws/aws-sdk-go-v2) and [github.com/aws/aws-sdk-go-v2/service/workspaces](https://github.com/aws/aws-sdk-go-v2). Updates `github.com/aws/aws-sdk-go-v2/service/cognitoidentityprovider` from 1.41.4 to 1.42.0 - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Commits](aws/aws-sdk-go-v2@service/ecs/v1.41.4...service/s3/v1.42.0) Updates `github.com/aws/aws-sdk-go-v2/service/costoptimizationhub` from 1.7.3 to 1.8.0 - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/v1.8.0/CHANGELOG.md) - [Commits](aws/aws-sdk-go-v2@service/m2/v1.7.3...v1.8.0) Updates `github.com/aws/aws-sdk-go-v2/service/workspaces` from 1.44.3 to 1.45.0 - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Commits](aws/aws-sdk-go-v2@service/ecs/v1.44.3...service/s3/v1.45.0) Updates `github.com/aws/aws-sdk-go-v2/service/cognitoidentityprovider` from 1.41.4 to 1.42.0 - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Commits](aws/aws-sdk-go-v2@service/ecs/v1.41.4...service/s3/v1.42.0) Updates `github.com/aws/aws-sdk-go-v2/service/costoptimizationhub` from 1.7.3 to 1.8.0 - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/v1.8.0/CHANGELOG.md) - [Commits](aws/aws-sdk-go-v2@service/m2/v1.7.3...v1.8.0) Updates `github.com/aws/aws-sdk-go-v2/service/workspaces` from 1.44.3 to 1.45.0 - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Commits](aws/aws-sdk-go-v2@service/ecs/v1.44.3...service/s3/v1.45.0) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go-v2/service/cognitoidentityprovider dependency-type: direct:production update-type: version-update:semver-minor dependency-group: aws-sdk-go - dependency-name: github.com/aws/aws-sdk-go-v2/service/costoptimizationhub dependency-type: direct:production update-type: version-update:semver-minor dependency-group: aws-sdk-go - dependency-name: github.com/aws/aws-sdk-go-v2/service/workspaces dependency-type: direct:production update-type: version-update:semver-minor dependency-group: aws-sdk-go - dependency-name: github.com/aws/aws-sdk-go-v2/service/cognitoidentityprovider dependency-type: indirect update-type: version-update:semver-minor dependency-group: aws-sdk-go - dependency-name: github.com/aws/aws-sdk-go-v2/service/costoptimizationhub dependency-type: indirect update-type: version-update:semver-minor dependency-group: aws-sdk-go - dependency-name: github.com/aws/aws-sdk-go-v2/service/workspaces dependency-type: indirect update-type: version-update:semver-minor dependency-group: aws-sdk-go ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

internal/service/datazone/form_type.go

johnsonaj · 2024-08-07T14:10:33Z

internal/service/datazone/form_type.go

+func (r *resourceFormType) Metadata(_ context.Context, req resource.MetadataRequest, resp *resource.MetadataResponse) {
+	resp.TypeName = "aws_datazone_form_type"
+}
+func (r *resourceFormType) Schema(ctx context.Context, req resource.SchemaRequest, resp *resource.SchemaResponse) {


let's put the schema attributes in alphabetical order

johnsonaj · 2024-08-07T14:13:39Z

internal/service/datazone/form_type.go

+func (r *resourceFormType) Update(ctx context.Context, req resource.UpdateRequest, resp *resource.UpdateResponse) {
+}


This can be removed completely since it is embedded with framework.WithNoUpdate

internal/service/datazone/form_type.go

…pplication-sql s3 datasource aws_s3_object can read application/x-sql

r/aws_ecs_service: Add `force_delete` argument

Co-authored-by: Adrian Johnson <adrian.johnson@hashicorp.com>

[BUG] `aws_batch_job_definition`: add extra nil checks

…terraform-provider-aws into f/datazone-form-type-resource Merge conflicts

github-actions · 2024-08-07T16:13:29Z

Thank you for your contribution! 🚀

Please note that the CHANGELOG.md file contents are handled by the maintainers during merge. This is to prevent pull request merge conflicts, especially for contributions which may not be merged immediately. Please see the Contributing Guide for additional pull request review items.

Remove any changes to the CHANGELOG.md file and commit them in this pull request to prevent delays with reviewing and potentially merging this pull request.

github-actions · 2024-08-07T17:07:52Z

Thank you for your contribution! 🚀

Please note that the CHANGELOG.md file contents are handled by the maintainers during merge. This is to prevent pull request merge conflicts, especially for contributions which may not be merged immediately. Please see the Contributing Guide for additional pull request review items.

Remove any changes to the CHANGELOG.md file and commit them in this pull request to prevent delays with reviewing and potentially merging this pull request.

github-actions · 2024-09-14T02:16:19Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

showwin and others added 30 commits January 9, 2024 15:37

add New Resource aws_rds_integration

99f2724

add CHANGELOG

b7f1a83

Implement configuring ignore_tags via environment variables

6e39c92

Update names_data.hcl, add endpointID, patch gen

a6b479e

r/d/active_receipt_rule_set: Migrate to AWS SDK v2

f70546b

Merge branch 'hashicorp:main' into ses-awssdkv2-migration

6f2ce04

r/configuration_set.go: Migrate to AWS SDK v2

00dff0f

r/domain_dkim.go: Migrate to AWS SDK v2

ddaf310

Merge branch 'hashicorp:main' into ses-awssdkv2-migration

2c82b36

r/domain_identity.go: Migrate to AWS SDK v2

af0a4de

d/domain_identity: Migrate to AWS SDK v2

3ebaf0a

r/domain_identity_verification: Migrate to AWS SDK v2

0a600a8

Merge branch 'hashicorp:main' into ses-awssdkv2-migration

e7043c0

r/domain_mail_from: Migrate to AWS SDK v2

e84ca8f

r/d/email_identity: Migrate to AWS SDK v2

f60b2f7

Merge branch 'hashicorp:main' into ses-awssdkv2-migration

6da657f

r/event_destination: Migrate to AWS SDK v2

598a7af

Merge branch 'hashicorp:main' into ses-awssdkv2-migration

77560eb

r/identity_notification_topic: Migrate to AWS SDK v2

133d4af

r/identity_policy: Migrate to AWS SDK v2

21af40f

r/receipt_filter: Migrate to AWS SDK v2

74d1bec

guardduty: Migrate to AWS SDK v2

d1e450b

make gen

4396c56

d/guardduty_detector,r/guardduty_detector: Migrate to AWS SDK v2

ae411c3

r/guardduty_detector_feature.go: Migrate to AWS SDK v2

f813cd2

r/guardduty_filter: Migrate to AWS SDK v2

0f24685

d/guardduty_finding_ids: Migrate to AWS SDK v2

bddcca6

r/guardduty_invite_accepter: Migrate to AWS SDK v2

4e900cb

r/guardduty_ipset: Migrate to AWS SDK v2

87d327e

ewbankkit and others added 7 commits August 7, 2024 09:15

Update documentation.

9172b87

johnsonaj reviewed Aug 7, 2024

View reviewed changes

internal/service/datazone/form_type.go Outdated Show resolved Hide resolved

johnsonaj reviewed Aug 7, 2024

View reviewed changes

internal/service/datazone/form_type.go Show resolved Hide resolved

jar-b and others added 10 commits August 7, 2024 10:26

chore: make clean-tidy (#38740)

5ce05d8

chore: fix changelog entry (#38718)

3591050

Update CHANGELOG.md for #38718

a2332ce

Merge pull request #38737 from sumit-sampang-rai/s3-object-can-read-a…

311c0a3

…pplication-sql s3 datasource aws_s3_object can read application/x-sql

Merge pull request #38707 from hashicorp/s-fixes

cc111ec

r/aws_ecs_service: Add `force_delete` argument

Update CHANGELOG.md for #38707

118618a

chore: changelog

d0db897

Update internal/service/datazone/form_type.go

98a27b0

Co-authored-by: Adrian Johnson <adrian.johnson@hashicorp.com>

Merge pull request #38716 from aristosvo/b-aws_job_defition-nilcheck

6ed0de6

[BUG] `aws_batch_job_definition`: add extra nil checks

Merge branch 'f/datazone-form-type-resource' of github.com:hashicorp/…

bfe748e

…terraform-provider-aws into f/datazone-form-type-resource Merge conflicts

ThomasZalewski requested review from breathingdust and justinretzolk as code owners August 7, 2024 16:13

removed update

62b3051

ThomasZalewski closed this Aug 7, 2024

jar-b deleted the f/datazone-form-type-resource branch August 14, 2024 17:59

github-actions bot locked as resolved and limited conversation to collaborators Sep 14, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[New Resource]: DataZone Form Type #38668

[New Resource]: DataZone Form Type #38668

ThomasZalewski commented Aug 2, 2024 •

edited

Loading

johnsonaj Aug 7, 2024

johnsonaj Aug 7, 2024

github-actions bot commented Aug 7, 2024

github-actions bot commented Aug 7, 2024

github-actions bot commented Sep 14, 2024

		func (r resourceFormType) Update(ctx context.Context, req resource.UpdateRequest, resp resource.UpdateResponse) {
		}

[New Resource]: DataZone Form Type #38668

[New Resource]: DataZone Form Type #38668

Conversation

ThomasZalewski commented Aug 2, 2024 • edited Loading

Description

Relations

References

Output from Acceptance Testing

johnsonaj Aug 7, 2024

Choose a reason for hiding this comment

johnsonaj Aug 7, 2024

Choose a reason for hiding this comment

github-actions bot commented Aug 7, 2024

github-actions bot commented Aug 7, 2024

github-actions bot commented Sep 14, 2024

ThomasZalewski commented Aug 2, 2024 •

edited

Loading