Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/framework/flex: add WithFieldNameSuffix option #38692

Merged
merged 1 commit into from
Aug 6, 2024
Merged

internal/framework/flex: add WithFieldNameSuffix option #38692

merged 1 commit into from
Aug 6, 2024

Conversation

jar-b
Copy link
Member

@jar-b jar-b commented Aug 5, 2024

Description

This option will allow a suffix to be provided which can improve matching of field names between Terraform and AWS data structures. This can be useful in cases where field names differ by a consistent suffix between the Create/Update and Read AWS data structures.

Relations

Closes #38626

@jar-b
internal/framework/flex: add WithFieldNameSuffix option
8aea73e 
This option will allow a suffix to be provided which can improve matching of field names between Terraform and AWS data structures. This can be useful in cases where field names differ by a consistent suffix between the Create/Update and Read AWS data structures.
@jar-b jar-b requested a review from a team as a code owner August 5, 2024 17:27
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 5, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Aug 5, 2024
@jar-b jar-b added flex Pertains to FLatteners and EXpanders. enhancement Requests to existing resources that expand the functionality or scope. labels Aug 5, 2024
johnsonaj
johnsonaj approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

go test -count=1 ./internal/framework/flex/... -run=TestExpand\|TestFlatten -v

--- PASS: TestFlattenFrameworkStringValueMap (0.00s)
    --- PASS: TestFlattenFrameworkStringValueMap/nil_map (0.00s)
    --- PASS: TestFlattenFrameworkStringValueMap/two_elements (0.00s)
    --- PASS: TestFlattenFrameworkStringValueMap/zero_elements (0.00s)
--- PASS: TestExpandFrameworkStringValueMap (0.00s)
    --- PASS: TestExpandFrameworkStringValueMap/null (0.00s)
    --- PASS: TestExpandFrameworkStringValueMap/zero_elements (0.00s)
    --- PASS: TestExpandFrameworkStringValueMap/unknown (0.00s)
    --- PASS: TestExpandFrameworkStringValueMap/two_elements (0.00s)
    --- PASS: TestExpandFrameworkStringValueMap/invalid_element_type (0.00s)
--- PASS: TestFlattenFrameworkStringMap (0.00s)
    --- PASS: TestFlattenFrameworkStringMap/nil_map (0.00s)
    --- PASS: TestFlattenFrameworkStringMap/zero_elements (0.00s)
    --- PASS: TestFlattenFrameworkStringMap/two_elements (0.00s)
--- PASS: TestExpandFrameworkInt32ValueList (0.00s)
    --- PASS: TestExpandFrameworkInt32ValueList/null (0.00s)
    --- PASS: TestExpandFrameworkInt32ValueList/invalid_element_type (0.00s)
    --- PASS: TestExpandFrameworkInt32ValueList/unknown (0.00s)
    --- PASS: TestExpandFrameworkInt32ValueList/two_elements (0.00s)
    --- PASS: TestExpandFrameworkInt32ValueList/zero_elements (0.00s)
--- PASS: TestFlattenFrameworkInt64ValueList (0.00s)
    --- PASS: TestFlattenFrameworkInt64ValueList/nil_array (0.00s)
    --- PASS: TestFlattenFrameworkInt64ValueList/two_elements (0.00s)
    --- PASS: TestFlattenFrameworkInt64ValueList/zero_elements (0.00s)
--- PASS: TestFlattenFrameworkStringValueListLegacy (0.00s)
    --- PASS: TestFlattenFrameworkStringValueListLegacy/two_elements (0.00s)
    --- PASS: TestFlattenFrameworkStringValueListLegacy/nil_array (0.00s)
    --- PASS: TestFlattenFrameworkStringValueListLegacy/zero_elements (0.00s)
--- PASS: TestFlattenFrameworkStringValueList (0.00s)
    --- PASS: TestFlattenFrameworkStringValueList/two_elements (0.00s)
    --- PASS: TestFlattenFrameworkStringValueList/zero_elements (0.00s)
    --- PASS: TestFlattenFrameworkStringValueList/nil_array (0.00s)
--- PASS: TestFlattenFrameworkStringListLegacy (0.00s)
    --- PASS: TestFlattenFrameworkStringListLegacy/two_elements (0.00s)
    --- PASS: TestFlattenFrameworkStringListLegacy/nil_array (0.00s)
    --- PASS: TestFlattenFrameworkStringListLegacy/zero_elements (0.00s)
--- PASS: TestExpandFrameworkStringMap (0.00s)
    --- PASS: TestExpandFrameworkStringMap/zero_elements (0.00s)
    --- PASS: TestExpandFrameworkStringMap/null (0.00s)
    --- PASS: TestExpandFrameworkStringMap/two_elements (0.00s)
    --- PASS: TestExpandFrameworkStringMap/null_element (0.00s)
    --- PASS: TestExpandFrameworkStringMap/invalid_element_type (0.00s)
    --- PASS: TestExpandFrameworkStringMap/unknown (0.00s)
--- PASS: TestFlattenFrameworkStringList (0.00s)
    --- PASS: TestFlattenFrameworkStringList/two_elements (0.00s)
    --- PASS: TestFlattenFrameworkStringList/zero_elements (0.00s)
    --- PASS: TestFlattenFrameworkStringList/nil_array (0.00s)
--- PASS: TestFlattenPrePopulate (0.00s)
    --- PASS: TestFlattenPrePopulate/string (0.00s)
    --- PASS: TestFlattenPrePopulate/nested_set (0.00s)
    --- PASS: TestFlattenPrePopulate/nested_list (0.00s)
--- PASS: TestFlattenSimpleNestedBlockWithFloat64 (0.00s)
    --- PASS: TestFlattenSimpleNestedBlockWithFloat64/single_nested_valid_value (0.00s)
--- PASS: TestExpandFrameworkStringyValueSet (0.00s)
    --- PASS: TestExpandFrameworkStringyValueSet/invalid_element_type (0.00s)
    --- PASS: TestExpandFrameworkStringyValueSet/two_elements (0.00s)
    --- PASS: TestExpandFrameworkStringyValueSet/zero_elements (0.00s)
    --- PASS: TestExpandFrameworkStringyValueSet/unknown (0.00s)
    --- PASS: TestExpandFrameworkStringyValueSet/null (0.00s)
--- PASS: TestExpandFrameworkInt32List (0.00s)
    --- PASS: TestExpandFrameworkInt32List/unknown (0.00s)
    --- PASS: TestExpandFrameworkInt32List/invalid_element_type (0.00s)
    --- PASS: TestExpandFrameworkInt32List/zero_elements (0.00s)
    --- PASS: TestExpandFrameworkInt32List/two_elements (0.00s)
    --- PASS: TestExpandFrameworkInt32List/null (0.00s)
--- PASS: TestFlattenFrameworkStringValueSet (0.00s)
    --- PASS: TestFlattenFrameworkStringValueSet/two_elements (0.00s)
    --- PASS: TestFlattenFrameworkStringValueSet/nil_array (0.00s)
    --- PASS: TestFlattenFrameworkStringValueSet/zero_elements (0.00s)
--- PASS: TestExpandOptions (0.00s)
    --- PASS: TestExpandOptions/ignore_custom_field (0.00s)
    --- PASS: TestExpandOptions/ignore_tags_by_default (0.00s)
    --- PASS: TestExpandOptions/empty_source_with_tags (0.00s)
    --- PASS: TestExpandOptions/include_tags_with_option_override (0.00s)
--- PASS: TestFlattenComplexNestedBlockWithFloat32 (0.00s)
    --- PASS: TestFlattenComplexNestedBlockWithFloat32/single_nested_valid_value (0.00s)
--- PASS: TestExpandListOfNestedObject (0.00s)
    --- PASS: TestExpandListOfNestedObject/empty_list_value_to_single_struct (0.00s)
    --- PASS: TestExpandListOfNestedObject/empty_value_to_[]struct (0.00s)
    --- PASS: TestExpandListOfNestedObject/null_value_to_[]*struct (0.00s)
    --- PASS: TestExpandListOfNestedObject/empty_value_to_[]*struct (0.00s)
    --- PASS: TestExpandListOfNestedObject/null_value_to_single_struct (0.00s)
    --- PASS: TestExpandListOfNestedObject/null_value_to_[]struct (0.00s)
    --- PASS: TestExpandListOfNestedObject/single_list_value_to_single_struct (0.00s)
    --- PASS: TestExpandListOfNestedObject/valid_value_to_[]*struct (0.00s)
    --- PASS: TestExpandListOfNestedObject/valid_value_to_[]struct (0.00s)
--- PASS: TestFlattenFrameworkStringValueSetLegacy (0.00s)
    --- PASS: TestFlattenFrameworkStringValueSetLegacy/zero_elements (0.00s)
    --- PASS: TestFlattenFrameworkStringValueSetLegacy/nil_array (0.00s)
    --- PASS: TestFlattenFrameworkStringValueSetLegacy/two_elements (0.00s)
--- PASS: TestFlattenComplexNestedBlockWithFloat64 (0.00s)
    --- PASS: TestFlattenComplexNestedBlockWithFloat64/single_nested_valid_value (0.00s)
--- PASS: TestExpandInterfaceTypedExpander (0.00s)
    --- PASS: TestExpandInterfaceTypedExpander/empty_set_Source_and_empty_interface_Target (0.00s)
    --- PASS: TestExpandInterfaceTypedExpander/top_level (0.00s)
    --- PASS: TestExpandInterfaceTypedExpander/single_list_Source_and_single_interface_Target (0.00s)
    --- PASS: TestExpandInterfaceTypedExpander/object_value_Source_and_struct_Target (0.00s)
    --- PASS: TestExpandInterfaceTypedExpander/empty_list_Source_and_empty_interface_Target (0.00s)
    --- PASS: TestExpandInterfaceTypedExpander/top_level_return_value_does_not_implement_target_interface (0.00s)
    --- PASS: TestExpandInterfaceTypedExpander/non-empty_set_Source_and_non-empty_interface_Target (0.00s)
    --- PASS: TestExpandInterfaceTypedExpander/non-empty_list_Source_and_non-empty_interface_Target (0.00s)
    --- PASS: TestExpandInterfaceTypedExpander/single_set_Source_and_single_interface_Target (0.00s)
    --- PASS: TestExpandInterfaceTypedExpander/single_list_non-Expander_Source_and_single_interface_Target (0.00s)
--- PASS: TestFlattenOptions (0.00s)
    --- PASS: TestFlattenOptions/include_tags_with_option_override (0.00s)
    --- PASS: TestFlattenOptions/ignore_custom_field (0.00s)
    --- PASS: TestFlattenOptions/ignore_tags_by_default (0.00s)
    --- PASS: TestFlattenOptions/empty_source_with_tags (0.00s)
--- PASS: TestFlattenFrameworkInt64ValueSet (0.00s)
    --- PASS: TestFlattenFrameworkInt64ValueSet/nil_array (0.00s)
    --- PASS: TestFlattenFrameworkInt64ValueSet/two_elements (0.00s)
    --- PASS: TestFlattenFrameworkInt64ValueSet/zero_elements (0.00s)
--- PASS: TestFlattenFrameworkInt32ValueSet (0.00s)
    --- PASS: TestFlattenFrameworkInt32ValueSet/nil_array (0.00s)
    --- PASS: TestFlattenFrameworkInt32ValueSet/two_elements (0.00s)
    --- PASS: TestFlattenFrameworkInt32ValueSet/zero_elements (0.00s)
--- PASS: TestExpandInterface (0.00s)
    --- PASS: TestExpandInterface/top_level (0.00s)
    --- PASS: TestExpandInterface/empty_set_Source_and_empty_interface_Target (0.00s)
    --- PASS: TestExpandInterface/empty_list_Source_and_empty_interface_Target (0.00s)
    --- PASS: TestExpandInterface/non-empty_list_Source_and_non-empty_interface_Target (0.00s)
    --- PASS: TestExpandInterface/single_list_non-Expander_Source_and_single_interface_Target (0.00s)
    --- PASS: TestExpandInterface/object_value_Source_and_struct_Target (0.00s)
    --- PASS: TestExpandInterface/non-empty_set_Source_and_non-empty_interface_Target (0.00s)
    --- PASS: TestExpandInterface/top_level_return_value_does_not_implement_target_interface (0.00s)
    --- PASS: TestExpandInterface/single_set_Source_and_single_interface_Target (0.00s)
    --- PASS: TestExpandInterface/single_list_Source_and_single_interface_Target (0.00s)
--- PASS: TestFlattenFrameworkStringSet (0.00s)
    --- PASS: TestFlattenFrameworkStringSet/nil_array (0.00s)
    --- PASS: TestFlattenFrameworkStringSet/two_elements (0.00s)
    --- PASS: TestFlattenFrameworkStringSet/zero_elements (0.00s)
--- PASS: TestFlattenFrameworkInt32ValueList (0.00s)
    --- PASS: TestFlattenFrameworkInt32ValueList/zero_elements (0.00s)
    --- PASS: TestFlattenFrameworkInt32ValueList/two_elements (0.00s)
    --- PASS: TestFlattenFrameworkInt32ValueList/nil_array (0.00s)
--- PASS: TestFlattenFrameworkInt32List (0.00s)
    --- PASS: TestFlattenFrameworkInt32List/two_elements (0.00s)
    --- PASS: TestFlattenFrameworkInt32List/nil_array (0.00s)
    --- PASS: TestFlattenFrameworkInt32List/zero_elements (0.00s)
--- PASS: TestExpandFrameworkStringValueList (0.00s)
    --- PASS: TestExpandFrameworkStringValueList/null (0.00s)
    --- PASS: TestExpandFrameworkStringValueList/zero_elements (0.00s)
    --- PASS: TestExpandFrameworkStringValueList/invalid_element_type (0.00s)
    --- PASS: TestExpandFrameworkStringValueList/two_elements (0.00s)
    --- PASS: TestExpandFrameworkStringValueList/unknown (0.00s)
--- PASS: TestFlattenFlattener (0.00s)
    --- PASS: TestFlattenFlattener/top_level_incompatible_struct_Target (0.00s)
    --- PASS: TestFlattenFlattener/empty_*struct_list_Source_and_empty_set_Target (0.00s)
    --- PASS: TestFlattenFlattener/empty_struct_list_Source_and_empty_set_Target (0.00s)
    --- PASS: TestFlattenFlattener/single_struct_Source_and_single_list_Target (0.00s)
    --- PASS: TestFlattenFlattener/struct_Source_and_object_value_Target (0.00s)
    --- PASS: TestFlattenFlattener/empty_*struct_list_Source_and_empty_list_Target (0.00s)
    --- PASS: TestFlattenFlattener/top_level_struct_Source (0.00s)
    --- PASS: TestFlattenFlattener/non-empty_*struct_list_Source_and_non-empty_set_Target (0.00s)
    --- PASS: TestFlattenFlattener/single_*struct_Source_and_single_set_Target (0.00s)
    --- PASS: TestFlattenFlattener/nil_*struct_Source_and_null_set_Target (0.00s)
    --- PASS: TestFlattenFlattener/nil_*struct_Source_and_null_list_Target (0.00s)
    --- PASS: TestFlattenFlattener/empty_struct_list_Source_and_empty_list_Target (0.00s)
    --- PASS: TestFlattenFlattener/single_struct_Source_and_single_set_Target (0.00s)
    --- PASS: TestFlattenFlattener/non-empty_*struct_list_Source_and_non-empty_list_Target (0.00s)
    --- PASS: TestFlattenFlattener/*struct_Source_and_object_value_Target (0.00s)
    --- PASS: TestFlattenFlattener/non-empty_struct_list_Source_and_set_Target (0.00s)
    --- PASS: TestFlattenFlattener/non-empty_struct_list_Source_and_non-empty_list_Target (0.00s)
    --- PASS: TestFlattenFlattener/single_*struct_Source_and_single_list_Target (0.00s)
--- PASS: TestExpandExpander (0.00s)
    --- PASS: TestExpandExpander/top_level_expands_to_nil (0.00s)
    --- PASS: TestExpandExpander/single_list_Source_and_single_struct_Target (0.00s)
    --- PASS: TestExpandExpander/top_level_string_Target (0.00s)
    --- PASS: TestExpandExpander/empty_set_Source_and_empty_*struct_Target (0.00s)
    --- PASS: TestExpandExpander/object_value_Source_and_*struct_Target (0.00s)
    --- PASS: TestExpandExpander/non-empty_set_Source_and_non-empty_struct_Target (0.00s)
    --- PASS: TestExpandExpander/empty_list_Source_and_empty_struct_Target (0.00s)
    --- PASS: TestExpandExpander/non-empty_list_Source_and_non-empty_struct_Target (0.00s)
    --- PASS: TestExpandExpander/single_set_Source_and_single_struct_Target (0.00s)
    --- PASS: TestExpandExpander/top_level_incompatible_non-struct_Target (0.00s)
    --- PASS: TestExpandExpander/object_value_Source_and_struct_Target (0.00s)
    --- PASS: TestExpandExpander/empty_set_Source_and_empty_struct_Target (0.00s)
    --- PASS: TestExpandExpander/empty_list_Source_and_empty_*struct_Target (0.00s)
    --- PASS: TestExpandExpander/non-empty_list_Source_and_non-empty_*struct_Target (0.00s)
    --- PASS: TestExpandExpander/single_set_Source_and_single_*struct_Target (0.00s)
    --- PASS: TestExpandExpander/top_level_incompatible_struct_Target (0.00s)
    --- PASS: TestExpandExpander/single_list_Source_and_single_*struct_Target (0.00s)
    --- PASS: TestExpandExpander/top_level_struct_Target (0.00s)
    --- PASS: TestExpandExpander/non-empty_set_Source_and_non-empty_*struct_Target (0.00s)
--- PASS: TestFlattenFrameworkInt32Set (0.00s)
    --- PASS: TestFlattenFrameworkInt32Set/two_elements (0.00s)
    --- PASS: TestFlattenFrameworkInt32Set/zero_elements (0.00s)
    --- PASS: TestFlattenFrameworkInt32Set/nil_array (0.00s)
--- PASS: TestFlattenInterface (0.00s)
    --- PASS: TestFlattenInterface/nil_interface_Source_and_list_Target (0.00s)
    --- PASS: TestFlattenInterface/empty_interface_list_Source_and_empty_list_Target (0.00s)
    --- PASS: TestFlattenInterface/nil_interface_list_Source_and_empty_list_Target (0.00s)
    --- PASS: TestFlattenInterface/interface_Source_and_nested_object_Target (0.00s)
    --- PASS: TestFlattenInterface/single_interface_Source_and_single_list_Target (0.00s)
    --- PASS: TestFlattenInterface/nil_interface_Source_and_nested_object_Target (0.00s)
    --- PASS: TestFlattenInterface/single_interface_Source_and_non-Flattener_list_Target (0.00s)
    --- PASS: TestFlattenInterface/single_interface_Source_and_single_set_Target (0.00s)
    --- PASS: TestFlattenInterface/empty_interface_list_Source_and_empty_set_Target (0.00s)
    --- PASS: TestFlattenInterface/nil_interface_list_Source_and_empty_set_Target (0.00s)
    --- PASS: TestFlattenInterface/nil_interface_Source_and_non-Flattener_list_Target (0.00s)
    --- PASS: TestFlattenInterface/non-empty_interface_list_Source_and_non-empty_set_Target (0.00s)
    --- PASS: TestFlattenInterface/non-empty_interface_list_Source_and_non-empty_list_Target (0.00s)
    --- PASS: TestFlattenInterface/nil_interface_Source_and_set_Target (0.00s)
--- PASS: TestExpandSetOfStringEnum (0.00s)
    --- PASS: TestExpandSetOfStringEnum/valid_value (0.00s)
    --- PASS: TestExpandSetOfStringEnum/null_value (0.00s)
    --- PASS: TestExpandSetOfStringEnum/empty_value (0.00s)
--- PASS: TestFlattenSimpleNestedBlockWithFloat32 (0.00s)
    --- PASS: TestFlattenSimpleNestedBlockWithFloat32/single_nested_valid_value (0.00s)
--- PASS: TestFlattenComplexSingleNestedBlock (0.00s)
    --- PASS: TestFlattenComplexSingleNestedBlock/single_nested_block_pointer (0.00s)
--- PASS: TestFlattenComplexNestedBlockWithStringEnum (0.00s)
    --- PASS: TestFlattenComplexNestedBlockWithStringEnum/single_nested_zero_value (0.00s)
    --- PASS: TestFlattenComplexNestedBlockWithStringEnum/single_nested_empty_value (0.00s)
    --- PASS: TestFlattenComplexNestedBlockWithStringEnum/single_nested_valid_value (0.00s)
--- PASS: TestFlattenFrameworkInt64Set (0.00s)
    --- PASS: TestFlattenFrameworkInt64Set/nil_array (0.00s)
    --- PASS: TestFlattenFrameworkInt64Set/two_elements (0.00s)
    --- PASS: TestFlattenFrameworkInt64Set/zero_elements (0.00s)
--- PASS: TestFlattenFrameworkInt64List (0.00s)
    --- PASS: TestFlattenFrameworkInt64List/two_elements (0.00s)
    --- PASS: TestFlattenFrameworkInt64List/nil_array (0.00s)
    --- PASS: TestFlattenFrameworkInt64List/zero_elements (0.00s)
--- PASS: TestExpandListOfStringEnum (0.00s)
    --- PASS: TestExpandListOfStringEnum/null_value (0.00s)
    --- PASS: TestExpandListOfStringEnum/valid_value (0.00s)
    --- PASS: TestExpandListOfStringEnum/empty_value (0.00s)
--- PASS: TestExpandTypedExpander (0.00s)
    --- PASS: TestExpandTypedExpander/top_level_expands_to_nil (0.00s)
    --- PASS: TestExpandTypedExpander/top_level_struct_Target (0.00s)
    --- PASS: TestExpandTypedExpander/empty_list_Source_and_empty_struct_Target (0.00s)
    --- PASS: TestExpandTypedExpander/single_list_Source_and_single_*struct_Target (0.00s)
    --- PASS: TestExpandTypedExpander/non-empty_set_Source_and_non-empty_*struct_Target (0.00s)
    --- PASS: TestExpandTypedExpander/top_level_incompatible_struct_Target (0.00s)
    --- PASS: TestExpandTypedExpander/empty_set_Source_and_empty_struct_Target (0.00s)
    --- PASS: TestExpandTypedExpander/empty_list_Source_and_empty_*struct_Target (0.00s)
    --- PASS: TestExpandTypedExpander/non-empty_list_Source_and_non-empty_struct_Target (0.00s)
    --- PASS: TestExpandTypedExpander/object_value_Source_and_*struct_Target (0.00s)
    --- PASS: TestExpandTypedExpander/non-empty_list_Source_and_non-empty_*struct_Target (0.00s)
    --- PASS: TestExpandTypedExpander/single_set_Source_and_single_struct_Target (0.00s)
    --- PASS: TestExpandTypedExpander/empty_set_Source_and_empty_*struct_Target (0.00s)
    --- PASS: TestExpandTypedExpander/single_list_Source_and_single_struct_Target (0.00s)
    --- PASS: TestExpandTypedExpander/single_set_Source_and_single_*struct_Target (0.00s)
    --- PASS: TestExpandTypedExpander/non-empty_set_Source_and_non-empty_struct_Target (0.00s)
    --- PASS: TestExpandTypedExpander/object_value_Source_and_struct_Target (0.00s)
--- PASS: TestExpandSimpleNestedBlockWithStringEnum (0.00s)
    --- PASS: TestExpandSimpleNestedBlockWithStringEnum/single_nested_valid_value (0.00s)
    --- PASS: TestExpandSimpleNestedBlockWithStringEnum/single_nested_null_value (0.00s)
--- PASS: TestExpandFrameworkStringValueSet (0.00s)
    --- PASS: TestExpandFrameworkStringValueSet/invalid_element_type (0.00s)
    --- PASS: TestExpandFrameworkStringValueSet/null (0.00s)
    --- PASS: TestExpandFrameworkStringValueSet/zero_elements (0.00s)
    --- PASS: TestExpandFrameworkStringValueSet/two_elements (0.00s)
    --- PASS: TestExpandFrameworkStringValueSet/unknown (0.00s)
--- PASS: TestExpand (0.00s)
    --- PASS: TestExpand/non-pointer_Target (0.00s)
    --- PASS: TestExpand/typed_nil_Source (0.00s)
    --- PASS: TestExpand/single_ARN_Source_and_single_*string_Target (0.00s)
    --- PASS: TestExpand/empty_struct_Source_and_Target (0.00s)
    --- PASS: TestExpand/single_string_Source_and_single_string_Target (0.00s)
    --- PASS: TestExpand/single_ARN_Source_and_single_string_Target (0.00s)
    --- PASS: TestExpand/types.String_to_string (0.00s)
    --- PASS: TestExpand/typed_nil_Target (0.00s)
    --- PASS: TestExpand/non-struct_Target (0.00s)
    --- PASS: TestExpand/nil_Target (0.00s)
    --- PASS: TestExpand/single_string_struct_pointer_Source_and_empty_Target (0.00s)
    --- PASS: TestExpand/nil_Source (0.00s)
    --- PASS: TestExpand/single_string_Source_and_single_int64_Target (0.00s)
    --- PASS: TestExpand/empty_struct_pointer_Source_and_Target (0.00s)
    --- PASS: TestExpand/resource_name_prefix (0.00s)
    --- PASS: TestExpand/non-struct_Source (0.00s)
    --- PASS: TestExpand/capitalization_field_names (0.00s)
    --- PASS: TestExpand/JSONValue_Source_to_json_interface_Target (0.00s)
    --- PASS: TestExpand/timestamp (0.00s)
    --- PASS: TestExpand/timestamp_pointer (0.00s)
    --- PASS: TestExpand/single_string_Source_and_single_*string_Target (0.00s)
    --- PASS: TestExpand/Collection_of_primitive_types_Source_and_slice_or_map_of_primtive_types_Target (0.00s)
    --- PASS: TestExpand/does_not_implement_attr.Value_Source (0.00s)
    --- PASS: TestExpand/resource_name_suffix (0.00s)
    --- PASS: TestExpand/primitive_types_Source_and_primtive_types_Target (0.00s)
    --- PASS: TestExpand/plural_field_names (0.00s)
--- PASS: TestExpandComplexNestedBlockWithStringEnum (0.00s)
    --- PASS: TestExpandComplexNestedBlockWithStringEnum/single_nested_valid_value (0.00s)
    --- PASS: TestExpandComplexNestedBlockWithStringEnum/single_nested_null_value (0.00s)
--- PASS: TestExpandComplexSingleNestedBlock (0.00s)
    --- PASS: TestExpandComplexSingleNestedBlock/single_nested_block_pointer (0.00s)
--- PASS: TestExpandStringEnum (0.00s)
    --- PASS: TestExpandStringEnum/empty_value (0.00s)
    --- PASS: TestExpandStringEnum/valid_value (0.00s)
--- PASS: TestFlattenSimpleNestedBlockWithStringEnum (0.00s)
    --- PASS: TestFlattenSimpleNestedBlockWithStringEnum/single_nested_valid_value (0.00s)
    --- PASS: TestFlattenSimpleNestedBlockWithStringEnum/single_nested_empty_value (0.00s)
--- PASS: TestFlattenSimpleSingleNestedBlock (0.00s)
    --- PASS: TestFlattenSimpleSingleNestedBlock/single_nested_block_value (0.00s)
    --- PASS: TestFlattenSimpleSingleNestedBlock/single_nested_block_pointer (0.00s)
    --- PASS: TestFlattenSimpleSingleNestedBlock/single_nested_block_nil (0.00s)
--- PASS: TestExpandFrameworkStringList (0.00s)
    --- PASS: TestExpandFrameworkStringList/null (0.00s)
    --- PASS: TestExpandFrameworkStringList/invalid_element_type (0.00s)
    --- PASS: TestExpandFrameworkStringList/unknown (0.00s)
    --- PASS: TestExpandFrameworkStringList/two_elements (0.00s)
    --- PASS: TestExpandFrameworkStringList/zero_elements (0.00s)
--- PASS: TestExpandFrameworkInt64List (0.00s)
    --- PASS: TestExpandFrameworkInt64List/null (0.00s)
    --- PASS: TestExpandFrameworkInt64List/invalid_element_type (0.00s)
    --- PASS: TestExpandFrameworkInt64List/zero_elements (0.00s)
    --- PASS: TestExpandFrameworkInt64List/unknown (0.00s)
    --- PASS: TestExpandFrameworkInt64List/two_elements (0.00s)
--- PASS: TestExpandSimpleSingleNestedBlock (0.00s)
    --- PASS: TestExpandSimpleSingleNestedBlock/single_nested_block_nil (0.00s)
    --- PASS: TestExpandSimpleSingleNestedBlock/single_nested_block_pointer (0.00s)
    --- PASS: TestExpandSimpleSingleNestedBlock/single_nested_block_value (0.00s)
--- PASS: TestFlattenFrameworkStringValueMapLegacy (0.00s)
    --- PASS: TestFlattenFrameworkStringValueMapLegacy/nil_map (0.00s)
    --- PASS: TestFlattenFrameworkStringValueMapLegacy/two_elements (0.00s)
    --- PASS: TestFlattenFrameworkStringValueMapLegacy/zero_elements (0.00s)
--- PASS: TestExpandFrameworkInt32Set (0.00s)
    --- PASS: TestExpandFrameworkInt32Set/null (0.00s)
    --- PASS: TestExpandFrameworkInt32Set/unknown (0.00s)
    --- PASS: TestExpandFrameworkInt32Set/zero_elements (0.00s)
    --- PASS: TestExpandFrameworkInt32Set/two_elements (0.00s)
    --- PASS: TestExpandFrameworkInt32Set/invalid_element_type (0.00s)
--- PASS: TestExpandFrameworkInt64Set (0.00s)
    --- PASS: TestExpandFrameworkInt64Set/unknown (0.00s)
    --- PASS: TestExpandFrameworkInt64Set/null (0.00s)
    --- PASS: TestExpandFrameworkInt64Set/two_elements (0.00s)
    --- PASS: TestExpandFrameworkInt64Set/invalid_element_type (0.00s)
    --- PASS: TestExpandFrameworkInt64Set/zero_elements (0.00s)
--- PASS: TestExpandFrameworkInt64ValueList (0.00s)
    --- PASS: TestExpandFrameworkInt64ValueList/null (0.00s)
    --- PASS: TestExpandFrameworkInt64ValueList/unknown (0.00s)
    --- PASS: TestExpandFrameworkInt64ValueList/zero_elements (0.00s)
    --- PASS: TestExpandFrameworkInt64ValueList/two_elements (0.00s)
    --- PASS: TestExpandFrameworkInt64ValueList/invalid_element_type (0.00s)
--- PASS: TestExpandListOfInt64 (0.00s)
    --- PASS: TestExpandListOfInt64/null_value_[]*int32 (0.00s)
    --- PASS: TestExpandListOfInt64/empty_value_[]int64 (0.00s)
    --- PASS: TestExpandListOfInt64/valid_value_[]*int64 (0.00s)
    --- PASS: TestExpandListOfInt64/empty_value_[]*int64 (0.00s)
    --- PASS: TestExpandListOfInt64/valid_value_[]int32 (0.00s)
    --- PASS: TestExpandListOfInt64/null_value_[]int64 (0.00s)
    --- PASS: TestExpandListOfInt64/null_value_[]int32 (0.00s)
    --- PASS: TestExpandListOfInt64/valid_value_[]int64 (0.00s)
    --- PASS: TestExpandListOfInt64/valid_value_[]*int32 (0.00s)
    --- PASS: TestExpandListOfInt64/empty_value_[]int32 (0.00s)
    --- PASS: TestExpandListOfInt64/null_value_[]*int64 (0.00s)
    --- PASS: TestExpandListOfInt64/empty_value_[]*int32 (0.00s)
--- PASS: TestExpandSetOfNestedObject (0.00s)
    --- PASS: TestExpandSetOfNestedObject/null_value_to_[]struct (0.00s)
    --- PASS: TestExpandSetOfNestedObject/empty_set_value_to_single_struct (0.00s)
    --- PASS: TestExpandSetOfNestedObject/empty_value_to_[]*struct (0.00s)
    --- PASS: TestExpandSetOfNestedObject/null_value_to_single_struct (0.00s)
    --- PASS: TestExpandSetOfNestedObject/empty_value_to_[]struct (0.00s)
    --- PASS: TestExpandSetOfNestedObject/single_set_value_to_single_struct (0.00s)
    --- PASS: TestExpandSetOfNestedObject/valid_value_to_[]struct (0.00s)
    --- PASS: TestExpandSetOfNestedObject/null_value_to_[]*struct (0.00s)
    --- PASS: TestExpandSetOfNestedObject/valid_value_to_[]*struct (0.00s)
--- PASS: TestExpandFrameworkStringSet (0.00s)
    --- PASS: TestExpandFrameworkStringSet/zero_elements (0.00s)
    --- PASS: TestExpandFrameworkStringSet/unknown (0.00s)
    --- PASS: TestExpandFrameworkStringSet/two_elements (0.00s)
    --- PASS: TestExpandFrameworkStringSet/null (0.00s)
    --- PASS: TestExpandFrameworkStringSet/invalid_element_type (0.00s)
--- PASS: TestExpandFrameworkInt32ValueSet (0.00s)
    --- PASS: TestExpandFrameworkInt32ValueSet/null (0.00s)
    --- PASS: TestExpandFrameworkInt32ValueSet/zero_elements (0.00s)
    --- PASS: TestExpandFrameworkInt32ValueSet/unknown (0.00s)
    --- PASS: TestExpandFrameworkInt32ValueSet/invalid_element_type (0.00s)
    --- PASS: TestExpandFrameworkInt32ValueSet/two_elements (0.00s)
--- PASS: TestExpandFrameworkInt64ValueSet (0.00s)
    --- PASS: TestExpandFrameworkInt64ValueSet/invalid_element_type (0.00s)
    --- PASS: TestExpandFrameworkInt64ValueSet/unknown (0.00s)
    --- PASS: TestExpandFrameworkInt64ValueSet/null (0.00s)
    --- PASS: TestExpandFrameworkInt64ValueSet/zero_elements (0.00s)
    --- PASS: TestExpandFrameworkInt64ValueSet/two_elements (0.00s)
--- PASS: TestExpandSetOfInt64 (0.00s)
    --- PASS: TestExpandSetOfInt64/valid_value_[]*int32 (0.00s)
    --- PASS: TestExpandSetOfInt64/null_value_[]int32 (0.00s)
    --- PASS: TestExpandSetOfInt64/null_value_[]int64 (0.00s)
    --- PASS: TestExpandSetOfInt64/empty_value_[]*int32 (0.00s)
    --- PASS: TestExpandSetOfInt64/valid_value_[]int64 (0.00s)
    --- PASS: TestExpandSetOfInt64/valid_value_[]int32 (0.00s)
    --- PASS: TestExpandSetOfInt64/null_value_[]*int32 (0.00s)
    --- PASS: TestExpandSetOfInt64/empty_value_[]int64 (0.00s)
    --- PASS: TestExpandSetOfInt64/null_value_[]*int64 (0.00s)
    --- PASS: TestExpandSetOfInt64/empty_value_[]int32 (0.00s)
    --- PASS: TestExpandSetOfInt64/valid_value_[]*int64 (0.00s)
    --- PASS: TestExpandSetOfInt64/empty_value_[]*int64 (0.00s)
--- PASS: TestFlattenGeneric (0.00s)
    --- PASS: TestFlattenGeneric/empty_[]struct_and_empty_set_Target (0.00s)
    --- PASS: TestFlattenGeneric/nil_[]struct_and_null_list_Target (0.00s)
    --- PASS: TestFlattenGeneric/map_of_map_of_string (0.00s)
    --- PASS: TestFlattenGeneric/*struct_Source_and_single_set_Target (0.00s)
    --- PASS: TestFlattenGeneric/non-empty_[]struct_and_non-empty_set_Target (0.00s)
    --- PASS: TestFlattenGeneric/map_block_enum_key (0.00s)
    --- PASS: TestFlattenGeneric/nil_map_block_key_ptr (0.00s)
    --- PASS: TestFlattenGeneric/*struct_Source_and_single_list_Target (0.00s)
    --- PASS: TestFlattenGeneric/nil_*struct_Source_and_single_list_Target (0.00s)
    --- PASS: TestFlattenGeneric/empty_[]*struct_and_empty_set_Target (0.00s)
    --- PASS: TestFlattenGeneric/map_block_key_list (0.00s)
    --- PASS: TestFlattenGeneric/nil_[]*struct_and_null_list_Target (0.00s)
    --- PASS: TestFlattenGeneric/empty_[]*struct_and_empty_list_Target (0.00s)
    --- PASS: TestFlattenGeneric/map_of_string_pointer (0.00s)
    --- PASS: TestFlattenGeneric/complex_Source_and_complex_Target (0.00s)
    --- PASS: TestFlattenGeneric/map_of_map_of_string_pointer (0.00s)
    --- PASS: TestFlattenGeneric/map_of_string (0.00s)
    --- PASS: TestFlattenGeneric/empty_[]struct_and_empty_list_Target (0.00s)
    --- PASS: TestFlattenGeneric/non-empty_[]*struct_and_non-empty_set_Target (0.00s)
    --- PASS: TestFlattenGeneric/nil_[]*struct_and_null_set_Target (0.00s)
    --- PASS: TestFlattenGeneric/nil_map_block_key (0.00s)
    --- PASS: TestFlattenGeneric/nil_[]struct_and_null_set_Target (0.00s)
    --- PASS: TestFlattenGeneric/map_block_key_ptr_both (0.00s)
    --- PASS: TestFlattenGeneric/map_block_key_ptr_source (0.00s)
    --- PASS: TestFlattenGeneric/non-empty_[]*struct_and_non-empty_list_Target (0.00s)
    --- PASS: TestFlattenGeneric/map_block_key_set (0.00s)
    --- PASS: TestFlattenGeneric/non-empty_[]struct_and_non-empty_list_Target (0.00s)
    --- PASS: TestFlattenGeneric/nested_string_map (0.00s)
--- PASS: TestExpandGeneric (0.00s)
    --- PASS: TestExpandGeneric/map_of_string_pointer (0.00s)
    --- PASS: TestExpandGeneric/map_of_map_of_string_pointer (0.00s)
    --- PASS: TestExpandGeneric/empty_set_Source_and_empty_[]*struct_Target (0.00s)
    --- PASS: TestExpandGeneric/non-empty_set_Source_and_non-empty_[]*struct_Target (0.00s)
    --- PASS: TestExpandGeneric/single_set_Source_and_*struct_Target (0.00s)
    --- PASS: TestExpandGeneric/non-empty_set_Source_and_non-empty_[]struct_Target (0.00s)
    --- PASS: TestExpandGeneric/map_block_key_set (0.00s)
    --- PASS: TestExpandGeneric/null_map_block_key (0.00s)
    --- PASS: TestExpandGeneric/empty_list_Source_and_empty_[]*struct_Target (0.00s)
    --- PASS: TestExpandGeneric/non-empty_list_Source_and_non-empty_[]struct_Target (0.00s)
    --- PASS: TestExpandGeneric/map_of_map_of_string (0.00s)
    --- PASS: TestExpandGeneric/map_of_string (0.00s)
    --- PASS: TestExpandGeneric/single_list_Source_and_*struct_Target (0.00s)
    --- PASS: TestExpandGeneric/empty_list_Source_and_empty_[]struct_Target (0.00s)
    --- PASS: TestExpandGeneric/map_block_key_ptr_both (0.00s)
    --- PASS: TestExpandGeneric/non-empty_list_Source_and_non-empty_[]*struct_Target (0.00s)
    --- PASS: TestExpandGeneric/nested_string_map (0.00s)
    --- PASS: TestExpandGeneric/map_block_key_ptr_source (0.00s)
    --- PASS: TestExpandGeneric/map_block_key_list (0.00s)
    --- PASS: TestExpandGeneric/complex_Source_and_complex_Target (0.00s)
    --- PASS: TestExpandGeneric/map_block_enum_key (0.00s)
--- PASS: TestFlatten (0.00s)
    --- PASS: TestFlatten/non-pointer_Target (0.00s)
    --- PASS: TestFlatten/timestamp (0.00s)
    --- PASS: TestFlatten/single_string_Source_and_single_string_Target (0.00s)
    --- PASS: TestFlatten/timestamp_pointer (0.00s)
    --- PASS: TestFlatten/single_nil_*string_Source_and_single_ARN_Target (0.00s)
    --- PASS: TestFlatten/single_string_Source_and_single_ARN_Target (0.00s)
    --- PASS: TestFlatten/single_*string_Source_and_single_string_Target (0.00s)
    --- PASS: TestFlatten/nil_Source (0.00s)
    --- PASS: TestFlatten/zero_value_slice_or_map_of_primtive_types_Source_and_Collection_of_primtive_types_Target (0.00s)
    --- PASS: TestFlatten/empty_struct_Source_and_Target (0.00s)
    --- PASS: TestFlatten/single_empty_string_Source_and_single_string_Target (0.00s)
    --- PASS: TestFlatten/timestamp_nil (0.00s)
    --- PASS: TestFlatten/plural_ordinary_field_names (0.00s)
    --- PASS: TestFlatten/empty_struct_pointer_Source_and_Target (0.00s)
    --- PASS: TestFlatten/timestamp_empty (0.00s)
    --- PASS: TestFlatten/primtive_types_Source_and_primtive_types_Target (0.00s)
    --- PASS: TestFlatten/resource_name_suffix (0.00s)
    --- PASS: TestFlatten/json_interface_Source_string_Target (0.00s)
    --- PASS: TestFlatten/typed_nil_Target (0.00s)
    --- PASS: TestFlatten/nil_Target (0.00s)
    --- PASS: TestFlatten/typed_nil_Source (0.00s)
    --- PASS: TestFlatten/non-struct_Target (0.00s)
    --- PASS: TestFlatten/single_string_struct_pointer_Source_and_empty_Target (0.00s)
    --- PASS: TestFlatten/capitalization_field_names (0.00s)
    --- PASS: TestFlatten/resource_name_prefix (0.00s)
    --- PASS: TestFlatten/does_not_implement_attr.Value_Target (0.00s)
    --- PASS: TestFlatten/single_string_Source_and_single_int64_Target (0.00s)
    --- PASS: TestFlatten/non-struct_Source (0.00s)
    --- PASS: TestFlatten/strange_plurality (0.00s)
    --- PASS: TestFlatten/single_*string_Source_and_single_ARN_Target (0.00s)
    --- PASS: TestFlatten/slice_or_map_of_primtive_types_Source_and_Collection_of_primtive_types_Target (0.00s)
    --- PASS: TestFlatten/json_interface_Source_JSONValue_Target (0.00s)
    --- PASS: TestFlatten/single_nil_*string_Source_and_single_string_Target (0.00s)
    --- PASS: TestFlatten/zero_value_slice_or_map_of_string_type_Source_and_Collection_of_string_types_Target (0.00s)
    --- PASS: TestFlatten/slice_or_map_of_string_types_Source_and_Collection_of_string_types_Target (0.00s)
    --- PASS: TestFlatten/plural_field_names (0.00s)
    --- PASS: TestFlatten/zero_value_primtive_types_Source_and_primtive_types_Target (0.00s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/framework/flex	0.386s

@jar-b jar-b merged commit 4fea629 into main Aug 6, 2024
51 of 52 checks passed
@jar-b jar-b deleted the f-field-name-suffix-opt branch August 6, 2024 13:41
@github-actions github-actions bot added this to the v5.62.0 milestone Aug 6, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 9, 2024

This functionality has been released in v5.62.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@johnsonaj johnsonaj johnsonaj approved these changes

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. flex Pertains to FLatteners and EXpanders. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.62.0
Development

Successfully merging this pull request may close these issues.

[Enhancement]: AutoFlex - Add option for field name suffix
2 participants
@jar-b @johnsonaj