Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Resource]: DataZone Glossary Term #38706

Merged
merged 9 commits into from
Aug 13, 2024

Conversation

ThomasZalewski
Copy link
Contributor

Description

This resource will allow practitioners to create DataZone Glossary Terms for DataZone via Terraform.

Relations

Relates #37423

References

https://docs.aws.amazon.com/datazone/latest/APIReference/API_CreateGlossaryTerm.html

Output from Acceptance Testing

make testacc TESTS=TestAccDataZoneGlossaryTerm PKG=datazone 
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/datazone/... -v -count 1 -parallel 20 -run='TestAccDataZoneGlossaryTerm'  -timeout 360m
=== RUN   TestAccDataZoneGlossaryTerm_basic
=== PAUSE TestAccDataZoneGlossaryTerm_basic
=== RUN   TestAccDataZoneGlossaryTerm_update
=== PAUSE TestAccDataZoneGlossaryTerm_update
=== RUN   TestAccDataZoneGlossaryTerm_disappears
=== PAUSE TestAccDataZoneGlossaryTerm_disappears
=== CONT  TestAccDataZoneGlossaryTerm_basic
=== CONT  TestAccDataZoneGlossaryTerm_disappears
=== CONT  TestAccDataZoneGlossaryTerm_update
--- PASS: TestAccDataZoneGlossaryTerm_disappears (30.74s)
--- PASS: TestAccDataZoneGlossaryTerm_basic (31.52s)
--- PASS: TestAccDataZoneGlossaryTerm_update (43.67s)
PASS```

@ThomasZalewski ThomasZalewski requested a review from a team as a code owner August 6, 2024 14:55
Copy link

github-actions bot commented Aug 6, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. generators Relates to code generators. service/datazone Issues and PRs that pertain to the datazone service. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Aug 6, 2024
@johnsonaj johnsonaj self-assigned this Aug 13, 2024
@johnsonaj johnsonaj added the new-resource Introduces a new resource. label Aug 13, 2024
Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

% make testacc TESTARGS='-run=TestAccDataZoneGlossaryTerm_' PKG=datazone

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/datazone/... -v -count 1 -parallel 20  -run=TestAccDataZoneGlossaryTerm_ -timeout 360m
=== RUN   TestAccDataZoneGlossaryTerm_basic
=== PAUSE TestAccDataZoneGlossaryTerm_basic
=== RUN   TestAccDataZoneGlossaryTerm_update
=== PAUSE TestAccDataZoneGlossaryTerm_update
=== RUN   TestAccDataZoneGlossaryTerm_disappears
=== PAUSE TestAccDataZoneGlossaryTerm_disappears
=== CONT  TestAccDataZoneGlossaryTerm_basic
=== CONT  TestAccDataZoneGlossaryTerm_disappears
=== CONT  TestAccDataZoneGlossaryTerm_update
--- PASS: TestAccDataZoneGlossaryTerm_disappears (34.61s)
--- PASS: TestAccDataZoneGlossaryTerm_basic (35.68s)
--- PASS: TestAccDataZoneGlossaryTerm_update (51.23s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/datazone	57.312s

@ThomasZalewski ThomasZalewski merged commit 125bc3b into main Aug 13, 2024
42 checks passed
@github-actions github-actions bot added this to the v5.63.0 milestone Aug 13, 2024
terraform-aws-provider bot pushed a commit that referenced this pull request Aug 13, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 15, 2024
Copy link

This functionality has been released in v5.63.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. service/datazone Issues and PRs that pertain to the datazone service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants