-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/aws_elasticache_replication_group: fix crash setting replicas_per_node_group
#38797
Conversation
Community NoteVoting for Prioritization
For Submitters
|
…node_group` In cases where the `NodeGroups` list in the read ouput is empty, the provider would crash attempting to read the `NodeGroupMembers` count from the first item in the list. ```console % make testacc PKG=elasticache TESTS="TestAccElastiCacheReplicationGroup_basic|TestAccElastiCacheReplicationGroup_ClusterMode_basic" make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.22.6 test ./internal/service/elasticache/... -v -count 1 -parallel 20 -run='TestAccElastiCacheReplicationGroup_basic|TestAccElastiCacheReplicationGroup_ClusterMode_basic' -timeout 360m --- PASS: TestAccElastiCacheReplicationGroup_basic_v5 (775.08s) --- PASS: TestAccElastiCacheReplicationGroup_basic (775.23s) --- PASS: TestAccElastiCacheReplicationGroup_ClusterMode_basic (915.76s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/elasticache 921.685s ```
5e84f7c
to
366b28e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
This functionality has been released in v5.63.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
In cases where the
NodeGroups
list in the read ouput is empty, the provider would crash attempting to read theNodeGroupMembers
count from the first item in the list.Relations
Closes #37771
Output from Acceptance Testing