Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource/aws_cloudtrail_organization_admin_account #38817

Merged
merged 14 commits into from
Aug 13, 2024

Conversation

yhamano0312
Copy link
Contributor

Description

This resource enables the addition of a CloudTrail delegated administrator.

Relations

Closes #29179

References

https://docs.aws.amazon.com/awscloudtrail/latest/userguide/cloudtrail-add-delegated-administrator.html

Output from Acceptance Testing

% make testacc TESTS=TestAccCloudTrailOrganizationAdminAccount_ PKG=cloudtrail
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/cloudtrail/... -v -count 1 -parallel 20 -run='TestAccCloudTrailOrganizationAdminAccount_'  -timeout 360m
=== RUN   TestAccCloudTrailOrganizationAdminAccount_basic
--- PASS: TestAccCloudTrailOrganizationAdminAccount_basic (26.82s)
=== RUN   TestAccCloudTrailOrganizationAdminAccount_disappears
--- PASS: TestAccCloudTrailOrganizationAdminAccount_disappears (20.99s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudtrail	52.122s

...

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/cloudtrail Issues and PRs that pertain to the cloudtrail service. generators Relates to code generators. needs-triage Waiting for first response or review from a maintainer. labels Aug 11, 2024
@yhamano0312 yhamano0312 marked this pull request as ready for review August 11, 2024 14:54
@yhamano0312 yhamano0312 requested a review from a team as a code owner August 11, 2024 14:54
fix Service Name Scan
@yhamano0312 yhamano0312 force-pushed the f-cloudtrail-organization-enable branch from 7651663 to 9cfc870 Compare August 11, 2024 15:31
@yhamano0312 yhamano0312 marked this pull request as draft August 11, 2024 15:33
@yhamano0312 yhamano0312 marked this pull request as ready for review August 11, 2024 23:09
@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 12, 2024
@ewbankkit ewbankkit self-assigned this Aug 13, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 13, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccCloudTrail_serial/OrganizationDelegatedAdminAccount' PKG=cloudtrail
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/cloudtrail/... -v -count 1 -parallel 20  -run=TestAccCloudTrail_serial/OrganizationDelegatedAdminAccount -timeout 360m
=== RUN   TestAccCloudTrail_serial
=== PAUSE TestAccCloudTrail_serial
=== CONT  TestAccCloudTrail_serial
=== RUN   TestAccCloudTrail_serial/OrganizationDelegatedAdminAccount
=== RUN   TestAccCloudTrail_serial/OrganizationDelegatedAdminAccount/basic
=== RUN   TestAccCloudTrail_serial/OrganizationDelegatedAdminAccount/disappears
--- PASS: TestAccCloudTrail_serial (29.08s)
    --- PASS: TestAccCloudTrail_serial/OrganizationDelegatedAdminAccount (29.08s)
        --- PASS: TestAccCloudTrail_serial/OrganizationDelegatedAdminAccount/basic (15.68s)
        --- PASS: TestAccCloudTrail_serial/OrganizationDelegatedAdminAccount/disappears (13.40s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudtrail	33.972s

@ewbankkit
Copy link
Contributor

@yhamano0312 Thanks for the contribution 🎉 👏.
I renamed the new resource to aws_cloudtrail_organization_delegated_admin_account in order to match the underlying AWS API.

@ewbankkit ewbankkit merged commit 73c72f5 into hashicorp:main Aug 13, 2024
41 checks passed
@github-actions github-actions bot added this to the v5.63.0 milestone Aug 13, 2024
@yhamano0312 yhamano0312 deleted the f-cloudtrail-organization-enable branch August 13, 2024 23:21
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 15, 2024
Copy link

This functionality has been released in v5.63.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. service/cloudtrail Issues and PRs that pertain to the cloudtrail service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Resource]: Delegated Administrator for CloudTrail
3 participants