Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_ecs_service: fix crash from nil service_registries item #38883

Merged
merged 1 commit into from
Aug 15, 2024

Commits on Aug 15, 2024

  1. r/aws_ecs_service: fix crash from nil service_registries item

    This appears only to be possible with dynamic blocks as explicitly setting a nil `service_registries` block will prompt for the required attributes within the block. However, this fix should prevent the nil value from being expanded and causing a crash under the dynamic block scenario.
    
    ```console
    % make testacc PKG=ecs TESTS=TestAccECSService_ServiceRegistries
    make: Verifying source code with gofmt...
    ==> Checking that code complies with gofmt requirements...
    TF_ACC=1 go1.22.6 test ./internal/service/ecs/... -v -count 1 -parallel 20 -run='TestAccECSService_ServiceRegistries'  -timeout 360m
    
    --- PASS: TestAccECSService_ServiceRegistries_basic (145.59s)
    --- PASS: TestAccECSService_ServiceRegistries_container (145.60s)
    --- PASS: TestAccECSService_ServiceRegistries_removal (156.46s)
    --- PASS: TestAccECSService_ServiceRegistries_changes (279.51s)
    PASS
    ok      github.com/hashicorp/terraform-provider-aws/internal/service/ecs        285.700s
    ```
    jar-b committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    d4d39e0 View commit details
    Browse the repository at this point in the history