-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Appconfig extension role arn optional #38900
Appconfig extension role arn optional #38900
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @gagan-bhullar-tech 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
> make testacc TESTARGS='-run=TestAccAppConfigExtension_' PKG=appconfig
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.0 test ./internal/service/appconfig/... -v -count 1 -parallel 20 -run=TestAccAppConfigExtension_ -timeout 360m
=== RUN TestAccAppConfigExtension_tags
=== PAUSE TestAccAppConfigExtension_tags
=== RUN TestAccAppConfigExtension_tags_null
=== PAUSE TestAccAppConfigExtension_tags_null
=== RUN TestAccAppConfigExtension_tags_AddOnUpdate
=== PAUSE TestAccAppConfigExtension_tags_AddOnUpdate
=== RUN TestAccAppConfigExtension_tags_EmptyTag_OnCreate
=== PAUSE TestAccAppConfigExtension_tags_EmptyTag_OnCreate
=== RUN TestAccAppConfigExtension_tags_EmptyTag_OnUpdate_Add
=== PAUSE TestAccAppConfigExtension_tags_EmptyTag_OnUpdate_Add
=== RUN TestAccAppConfigExtension_tags_EmptyTag_OnUpdate_Replace
=== PAUSE TestAccAppConfigExtension_tags_EmptyTag_OnUpdate_Replace
=== RUN TestAccAppConfigExtension_tags_DefaultTags_providerOnly
=== PAUSE TestAccAppConfigExtension_tags_DefaultTags_providerOnly
=== RUN TestAccAppConfigExtension_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccAppConfigExtension_tags_DefaultTags_nonOverlapping
=== RUN TestAccAppConfigExtension_tags_DefaultTags_overlapping
=== PAUSE TestAccAppConfigExtension_tags_DefaultTags_overlapping
=== RUN TestAccAppConfigExtension_tags_DefaultTags_updateToProviderOnly
=== PAUSE TestAccAppConfigExtension_tags_DefaultTags_updateToProviderOnly
=== RUN TestAccAppConfigExtension_tags_DefaultTags_updateToResourceOnly
=== PAUSE TestAccAppConfigExtension_tags_DefaultTags_updateToResourceOnly
=== RUN TestAccAppConfigExtension_tags_DefaultTags_emptyResourceTag
=== PAUSE TestAccAppConfigExtension_tags_DefaultTags_emptyResourceTag
=== RUN TestAccAppConfigExtension_tags_DefaultTags_emptyProviderOnlyTag
=== PAUSE TestAccAppConfigExtension_tags_DefaultTags_emptyProviderOnlyTag
=== RUN TestAccAppConfigExtension_tags_DefaultTags_nullOverlappingResourceTag
=== PAUSE TestAccAppConfigExtension_tags_DefaultTags_nullOverlappingResourceTag
=== RUN TestAccAppConfigExtension_tags_DefaultTags_nullNonOverlappingResourceTag
=== PAUSE TestAccAppConfigExtension_tags_DefaultTags_nullNonOverlappingResourceTag
=== RUN TestAccAppConfigExtension_tags_ComputedTag_OnCreate
=== PAUSE TestAccAppConfigExtension_tags_ComputedTag_OnCreate
=== RUN TestAccAppConfigExtension_tags_ComputedTag_OnUpdate_Add
=== PAUSE TestAccAppConfigExtension_tags_ComputedTag_OnUpdate_Add
=== RUN TestAccAppConfigExtension_tags_ComputedTag_OnUpdate_Replace
=== PAUSE TestAccAppConfigExtension_tags_ComputedTag_OnUpdate_Replace
=== RUN TestAccAppConfigExtension_basic
=== PAUSE TestAccAppConfigExtension_basic
=== RUN TestAccAppConfigExtension_ActionPoint
=== PAUSE TestAccAppConfigExtension_ActionPoint
=== RUN TestAccAppConfigExtension_Parameter
=== PAUSE TestAccAppConfigExtension_Parameter
=== RUN TestAccAppConfigExtension_Name
=== PAUSE TestAccAppConfigExtension_Name
=== RUN TestAccAppConfigExtension_Description
=== PAUSE TestAccAppConfigExtension_Description
=== RUN TestAccAppConfigExtension_disappears
=== PAUSE TestAccAppConfigExtension_disappears
=== CONT TestAccAppConfigExtension_tags
=== CONT TestAccAppConfigExtension_Parameter
=== CONT TestAccAppConfigExtension_Name
=== CONT TestAccAppConfigExtension_tags_EmptyTag_OnCreate
=== CONT TestAccAppConfigExtension_basic
=== CONT TestAccAppConfigExtension_tags_ComputedTag_OnCreate
=== CONT TestAccAppConfigExtension_tags_EmptyTag_OnUpdate_Add
=== CONT TestAccAppConfigExtension_tags_DefaultTags_overlapping
=== CONT TestAccAppConfigExtension_tags_DefaultTags_updateToProviderOnly
=== CONT TestAccAppConfigExtension_Description
=== CONT TestAccAppConfigExtension_tags_AddOnUpdate
=== CONT TestAccAppConfigExtension_tags_DefaultTags_nullOverlappingResourceTag
=== CONT TestAccAppConfigExtension_tags_DefaultTags_nullNonOverlappingResourceTag
=== CONT TestAccAppConfigExtension_tags_DefaultTags_nonOverlapping
=== CONT TestAccAppConfigExtension_tags_DefaultTags_emptyProviderOnlyTag
=== CONT TestAccAppConfigExtension_ActionPoint
=== CONT TestAccAppConfigExtension_tags_null
=== CONT TestAccAppConfigExtension_tags_DefaultTags_updateToResourceOnly
=== CONT TestAccAppConfigExtension_tags_EmptyTag_OnUpdate_Replace
=== CONT TestAccAppConfigExtension_disappears
--- PASS: TestAccAppConfigExtension_disappears (51.84s)
=== CONT TestAccAppConfigExtension_tags_DefaultTags_providerOnly
--- PASS: TestAccAppConfigExtension_basic (54.56s)
=== CONT TestAccAppConfigExtension_tags_ComputedTag_OnUpdate_Replace
--- PASS: TestAccAppConfigExtension_tags_DefaultTags_nullNonOverlappingResourceTag (63.84s)
=== CONT TestAccAppConfigExtension_tags_DefaultTags_emptyResourceTag
--- PASS: TestAccAppConfigExtension_tags_ComputedTag_OnCreate (63.88s)
=== CONT TestAccAppConfigExtension_tags_ComputedTag_OnUpdate_Add
--- PASS: TestAccAppConfigExtension_tags_DefaultTags_nullOverlappingResourceTag (63.98s)
--- PASS: TestAccAppConfigExtension_tags_DefaultTags_emptyProviderOnlyTag (64.37s)
--- PASS: TestAccAppConfigExtension_tags_null (79.87s)
--- PASS: TestAccAppConfigExtension_Description (87.17s)
--- PASS: TestAccAppConfigExtension_Name (90.35s)
--- PASS: TestAccAppConfigExtension_tags_EmptyTag_OnUpdate_Replace (96.89s)
--- PASS: TestAccAppConfigExtension_tags_AddOnUpdate (97.65s)
--- PASS: TestAccAppConfigExtension_tags_DefaultTags_updateToResourceOnly (98.04s)
--- PASS: TestAccAppConfigExtension_tags_DefaultTags_updateToProviderOnly (98.73s)
--- PASS: TestAccAppConfigExtension_tags_EmptyTag_OnCreate (103.06s)
--- PASS: TestAccAppConfigExtension_Parameter (108.04s)
--- PASS: TestAccAppConfigExtension_ActionPoint (108.41s)
--- PASS: TestAccAppConfigExtension_tags_DefaultTags_emptyResourceTag (45.51s)
--- PASS: TestAccAppConfigExtension_tags_EmptyTag_OnUpdate_Add (117.06s)
--- PASS: TestAccAppConfigExtension_tags_ComputedTag_OnUpdate_Replace (67.84s)
--- PASS: TestAccAppConfigExtension_tags_DefaultTags_overlapping (123.86s)
--- PASS: TestAccAppConfigExtension_tags_DefaultTags_nonOverlapping (124.33s)
--- PASS: TestAccAppConfigExtension_tags_ComputedTag_OnUpdate_Add (61.76s)
--- PASS: TestAccAppConfigExtension_tags (135.05s)
--- PASS: TestAccAppConfigExtension_tags_DefaultTags_providerOnly (103.17s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/appconfig 159.727s
@gagan-bhullar-tech Thank you for your contribution!! |
This functionality has been released in v5.66.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This PR makes role_arn optional in App config extension action point.
Relations
Closes #38709