Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate WorkLink resources to AWS SDK v2 #38928

Merged
merged 8 commits into from
Aug 20, 2024

Conversation

DanielRieske
Copy link
Contributor

@DanielRieske DanielRieske commented Aug 19, 2024

Description

This PR migrates the WorkLink resources to AWS SDKv2.

Because this service has been deprecated all tests are skipped with an explanation.

Relations

Closes #36227
Relates #32976

References

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAcc' PKG=worklink
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/worklink/... -v -count 1 -parallel 20  -run=TestAcc -timeout 360m
=== RUN   TestAccWorkLinkFleet_basic
    fleet_test.go:27: skipping test; Amazon WorkLink has been deprecated and will be removed in the next major release
--- SKIP: TestAccWorkLinkFleet_basic (0.00s)
=== RUN   TestAccWorkLinkFleet_displayName
    fleet_test.go:58: skipping test; Amazon WorkLink has been deprecated and will be removed in the next major release
--- SKIP: TestAccWorkLinkFleet_displayName (0.00s)
=== RUN   TestAccWorkLinkFleet_optimizeForEndUserLocation
    fleet_test.go:94: skipping test; Amazon WorkLink has been deprecated and will be removed in the next major release
--- SKIP: TestAccWorkLinkFleet_optimizeForEndUserLocation (0.00s)
=== RUN   TestAccWorkLinkFleet_auditStreamARN
    fleet_test.go:130: skipping test; Amazon WorkLink has been deprecated and will be removed in the next major release
--- SKIP: TestAccWorkLinkFleet_auditStreamARN (0.00s)
=== RUN   TestAccWorkLinkFleet_network
    fleet_test.go:159: skipping test; Amazon WorkLink has been deprecated and will be removed in the next major release
--- SKIP: TestAccWorkLinkFleet_network (0.00s)
=== RUN   TestAccWorkLinkFleet_deviceCaCertificate
    fleet_test.go:205: skipping test; Amazon WorkLink has been deprecated and will be removed in the next major release
--- SKIP: TestAccWorkLinkFleet_deviceCaCertificate (0.00s)
=== RUN   TestAccWorkLinkFleet_identityProvider
    fleet_test.go:241: skipping test; Amazon WorkLink has been deprecated and will be removed in the next major release
--- SKIP: TestAccWorkLinkFleet_identityProvider (0.00s)
=== RUN   TestAccWorkLinkFleet_disappears
    fleet_test.go:276: skipping test; Amazon WorkLink has been deprecated and will be removed in the next major release
--- SKIP: TestAccWorkLinkFleet_disappears (0.00s)
=== RUN   TestAccWorkLinkWebsiteCertificateAuthorityAssociation_basic
    website_certificate_authority_association_test.go:25: skipping test; Amazon WorkLink has been deprecated and will be removed in the next major release
--- SKIP: TestAccWorkLinkWebsiteCertificateAuthorityAssociation_basic (0.00s)
=== RUN   TestAccWorkLinkWebsiteCertificateAuthorityAssociation_displayName
    website_certificate_authority_association_test.go:57: skipping test; Amazon WorkLink has been deprecated and will be removed in the next major release
--- SKIP: TestAccWorkLinkWebsiteCertificateAuthorityAssociation_displayName (0.00s)
=== RUN   TestAccWorkLinkWebsiteCertificateAuthorityAssociation_disappears
    website_certificate_authority_association_test.go:94: skipping test; Amazon WorkLink has been deprecated and will be removed in the next major release
--- SKIP: TestAccWorkLinkWebsiteCertificateAuthorityAssociation_disappears (0.00s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/worklink   4.733s

@DanielRieske DanielRieske requested a review from a team as a code owner August 19, 2024 20:21
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

Copy link

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/worklink Issues and PRs that pertain to the worklink service. tags Pertains to resource tagging. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. needs-triage Waiting for first response or review from a maintainer. external-maintainer Contribution from a trusted external contributor. labels Aug 19, 2024
@DanielRieske DanielRieske changed the title Migrate Worklink resources to AWS SDK v2 Migrate WorkLink resources to AWS SDK v2 Aug 19, 2024
@ewbankkit ewbankkit added aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 20, 2024
@ewbankkit ewbankkit self-assigned this Aug 20, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 20, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccWorkLink' PKG=worklink ACCTEST_PARALLELISM=4
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/worklink/... -v -count 1 -parallel 4  -run=TestAccWorkLink -timeout 720m
=== RUN   TestAccWorkLinkFleet_basic
    fleet_test.go:27: skipping test; Amazon WorkLink has been deprecated and will be removed in the next major release
--- SKIP: TestAccWorkLinkFleet_basic (0.00s)
=== RUN   TestAccWorkLinkFleet_displayName
    fleet_test.go:58: skipping test; Amazon WorkLink has been deprecated and will be removed in the next major release
--- SKIP: TestAccWorkLinkFleet_displayName (0.00s)
=== RUN   TestAccWorkLinkFleet_optimizeForEndUserLocation
    fleet_test.go:94: skipping test; Amazon WorkLink has been deprecated and will be removed in the next major release
--- SKIP: TestAccWorkLinkFleet_optimizeForEndUserLocation (0.00s)
=== RUN   TestAccWorkLinkFleet_auditStreamARN
    fleet_test.go:130: skipping test; Amazon WorkLink has been deprecated and will be removed in the next major release
--- SKIP: TestAccWorkLinkFleet_auditStreamARN (0.00s)
=== RUN   TestAccWorkLinkFleet_network
    fleet_test.go:159: skipping test; Amazon WorkLink has been deprecated and will be removed in the next major release
--- SKIP: TestAccWorkLinkFleet_network (0.00s)
=== RUN   TestAccWorkLinkFleet_deviceCaCertificate
    fleet_test.go:205: skipping test; Amazon WorkLink has been deprecated and will be removed in the next major release
--- SKIP: TestAccWorkLinkFleet_deviceCaCertificate (0.00s)
=== RUN   TestAccWorkLinkFleet_identityProvider
    fleet_test.go:241: skipping test; Amazon WorkLink has been deprecated and will be removed in the next major release
--- SKIP: TestAccWorkLinkFleet_identityProvider (0.00s)
=== RUN   TestAccWorkLinkFleet_disappears
    fleet_test.go:276: skipping test; Amazon WorkLink has been deprecated and will be removed in the next major release
--- SKIP: TestAccWorkLinkFleet_disappears (0.00s)
=== RUN   TestAccWorkLinkWebsiteCertificateAuthorityAssociation_basic
    website_certificate_authority_association_test.go:25: skipping test; Amazon WorkLink has been deprecated and will be removed in the next major release
--- SKIP: TestAccWorkLinkWebsiteCertificateAuthorityAssociation_basic (0.00s)
=== RUN   TestAccWorkLinkWebsiteCertificateAuthorityAssociation_displayName
    website_certificate_authority_association_test.go:57: skipping test; Amazon WorkLink has been deprecated and will be removed in the next major release
--- SKIP: TestAccWorkLinkWebsiteCertificateAuthorityAssociation_displayName (0.00s)
=== RUN   TestAccWorkLinkWebsiteCertificateAuthorityAssociation_disappears
    website_certificate_authority_association_test.go:94: skipping test; Amazon WorkLink has been deprecated and will be removed in the next major release
--- SKIP: TestAccWorkLinkWebsiteCertificateAuthorityAssociation_disappears (0.00s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/worklink	6.097s

@ewbankkit
Copy link
Contributor

@DanielRieske Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit bac0be8 into hashicorp:main Aug 20, 2024
39 checks passed
@github-actions github-actions bot added this to the v5.64.0 milestone Aug 20, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 22, 2024
Copy link

This functionality has been released in v5.64.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. client-connections Pertains to the AWS Client and service connections. external-maintainer Contribution from a trusted external contributor. generators Relates to code generators. service/worklink Issues and PRs that pertain to the worklink service. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AWS SDK for Go Migration] WorkLink Service
2 participants