-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate WorkLink
resources to AWS SDK v2
#38928
Migrate WorkLink
resources to AWS SDK v2
#38928
Conversation
Community NoteVoting for Prioritization
For Submitters
|
Thank you for your contribution! 🚀 Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the Additional details:
|
Worklink
resources to AWS SDK v2WorkLink
resources to AWS SDK v2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccWorkLink' PKG=worklink ACCTEST_PARALLELISM=4
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/worklink/... -v -count 1 -parallel 4 -run=TestAccWorkLink -timeout 720m
=== RUN TestAccWorkLinkFleet_basic
fleet_test.go:27: skipping test; Amazon WorkLink has been deprecated and will be removed in the next major release
--- SKIP: TestAccWorkLinkFleet_basic (0.00s)
=== RUN TestAccWorkLinkFleet_displayName
fleet_test.go:58: skipping test; Amazon WorkLink has been deprecated and will be removed in the next major release
--- SKIP: TestAccWorkLinkFleet_displayName (0.00s)
=== RUN TestAccWorkLinkFleet_optimizeForEndUserLocation
fleet_test.go:94: skipping test; Amazon WorkLink has been deprecated and will be removed in the next major release
--- SKIP: TestAccWorkLinkFleet_optimizeForEndUserLocation (0.00s)
=== RUN TestAccWorkLinkFleet_auditStreamARN
fleet_test.go:130: skipping test; Amazon WorkLink has been deprecated and will be removed in the next major release
--- SKIP: TestAccWorkLinkFleet_auditStreamARN (0.00s)
=== RUN TestAccWorkLinkFleet_network
fleet_test.go:159: skipping test; Amazon WorkLink has been deprecated and will be removed in the next major release
--- SKIP: TestAccWorkLinkFleet_network (0.00s)
=== RUN TestAccWorkLinkFleet_deviceCaCertificate
fleet_test.go:205: skipping test; Amazon WorkLink has been deprecated and will be removed in the next major release
--- SKIP: TestAccWorkLinkFleet_deviceCaCertificate (0.00s)
=== RUN TestAccWorkLinkFleet_identityProvider
fleet_test.go:241: skipping test; Amazon WorkLink has been deprecated and will be removed in the next major release
--- SKIP: TestAccWorkLinkFleet_identityProvider (0.00s)
=== RUN TestAccWorkLinkFleet_disappears
fleet_test.go:276: skipping test; Amazon WorkLink has been deprecated and will be removed in the next major release
--- SKIP: TestAccWorkLinkFleet_disappears (0.00s)
=== RUN TestAccWorkLinkWebsiteCertificateAuthorityAssociation_basic
website_certificate_authority_association_test.go:25: skipping test; Amazon WorkLink has been deprecated and will be removed in the next major release
--- SKIP: TestAccWorkLinkWebsiteCertificateAuthorityAssociation_basic (0.00s)
=== RUN TestAccWorkLinkWebsiteCertificateAuthorityAssociation_displayName
website_certificate_authority_association_test.go:57: skipping test; Amazon WorkLink has been deprecated and will be removed in the next major release
--- SKIP: TestAccWorkLinkWebsiteCertificateAuthorityAssociation_displayName (0.00s)
=== RUN TestAccWorkLinkWebsiteCertificateAuthorityAssociation_disappears
website_certificate_authority_association_test.go:94: skipping test; Amazon WorkLink has been deprecated and will be removed in the next major release
--- SKIP: TestAccWorkLinkWebsiteCertificateAuthorityAssociation_disappears (0.00s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/worklink 6.097s
@DanielRieske Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.64.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This PR migrates the
WorkLink
resources to AWS SDKv2.Because this service has been deprecated all tests are skipped with an explanation.
Relations
Closes #36227
Relates #32976
References
Output from Acceptance Testing