Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ECS cluster name validation #38993

Merged
merged 5 commits into from
Sep 24, 2024

Conversation

gregops312
Copy link
Contributor

Previous regex was not complete and allowed for apply time failures

Description

Updating the ECS validateClusterName which contained and incomplete regex allowing for many cases with plans that wouldn't fail as expected

Relations

n/a

References

n/a

Output from Acceptance Testing

n/a

Previous regex was not complete and allowed for apply time failures
@gregops312 gregops312 requested a review from a team as a code owner August 22, 2024 14:12
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/ecs Issues and PRs that pertain to the ecs service. needs-triage Waiting for first response or review from a maintainer. labels Aug 22, 2024
@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 22, 2024
@gregops312
Copy link
Contributor Author

So I know there's a lot that goes on in this provider, and while this is pretty small, it like many other bugs can have consequences to deployments and availability of resources. I would think fixing bugs would be fairly high priority.

That said I've read the contributing docs and am still curious what is a normal timeframe for getting PRs reviewed?

@gdavison gdavison self-assigned this Sep 24, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 24, 2024
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this, @gregops312.

I've made a couple adjustments:

@gdavison gdavison merged commit 14302b4 into hashicorp:main Sep 24, 2024
18 checks passed
@github-actions github-actions bot added this to the v5.69.0 milestone Sep 24, 2024
@gregops312
Copy link
Contributor Author

Thanks for submitting this, @gregops312.

I've made a couple adjustments:

@gdavison Thank you very much. I'll keep those things in mind should I come across anything else in the future. I also see you added a changelog file. I didn't see that in the contributing docs, is that something I should do when making a change or is that something that is reserved for maintainers?

@gdavison
Copy link
Contributor

Yes, there is some documentation about adding a changelog entry (https://hashicorp.github.io/terraform-provider-aws/changelog-process/), but we have recently reorganized the contributor guide, so it may have been more buried when you created the PR originally.

@gregops312 gregops312 deleted the b-ecs-cluster-name-validation branch September 26, 2024 13:40
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 26, 2024
Copy link

This functionality has been released in v5.69.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/ecs Issues and PRs that pertain to the ecs service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants