r/aws_gamelift_game_server_group: fix crash reading group with nil ASG ARN

[jar-b]

Description

The read operation assumed a non-nil value for the AutoScalingGroupArn field in the Describe API response. This field may be nil if the scaling group cannot be created or is deleted out of band. Previously, when a nil value was returned, the provider attempted to split the result to retrieve the name of the auto scaling group from the full ARN, resulting in an index out of range panic when referencing the second item of the split function.

The read operation now ensures the AutoScalingGroupArn field is not nil and can be split into the appropriate number of parts before attempting to complete subsequent read operations on the auto scaling group. When nil, these read operations are skipped entirely.

Relations

Closes #29759

Output from Acceptance Testing

% make testacc PKG=gamelift TESTS=TestAccGameLiftGameServerGroup_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/gamelift/... -v -count 1 -parallel 20 -run='TestAccGameLiftGameServerGroup_'  -timeout 360m

--- PASS: TestAccGameLiftGameServerGroup_InstanceDefinition (211.70s)
--- PASS: TestAccGameLiftGameServerGroup_InstanceDefinition_WeightedCapacity (223.88s)
--- PASS: TestAccGameLiftGameServerGroup_LaunchTemplate_Id (246.89s)
--- PASS: TestAccGameLiftGameServerGroup_AutoScalingPolicy_EstimatedInstanceWarmup (248.01s)
--- PASS: TestAccGameLiftGameServerGroup_GameServerProtectionPolicy (274.38s)
--- PASS: TestAccGameLiftGameServerGroup_BalancingStrategy (277.45s)
--- PASS: TestAccGameLiftGameServerGroup_basic (279.24s)
--- PASS: TestAccGameLiftGameServerGroup_LaunchTemplate_Version (282.54s)
--- PASS: TestAccGameLiftGameServerGroup_roleARN (287.50s)
--- PASS: TestAccGameLiftGameServerGroup_LaunchTemplate_Name (293.63s)
--- PASS: TestAccGameLiftGameServerGroup_AutoScalingPolicy (333.94s)
--- PASS: TestAccGameLiftGameServerGroup_MinSize (362.83s)
--- PASS: TestAccGameLiftGameServerGroup_vpcSubnets (402.18s)
--- PASS: TestAccGameLiftGameServerGroup_GameServerGroupName (465.44s)
--- PASS: TestAccGameLiftGameServerGroup_MaxSize (676.82s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/gamelift   682.783s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[ewbankkit]

LGTM 🚀.

[github-actions]

This functionality has been released in v5.65.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.