Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

b/aws_lakeformation_permissions: properly remove data cells filters #39026

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

johnsonaj
Copy link
Contributor

Description

Resource did not properly delete when removed from config, for example, with a block comment.

Relations

References

Output from Acceptance Testing

% make testacc TESTARGS="-run=TestAccLakeFormation_serial/PermissionsBasic/dataCellsFilter" PKG=lakeformation

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/lakeformation/... -v -count 1 -parallel 20  -run=TestAccLakeFormation_serial/PermissionsBasic/dataCellsFilter -timeout 360m
--- PASS: TestAccLakeFormation_serial (17.81s)
    --- PASS: TestAccLakeFormation_serial/PermissionsBasic (17.81s)
        --- PASS: TestAccLakeFormation_serial/PermissionsBasic/dataCellsFilter (17.81s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lakeformation	23.899s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/lakeformation Issues and PRs that pertain to the lakeformation service. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Aug 24, 2024
@johnsonaj johnsonaj added the bug Addresses a defect in current functionality. label Aug 24, 2024
@johnsonaj johnsonaj marked this pull request as ready for review August 24, 2024 14:44
@johnsonaj johnsonaj requested a review from a team as a code owner August 24, 2024 14:44
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@johnsonaj johnsonaj merged commit d34fbbf into main Aug 26, 2024
43 checks passed
@johnsonaj johnsonaj deleted the b-revoke_data_cells_filter branch August 26, 2024 14:11
@github-actions github-actions bot added this to the v5.65.0 milestone Aug 26, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 29, 2024
Copy link

This functionality has been released in v5.65.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/lakeformation Issues and PRs that pertain to the lakeformation service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants