Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support new AWS Asia Pacific (Malaysia) Region ap-southeast-5 in data sources #39052

Merged
merged 7 commits into from
Aug 27, 2024
Merged

Support new AWS Asia Pacific (Malaysia) Region ap-southeast-5 in data sources #39052

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
dba6e9d
Add 'names.APSoutheast5RegionID'.
ewbankkit Aug 27, 2024
a02abb8
r/aws_s3_bucket: Add support for ap-southeast-5 AWS Region.
ewbankkit Aug 27, 2024
e47935d
d/aws_lb_hosted_zone_id: Add support for ap-southeast-5 AWS Region.
ewbankkit Aug 27, 2024
3d17d8f
d/aws_elb_hosted_zone_id: Add support for ap-southeast-5 AWS Region.
ewbankkit Aug 27, 2024
facb4ab
Add CHANGELOG entry.
ewbankkit Aug 27, 2024
6f6d78d
Correct CHANGELOG entry file name.
ewbankkit Aug 27, 2024
5499c6d
Add ap-southeast-5 to 'IsOptInRegion' and 'Regions'.
ewbankkit Aug 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .changelog/39052.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
```release-note:enhancement
data-source/aws_elb_hosted_zone_id: Add hosted zone ID for `ap-southeast-5` AWS Region
```

```release-note:enhancement
data-source/aws_lb_hosted_zone_id: Add hosted zone IDs for `ap-southeast-5` AWS Region
```

```release-note:enhancement
data-source/aws_s3_bucket: Add hosted zone ID for `ap-southeast-5` AWS Region
```
1 change: 1 addition & 0 deletions internal/service/elb/hosted_zone_id_data_source.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ var hostedZoneIDPerRegionMap = map[string]string{
names.APSoutheast2RegionID: "Z1GM3OXH4ZPM65",
names.APSoutheast3RegionID: "Z08888821HLRG5A9ZRTER",
names.APSoutheast4RegionID: "Z09517862IB2WZLPXG76F",
names.APSoutheast5RegionID: "Z06010284QMVVW7WO5J",
names.CACentral1RegionID: "ZQSVJUPU6J1EY",
names.CAWest1RegionID: "Z06473681N0SF6OS049SD",
names.CNNorth1RegionID: "Z1GDH35T77C1KE",
Expand Down
2 changes: 2 additions & 0 deletions internal/service/elbv2/hosted_zone_id_data_source.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ var hostedZoneIDPerRegionALBMap = map[string]string{
names.APSoutheast2RegionID: "Z1GM3OXH4ZPM65",
names.APSoutheast3RegionID: "Z08888821HLRG5A9ZRTER",
names.APSoutheast4RegionID: "Z09517862IB2WZLPXG76F",
names.APSoutheast5RegionID: "Z06010284QMVVW7WO5J",
names.CACentral1RegionID: "ZQSVJUPU6J1EY",
names.CAWest1RegionID: "Z06473681N0SF6OS049SD",
names.CNNorth1RegionID: "Z1GDH35T77C1KE",
Expand Down Expand Up @@ -67,6 +68,7 @@ var hostedZoneIDPerRegionNLBMap = map[string]string{
names.APSoutheast2RegionID: "ZCT6FZBF4DROD",
names.APSoutheast3RegionID: "Z01971771FYVNCOVWJU1G",
names.APSoutheast4RegionID: "Z01156963G8MIIL7X90IV",
names.APSoutheast5RegionID: "Z026317210H9ACVTRO6FB",
names.CACentral1RegionID: "Z2EPGBW3API2WT",
names.CAWest1RegionID: "Z02754302KBB00W2LKWZ9",
names.CNNorth1RegionID: "Z3QFB96KMJ7ED6",
Expand Down
1 change: 1 addition & 0 deletions internal/service/s3/hosted_zones.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ var hostedZoneIDsMap = map[string]string{
names.APSoutheast2RegionID: "Z1WCIGYICN2BYD",
names.APSoutheast3RegionID: "Z01846753K324LI26A3VV",
names.APSoutheast4RegionID: "Z0312387243XT5FE14WFO",
names.APSoutheast5RegionID: "Z08660063OXLMA7F1FJHU",
names.CACentral1RegionID: "Z1QDHH18159H29",
names.CAWest1RegionID: "Z03565811Z33SLEZTHOUL",
names.CNNorth1RegionID: "Z5CN8UMXT92WN",
Expand Down
4 changes: 3 additions & 1 deletion names/names.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,7 @@ const (
APSoutheast2RegionID = "ap-southeast-2" // Asia Pacific (Sydney).
APSoutheast3RegionID = "ap-southeast-3" // Asia Pacific (Jakarta).
APSoutheast4RegionID = "ap-southeast-4" // Asia Pacific (Melbourne).
APSoutheast5RegionID = "ap-southeast-5" // Asia Pacific (Malaysia).
CACentral1RegionID = "ca-central-1" // Canada (Central).
CAWest1RegionID = "ca-west-1" // Canada West (Calgary).
EUCentral1RegionID = "eu-central-1" // Europe (Frankfurt).
Expand Down Expand Up @@ -218,6 +219,7 @@ var allRegionIDs = []string{
APSoutheast2RegionID,
APSoutheast3RegionID,
APSoutheast4RegionID,
APSoutheast5RegionID,
CACentral1RegionID,
CAWest1RegionID,
EUCentral1RegionID,
Expand Down Expand Up @@ -318,7 +320,7 @@ func IsOptInRegion(region string) bool {
switch region {
case AFSouth1RegionID,
APEast1RegionID, APSouth2RegionID,
APSoutheast3RegionID, APSoutheast4RegionID,
APSoutheast3RegionID, APSoutheast4RegionID, APSoutheast5RegionID,
CAWest1RegionID,
EUCentral2RegionID,
EUSouth1RegionID, EUSouth2RegionID,
Expand Down
Loading