docs: db_instance_role_association: add replace_triggered_by to example config

[justinretzolk]

Description

I wrote quite a long comment on the referenced issue that gives more detail as to what's going on here. The tl;dr is:

• You can use a known, static string for aws_db_instance.example.identifier
• Since it's known, if aws_db_instance.example is recreated, Terraform has no reason to recreate the aws_db_instance_role_association, since the db_instance_identifier is unchanged
• On a second apply, the drift is detected/corrected

I didn't dig too far into when this became necessary, but I suspect it may have been when the id / identifier / resource_id changes happened ("Schema notes" in references).

I'm a bit on the fence on exactly how to document this. It's not required in all cases (using identifier_prefix or omitting both of those arguments negates the need), but it also might not be immediately clear that this is necessary, or exactly what is necessary (I got the "solution" wrong at first, for example). Adding the lifecycle block with a note to the example config seemed like a decent compromise.

Relations

Closes #38765

References

• Schema notes

Output from Acceptance Testing

n/a, docs

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[jar-b]

LGTM 🚀

[github-actions]

This functionality has been released in v5.65.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.