Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_lambda_event_source_mapping: add kms_key_arn support #39055

Merged

Conversation

trutled3
Copy link
Contributor

@trutled3 trutled3 commented Aug 27, 2024

Description

This adds the capability to set the KMSKeyArn for the CreateEventSourceMapping API for AWS Lambda.

Relations

Closes #38988

References

Output from Acceptance Testing

% make testacc TESTS=TestAccLambdaEventSourceMapping_KMSKeyARN PKG=lambda
TF_ACC=1 go test ./internal/service/lambda/... -v -count 1 -parallel 20 -run='TestAccLambdaEventSourceMapping_KMSKeyARN' -timeout 360m
=== RUN   TestAccLambdaEventSourceMapping_KMSKeyARN
=== PAUSE TestAccLambdaEventSourceMapping_KMSKeyARN
=== CONT  TestAccLambdaEventSourceMapping_KMSKeyARN
--- PASS: TestAccLambdaEventSourceMapping_KMSKeyARN (132.46s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lambda     137.209s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/lambda Issues and PRs that pertain to the lambda service. needs-triage Waiting for first response or review from a maintainer. labels Aug 27, 2024
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 27, 2024
@ewbankkit ewbankkit self-assigned this Aug 29, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 29, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccLambdaEventSourceMapping_Kinesis_basic\|TestAccLambdaEventSourceMapping_KMSKeyARN' PKG=lambda
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.0 test ./internal/service/lambda/... -v -count 1 -parallel 20  -run=TestAccLambdaEventSourceMapping_Kinesis_basic\|TestAccLambdaEventSourceMapping_KMSKeyARN -timeout 360m
=== RUN   TestAccLambdaEventSourceMapping_Kinesis_basic
=== PAUSE TestAccLambdaEventSourceMapping_Kinesis_basic
=== RUN   TestAccLambdaEventSourceMapping_KMSKeyARN
=== PAUSE TestAccLambdaEventSourceMapping_KMSKeyARN
=== CONT  TestAccLambdaEventSourceMapping_Kinesis_basic
=== CONT  TestAccLambdaEventSourceMapping_KMSKeyARN
--- PASS: TestAccLambdaEventSourceMapping_KMSKeyARN (51.87s)
--- PASS: TestAccLambdaEventSourceMapping_Kinesis_basic (62.98s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lambda	67.821s

@ewbankkit
Copy link
Contributor

@trutled3 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 96a591b into hashicorp:main Aug 29, 2024
40 checks passed
@github-actions github-actions bot added this to the v5.65.0 milestone Aug 29, 2024
@trutled3 trutled3 deleted the f-aws_lambda_event_source_mapping_kms_key_id branch August 29, 2024 17:02
Copy link

This functionality has been released in v5.65.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 29, 2024
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/lambda Issues and PRs that pertain to the lambda service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

r/aws_lambda_event_source_mapping: Support for encryption of filter criteria
3 participants