Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable quota name lookup for aws_servicequotas_service_quota #39244

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alexwilcox9
Copy link
Contributor

@alexwilcox9 alexwilcox9 commented Sep 10, 2024

Description

The data source aws_servicequotas_service_quota allows for either quota_name or quota_code to be used when looking up a quota. This PR aims to bring the same flexibility to the matching resource so users can avoid hard coding quota IDs

Relations

References

Output from Acceptance Testing

@alexwilcox9 alexwilcox9 requested a review from a team as a code owner September 10, 2024 14:22
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/servicequotas Issues and PRs that pertain to the servicequotas service. needs-triage Waiting for first response or review from a maintainer. labels Sep 10, 2024
@ewbankkit
Copy link
Contributor

It seems the more natural thing to do here would be to chain the aws_servicequotas_service_quota data source and resource together in configuration:

data "aws_servicequotas_service_quota" "example" {
  quota_name   = "VPCs per Region"
  service_code = "vpc"
}

resource "aws_servicequotas_service_quota" "example" {
  quota_code   = data.aws_servicequotas_service_quota.example.quota_code
  service_code = data.aws_servicequotas_service_quota.example.service_code
  value        = "42"
}

@alexwilcox9 Does this work for you?

@ewbankkit ewbankkit added waiting-response Maintainers are waiting on response from community or contributor. enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 12, 2024
@alexwilcox9
Copy link
Contributor Author

That does work but I thought it might be cleaner to make the data and resource work in the same way rather than having to use both.

@github-actions github-actions bot removed the waiting-response Maintainers are waiting on response from community or contributor. label Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/servicequotas Issues and PRs that pertain to the servicequotas service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants