d/aws_service: Migrate from AWS SDK for Go v1 #39455

ewbankkit · 2024-09-23T20:47:38Z

Description

Migrates the aws_service data source away from the AWS SDK for Go v1 endpoints package.

Relations

Cloes #36188.
Relates hashicorp/aws-sdk-go-base#1182.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccMetaServiceDataSource_' PKG=meta
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.7 test ./internal/service/meta/... -v -count 1 -parallel 20  -run=TestAccMetaServiceDataSource_ -timeout 360m
=== RUN   TestAccMetaServiceDataSource_basic
=== PAUSE TestAccMetaServiceDataSource_basic
=== RUN   TestAccMetaServiceDataSource_irregularServiceID
=== PAUSE TestAccMetaServiceDataSource_irregularServiceID
=== RUN   TestAccMetaServiceDataSource_irregularServiceIDUnsupported
=== PAUSE TestAccMetaServiceDataSource_irregularServiceIDUnsupported
=== RUN   TestAccMetaServiceDataSource_byReverseDNSName
=== PAUSE TestAccMetaServiceDataSource_byReverseDNSName
=== RUN   TestAccMetaServiceDataSource_byDNSName
=== PAUSE TestAccMetaServiceDataSource_byDNSName
=== RUN   TestAccMetaServiceDataSource_byParts
=== PAUSE TestAccMetaServiceDataSource_byParts
=== RUN   TestAccMetaServiceDataSource_unsupported
=== PAUSE TestAccMetaServiceDataSource_unsupported
=== CONT  TestAccMetaServiceDataSource_basic
=== CONT  TestAccMetaServiceDataSource_byDNSName
=== CONT  TestAccMetaServiceDataSource_byParts
=== CONT  TestAccMetaServiceDataSource_irregularServiceIDUnsupported
=== CONT  TestAccMetaServiceDataSource_irregularServiceID
=== CONT  TestAccMetaServiceDataSource_unsupported
=== CONT  TestAccMetaServiceDataSource_byReverseDNSName
--- PASS: TestAccMetaServiceDataSource_irregularServiceIDUnsupported (9.22s)
--- PASS: TestAccMetaServiceDataSource_basic (9.60s)
--- PASS: TestAccMetaServiceDataSource_irregularServiceID (9.74s)
--- PASS: TestAccMetaServiceDataSource_byParts (9.74s)
--- PASS: TestAccMetaServiceDataSource_unsupported (9.74s)
--- PASS: TestAccMetaServiceDataSource_byDNSName (9.74s)
--- PASS: TestAccMetaServiceDataSource_byReverseDNSName (9.74s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/meta	15.350s

github-actions · 2024-09-23T20:47:54Z

Community Note

Voting for Prioritization

Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
Please see our prioritization guide for information on how we prioritize.
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

jar-b

LGTM 🎉

% make testacc PKG=meta TESTS=TestAccMetaServiceDataSource_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.7 test ./internal/service/meta/... -v -count 1 -parallel 20 -run='TestAccMetaServiceDataSource_'  -timeout 360m
go: downloading github.com/hashicorp/aws-sdk-go-base/v2 v2.0.0-beta.58
go: downloading github.com/hashicorp/aws-sdk-go-base/v2/awsv1shim/v2 v2.0.0-beta.59
=== RUN   TestAccMetaServiceDataSource_basic
=== PAUSE TestAccMetaServiceDataSource_basic
=== RUN   TestAccMetaServiceDataSource_irregularServiceID
=== PAUSE TestAccMetaServiceDataSource_irregularServiceID
=== RUN   TestAccMetaServiceDataSource_irregularServiceIDUnsupported
=== PAUSE TestAccMetaServiceDataSource_irregularServiceIDUnsupported
=== RUN   TestAccMetaServiceDataSource_byReverseDNSName
=== PAUSE TestAccMetaServiceDataSource_byReverseDNSName
=== RUN   TestAccMetaServiceDataSource_byDNSName
=== PAUSE TestAccMetaServiceDataSource_byDNSName
=== RUN   TestAccMetaServiceDataSource_byParts
=== PAUSE TestAccMetaServiceDataSource_byParts
=== RUN   TestAccMetaServiceDataSource_unsupported
=== PAUSE TestAccMetaServiceDataSource_unsupported
=== CONT  TestAccMetaServiceDataSource_basic
=== CONT  TestAccMetaServiceDataSource_byDNSName
=== CONT  TestAccMetaServiceDataSource_byReverseDNSName
=== CONT  TestAccMetaServiceDataSource_irregularServiceID
=== CONT  TestAccMetaServiceDataSource_unsupported
=== CONT  TestAccMetaServiceDataSource_byParts
=== CONT  TestAccMetaServiceDataSource_irregularServiceIDUnsupported
--- PASS: TestAccMetaServiceDataSource_basic (12.56s)
--- PASS: TestAccMetaServiceDataSource_byParts (13.40s)
--- PASS: TestAccMetaServiceDataSource_byDNSName (13.47s)
--- PASS: TestAccMetaServiceDataSource_byReverseDNSName (13.53s)
--- PASS: TestAccMetaServiceDataSource_irregularServiceIDUnsupported (13.58s)
--- PASS: TestAccMetaServiceDataSource_irregularServiceID (13.61s)
--- PASS: TestAccMetaServiceDataSource_unsupported (13.61s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/meta       18.956s

…support.

…eckCostAllocationTagPayerAccount'.

…stCategoryPayerAccount'.

…ccPreCheck'.

ewbankkit · 2024-09-24T15:07:49Z

% make sane     
make: Sane Check (48 tests of Top 30 resources)
make: Like 'sanity' except full output and stops soon after 1st error
make: NOTE: NOT an exhaustive set of tests! Finds big problems only.
=== RUN   TestAccIAMInstanceProfile_tags
=== PAUSE TestAccIAMInstanceProfile_tags
=== RUN   TestAccIAMInstanceProfile_tags_null
=== PAUSE TestAccIAMInstanceProfile_tags_null
=== RUN   TestAccIAMInstanceProfile_tags_EmptyMap
=== PAUSE TestAccIAMInstanceProfile_tags_EmptyMap
=== RUN   TestAccIAMInstanceProfile_tags_AddOnUpdate
=== PAUSE TestAccIAMInstanceProfile_tags_AddOnUpdate
=== RUN   TestAccIAMInstanceProfile_tags_EmptyTag_OnCreate
=== PAUSE TestAccIAMInstanceProfile_tags_EmptyTag_OnCreate
=== RUN   TestAccIAMInstanceProfile_tags_EmptyTag_OnUpdate_Add
=== PAUSE TestAccIAMInstanceProfile_tags_EmptyTag_OnUpdate_Add
=== RUN   TestAccIAMInstanceProfile_tags_EmptyTag_OnUpdate_Replace
=== PAUSE TestAccIAMInstanceProfile_tags_EmptyTag_OnUpdate_Replace
=== RUN   TestAccIAMInstanceProfile_tags_DefaultTags_providerOnly
=== PAUSE TestAccIAMInstanceProfile_tags_DefaultTags_providerOnly
=== RUN   TestAccIAMInstanceProfile_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccIAMInstanceProfile_tags_DefaultTags_nonOverlapping
=== RUN   TestAccIAMInstanceProfile_tags_DefaultTags_overlapping
=== PAUSE TestAccIAMInstanceProfile_tags_DefaultTags_overlapping
=== RUN   TestAccIAMInstanceProfile_tags_DefaultTags_updateToProviderOnly
=== PAUSE TestAccIAMInstanceProfile_tags_DefaultTags_updateToProviderOnly
=== RUN   TestAccIAMInstanceProfile_tags_DefaultTags_updateToResourceOnly
=== PAUSE TestAccIAMInstanceProfile_tags_DefaultTags_updateToResourceOnly
=== RUN   TestAccIAMInstanceProfile_tags_DefaultTags_emptyResourceTag
=== PAUSE TestAccIAMInstanceProfile_tags_DefaultTags_emptyResourceTag
=== RUN   TestAccIAMInstanceProfile_tags_DefaultTags_emptyProviderOnlyTag
=== PAUSE TestAccIAMInstanceProfile_tags_DefaultTags_emptyProviderOnlyTag
=== RUN   TestAccIAMInstanceProfile_tags_DefaultTags_nullOverlappingResourceTag
=== PAUSE TestAccIAMInstanceProfile_tags_DefaultTags_nullOverlappingResourceTag
=== RUN   TestAccIAMInstanceProfile_tags_DefaultTags_nullNonOverlappingResourceTag
=== PAUSE TestAccIAMInstanceProfile_tags_DefaultTags_nullNonOverlappingResourceTag
=== RUN   TestAccIAMInstanceProfile_tags_ComputedTag_OnCreate
=== PAUSE TestAccIAMInstanceProfile_tags_ComputedTag_OnCreate
=== RUN   TestAccIAMInstanceProfile_tags_ComputedTag_OnUpdate_Add
=== PAUSE TestAccIAMInstanceProfile_tags_ComputedTag_OnUpdate_Add
=== RUN   TestAccIAMInstanceProfile_tags_ComputedTag_OnUpdate_Replace
=== PAUSE TestAccIAMInstanceProfile_tags_ComputedTag_OnUpdate_Replace
=== RUN   TestAccIAMInstanceProfile_basic
=== PAUSE TestAccIAMInstanceProfile_basic
=== RUN   TestAccIAMPolicyDocumentDataSource_basic
=== PAUSE TestAccIAMPolicyDocumentDataSource_basic
=== RUN   TestAccIAMPolicyDocumentDataSource_sourceConflicting
=== PAUSE TestAccIAMPolicyDocumentDataSource_sourceConflicting
=== RUN   TestAccIAMPolicy_tags
=== PAUSE TestAccIAMPolicy_tags
=== RUN   TestAccIAMPolicy_tags_null
=== PAUSE TestAccIAMPolicy_tags_null
=== RUN   TestAccIAMPolicy_tags_EmptyMap
=== PAUSE TestAccIAMPolicy_tags_EmptyMap
=== RUN   TestAccIAMPolicy_tags_AddOnUpdate
=== PAUSE TestAccIAMPolicy_tags_AddOnUpdate
=== RUN   TestAccIAMPolicy_tags_EmptyTag_OnCreate
=== PAUSE TestAccIAMPolicy_tags_EmptyTag_OnCreate
=== RUN   TestAccIAMPolicy_tags_EmptyTag_OnUpdate_Add
=== PAUSE TestAccIAMPolicy_tags_EmptyTag_OnUpdate_Add
=== RUN   TestAccIAMPolicy_tags_EmptyTag_OnUpdate_Replace
=== PAUSE TestAccIAMPolicy_tags_EmptyTag_OnUpdate_Replace
=== RUN   TestAccIAMPolicy_tags_DefaultTags_providerOnly
=== PAUSE TestAccIAMPolicy_tags_DefaultTags_providerOnly
=== RUN   TestAccIAMPolicy_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccIAMPolicy_tags_DefaultTags_nonOverlapping
=== RUN   TestAccIAMPolicy_tags_DefaultTags_overlapping
=== PAUSE TestAccIAMPolicy_tags_DefaultTags_overlapping
=== RUN   TestAccIAMPolicy_tags_DefaultTags_updateToProviderOnly
=== PAUSE TestAccIAMPolicy_tags_DefaultTags_updateToProviderOnly
=== RUN   TestAccIAMPolicy_tags_DefaultTags_updateToResourceOnly
=== PAUSE TestAccIAMPolicy_tags_DefaultTags_updateToResourceOnly
=== RUN   TestAccIAMPolicy_tags_DefaultTags_emptyResourceTag
=== PAUSE TestAccIAMPolicy_tags_DefaultTags_emptyResourceTag
=== RUN   TestAccIAMPolicy_tags_DefaultTags_emptyProviderOnlyTag
=== PAUSE TestAccIAMPolicy_tags_DefaultTags_emptyProviderOnlyTag
=== RUN   TestAccIAMPolicy_tags_DefaultTags_nullOverlappingResourceTag
=== PAUSE TestAccIAMPolicy_tags_DefaultTags_nullOverlappingResourceTag
=== RUN   TestAccIAMPolicy_tags_DefaultTags_nullNonOverlappingResourceTag
=== PAUSE TestAccIAMPolicy_tags_DefaultTags_nullNonOverlappingResourceTag
=== RUN   TestAccIAMPolicy_tags_ComputedTag_OnCreate
=== PAUSE TestAccIAMPolicy_tags_ComputedTag_OnCreate
=== RUN   TestAccIAMPolicy_tags_ComputedTag_OnUpdate_Add
=== PAUSE TestAccIAMPolicy_tags_ComputedTag_OnUpdate_Add
=== RUN   TestAccIAMPolicy_tags_ComputedTag_OnUpdate_Replace
=== PAUSE TestAccIAMPolicy_tags_ComputedTag_OnUpdate_Replace
=== RUN   TestAccIAMPolicy_basic
=== PAUSE TestAccIAMPolicy_basic
=== RUN   TestAccIAMPolicy_policy
=== PAUSE TestAccIAMPolicy_policy
=== RUN   TestAccIAMPolicy_policyDuplicateKeys
=== PAUSE TestAccIAMPolicy_policyDuplicateKeys
=== RUN   TestAccIAMRolePolicyAttachment_basic
=== PAUSE TestAccIAMRolePolicyAttachment_basic
=== RUN   TestAccIAMRolePolicyAttachment_disappears
=== PAUSE TestAccIAMRolePolicyAttachment_disappears
=== RUN   TestAccIAMRolePolicyAttachment_Disappears_role
=== PAUSE TestAccIAMRolePolicyAttachment_Disappears_role
=== RUN   TestAccIAMRolePolicy_basic
=== PAUSE TestAccIAMRolePolicy_basic
=== RUN   TestAccIAMRolePolicy_unknownsInPolicy
=== PAUSE TestAccIAMRolePolicy_unknownsInPolicy
=== RUN   TestAccIAMRole_basic
=== PAUSE TestAccIAMRole_basic
=== RUN   TestAccIAMRole_namePrefix
=== PAUSE TestAccIAMRole_namePrefix
=== RUN   TestAccIAMRole_disappears
=== PAUSE TestAccIAMRole_disappears
=== RUN   TestAccIAMRole_InlinePolicy_basic
=== PAUSE TestAccIAMRole_InlinePolicy_basic
=== CONT  TestAccIAMInstanceProfile_tags
=== CONT  TestAccIAMPolicy_tags_EmptyTag_OnUpdate_Add
=== CONT  TestAccIAMPolicy_tags_ComputedTag_OnUpdate_Replace
=== CONT  TestAccIAMPolicy_tags_DefaultTags_emptyResourceTag
=== CONT  TestAccIAMRolePolicy_basic
=== CONT  TestAccIAMPolicy_tags_DefaultTags_overlapping
=== CONT  TestAccIAMRole_namePrefix
=== CONT  TestAccIAMPolicy_tags_DefaultTags_nullOverlappingResourceTag
=== CONT  TestAccIAMPolicy_tags_DefaultTags_updateToProviderOnly
=== CONT  TestAccIAMPolicy_tags_DefaultTags_updateToResourceOnly
=== CONT  TestAccIAMRole_basic
=== CONT  TestAccIAMPolicy_tags_ComputedTag_OnUpdate_Add
=== CONT  TestAccIAMPolicy_tags_DefaultTags_nullNonOverlappingResourceTag
=== CONT  TestAccIAMPolicy_tags_ComputedTag_OnCreate
=== CONT  TestAccIAMPolicy_tags_DefaultTags_providerOnly
=== CONT  TestAccIAMPolicy_tags_DefaultTags_nonOverlapping
=== CONT  TestAccIAMPolicy_tags_EmptyTag_OnUpdate_Replace
=== CONT  TestAccIAMRole_disappears
=== CONT  TestAccIAMRolePolicy_unknownsInPolicy
=== CONT  TestAccIAMRole_InlinePolicy_basic
--- PASS: TestAccIAMRole_disappears (22.86s)
=== CONT  TestAccIAMInstanceProfile_tags_DefaultTags_nullOverlappingResourceTag
--- PASS: TestAccIAMRole_namePrefix (28.54s)
=== CONT  TestAccIAMPolicy_tags_EmptyTag_OnCreate
--- PASS: TestAccIAMRolePolicy_unknownsInPolicy (29.18s)
=== CONT  TestAccIAMPolicy_tags_AddOnUpdate
--- PASS: TestAccIAMRole_basic (29.57s)
=== CONT  TestAccIAMPolicy_tags_EmptyMap
--- PASS: TestAccIAMRolePolicy_basic (29.71s)
=== CONT  TestAccIAMPolicy_tags_null
--- PASS: TestAccIAMPolicy_tags_DefaultTags_emptyResourceTag (35.86s)
=== CONT  TestAccIAMPolicy_tags
--- PASS: TestAccIAMPolicy_tags_DefaultTags_nullOverlappingResourceTag (36.06s)
=== CONT  TestAccIAMPolicyDocumentDataSource_sourceConflicting
--- PASS: TestAccIAMPolicy_tags_DefaultTags_nullNonOverlappingResourceTag (36.17s)
=== CONT  TestAccIAMPolicyDocumentDataSource_basic
--- PASS: TestAccIAMPolicy_tags_ComputedTag_OnCreate (36.31s)
=== CONT  TestAccIAMInstanceProfile_basic
--- PASS: TestAccIAMPolicy_tags_DefaultTags_updateToResourceOnly (52.88s)
=== CONT  TestAccIAMInstanceProfile_tags_ComputedTag_OnUpdate_Replace
--- PASS: TestAccIAMPolicy_tags_EmptyTag_OnUpdate_Replace (54.84s)
=== CONT  TestAccIAMInstanceProfile_tags_ComputedTag_OnUpdate_Add
--- PASS: TestAccIAMPolicy_tags_DefaultTags_updateToProviderOnly (55.16s)
=== CONT  TestAccIAMInstanceProfile_tags_ComputedTag_OnCreate
--- PASS: TestAccIAMPolicyDocumentDataSource_basic (19.28s)
=== CONT  TestAccIAMInstanceProfile_tags_DefaultTags_nullNonOverlappingResourceTag
--- PASS: TestAccIAMPolicyDocumentDataSource_sourceConflicting (19.41s)
=== CONT  TestAccIAMInstanceProfile_tags_DefaultTags_providerOnly
--- PASS: TestAccIAMInstanceProfile_tags_DefaultTags_nullOverlappingResourceTag (34.65s)
=== CONT  TestAccIAMRolePolicyAttachment_basic
--- PASS: TestAccIAMPolicy_tags_ComputedTag_OnUpdate_Replace (57.53s)
=== CONT  TestAccIAMInstanceProfile_tags_DefaultTags_emptyProviderOnlyTag
--- PASS: TestAccIAMPolicy_tags_ComputedTag_OnUpdate_Add (60.54s)
=== CONT  TestAccIAMRolePolicyAttachment_Disappears_role
--- PASS: TestAccIAMRole_InlinePolicy_basic (64.55s)
=== CONT  TestAccIAMInstanceProfile_tags_DefaultTags_emptyResourceTag
--- PASS: TestAccIAMInstanceProfile_basic (28.94s)
=== CONT  TestAccIAMInstanceProfile_tags_DefaultTags_updateToResourceOnly
--- PASS: TestAccIAMPolicy_tags_EmptyMap (41.03s)
=== CONT  TestAccIAMInstanceProfile_tags_DefaultTags_updateToProviderOnly
--- PASS: TestAccIAMPolicy_tags_null (40.97s)
=== CONT  TestAccIAMInstanceProfile_tags_DefaultTags_overlapping
--- PASS: TestAccIAMPolicy_tags_EmptyTag_OnUpdate_Add (81.49s)
=== CONT  TestAccIAMInstanceProfile_tags_DefaultTags_nonOverlapping
--- PASS: TestAccIAMPolicy_tags_AddOnUpdate (52.37s)
=== CONT  TestAccIAMPolicy_tags_DefaultTags_emptyProviderOnlyTag
--- PASS: TestAccIAMRolePolicyAttachment_Disappears_role (24.40s)
=== CONT  TestAccIAMInstanceProfile_tags_EmptyTag_OnCreate
--- PASS: TestAccIAMPolicy_tags_EmptyTag_OnCreate (58.62s)
=== CONT  TestAccIAMInstanceProfile_tags_EmptyTag_OnUpdate_Replace
--- PASS: TestAccIAMInstanceProfile_tags_DefaultTags_nullNonOverlappingResourceTag (33.87s)
=== CONT  TestAccIAMInstanceProfile_tags_EmptyTag_OnUpdate_Add
--- PASS: TestAccIAMPolicy_tags_DefaultTags_nonOverlapping (89.49s)
=== CONT  TestAccIAMPolicy_policy
--- PASS: TestAccIAMInstanceProfile_tags_ComputedTag_OnCreate (35.81s)
=== CONT  TestAccIAMPolicy_policyDuplicateKeys
--- PASS: TestAccIAMPolicy_tags_DefaultTags_overlapping (92.15s)
=== CONT  TestAccIAMPolicy_basic
--- PASS: TestAccIAMPolicy_policyDuplicateKeys (2.37s)
=== CONT  TestAccIAMInstanceProfile_tags_EmptyMap
--- PASS: TestAccIAMInstanceProfile_tags_DefaultTags_emptyProviderOnlyTag (36.01s)
=== CONT  TestAccIAMInstanceProfile_tags_AddOnUpdate
--- PASS: TestAccIAMInstanceProfile_tags_DefaultTags_emptyResourceTag (33.34s)
=== CONT  TestAccIAMInstanceProfile_tags_null
--- PASS: TestAccIAMRolePolicyAttachment_basic (45.53s)
=== CONT  TestAccIAMRolePolicyAttachment_disappears
--- PASS: TestAccIAMInstanceProfile_tags_ComputedTag_OnUpdate_Replace (56.82s)
--- PASS: TestAccIAMInstanceProfile_tags_ComputedTag_OnUpdate_Add (56.54s)
--- PASS: TestAccIAMInstanceProfile_tags (113.74s)
--- PASS: TestAccIAMPolicy_tags_DefaultTags_emptyProviderOnlyTag (32.19s)
--- PASS: TestAccIAMInstanceProfile_tags_DefaultTags_updateToResourceOnly (51.97s)
--- PASS: TestAccIAMPolicy_tags_DefaultTags_providerOnly (117.73s)
--- PASS: TestAccIAMPolicy_basic (26.14s)
--- PASS: TestAccIAMRolePolicyAttachment_disappears (19.76s)
--- PASS: TestAccIAMInstanceProfile_tags_DefaultTags_updateToProviderOnly (52.47s)
--- PASS: TestAccIAMInstanceProfile_tags_EmptyMap (33.61s)
--- PASS: TestAccIAMPolicy_policy (38.71s)
--- PASS: TestAccIAMInstanceProfile_tags_null (31.45s)
--- PASS: TestAccIAMInstanceProfile_tags_EmptyTag_OnUpdate_Replace (43.20s)
--- PASS: TestAccIAMInstanceProfile_tags_EmptyTag_OnCreate (46.40s)
--- PASS: TestAccIAMPolicy_tags (97.02s)
--- PASS: TestAccIAMInstanceProfile_tags_AddOnUpdate (39.53s)
--- PASS: TestAccIAMInstanceProfile_tags_DefaultTags_overlapping (69.29s)
--- PASS: TestAccIAMInstanceProfile_tags_EmptyTag_OnUpdate_Add (53.59s)
--- PASS: TestAccIAMInstanceProfile_tags_DefaultTags_nonOverlapping (62.24s)
--- PASS: TestAccIAMInstanceProfile_tags_DefaultTags_providerOnly (90.36s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/iam	151.522s
=== RUN   TestAccLogsGroup_basic
=== PAUSE TestAccLogsGroup_basic
=== RUN   TestAccLogsGroup_multiple
=== PAUSE TestAccLogsGroup_multiple
=== CONT  TestAccLogsGroup_basic
=== CONT  TestAccLogsGroup_multiple
--- PASS: TestAccLogsGroup_multiple (12.03s)
--- PASS: TestAccLogsGroup_basic (16.14s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/logs	21.903s
=== RUN   TestAccVPCDataSource_basic
=== PAUSE TestAccVPCDataSource_basic
=== RUN   TestAccVPCRouteTableAssociation_Subnet_basic
=== PAUSE TestAccVPCRouteTableAssociation_Subnet_basic
=== RUN   TestAccVPCRouteTable_basic
=== PAUSE TestAccVPCRouteTable_basic
=== RUN   TestAccVPCSecurityGroupRule_race
=== PAUSE TestAccVPCSecurityGroupRule_race
=== RUN   TestAccVPCSecurityGroupRule_protocolChange
=== PAUSE TestAccVPCSecurityGroupRule_protocolChange
=== RUN   TestAccVPCSecurityGroup_basic
=== PAUSE TestAccVPCSecurityGroup_basic
=== RUN   TestAccVPCSecurityGroup_egressMode
=== PAUSE TestAccVPCSecurityGroup_egressMode
=== RUN   TestAccVPCSecurityGroup_vpcAllEgress
=== PAUSE TestAccVPCSecurityGroup_vpcAllEgress
=== RUN   TestAccVPCSubnet_basic
=== PAUSE TestAccVPCSubnet_basic
=== RUN   TestAccVPC_tenancy
=== PAUSE TestAccVPC_tenancy
=== CONT  TestAccVPCDataSource_basic
=== CONT  TestAccVPCSecurityGroup_basic
=== CONT  TestAccVPCSecurityGroupRule_race
=== CONT  TestAccVPCRouteTable_basic
=== CONT  TestAccVPCSubnet_basic
=== CONT  TestAccVPCRouteTableAssociation_Subnet_basic
=== CONT  TestAccVPCSecurityGroup_vpcAllEgress
=== CONT  TestAccVPC_tenancy
=== CONT  TestAccVPCSecurityGroup_egressMode
=== CONT  TestAccVPCSecurityGroupRule_protocolChange
--- PASS: TestAccVPCSubnet_basic (23.26s)
--- PASS: TestAccVPCRouteTable_basic (23.78s)
--- PASS: TestAccVPCSecurityGroup_basic (24.74s)
--- PASS: TestAccVPCSecurityGroup_vpcAllEgress (26.00s)
--- PASS: TestAccVPCRouteTableAssociation_Subnet_basic (27.08s)
--- PASS: TestAccVPCDataSource_basic (30.42s)
--- PASS: TestAccVPCSecurityGroup_egressMode (45.85s)
--- PASS: TestAccVPC_tenancy (46.32s)
--- PASS: TestAccVPCSecurityGroupRule_protocolChange (53.27s)
--- PASS: TestAccVPCSecurityGroupRule_race (156.98s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	162.966s
=== RUN   TestAccECSService_basic
=== PAUSE TestAccECSService_basic
=== RUN   TestAccECSService_basicImport
=== PAUSE TestAccECSService_basicImport
=== RUN   TestAccECSTaskDefinition_basic
=== PAUSE TestAccECSTaskDefinition_basic
=== CONT  TestAccECSService_basic
=== CONT  TestAccECSTaskDefinition_basic
=== CONT  TestAccECSService_basicImport
--- PASS: TestAccECSTaskDefinition_basic (23.84s)
--- PASS: TestAccECSService_basic (68.63s)
--- PASS: TestAccECSService_basicImport (185.96s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecs	200.067s
=== RUN   TestAccELBV2TargetGroup_basic
=== PAUSE TestAccELBV2TargetGroup_basic
=== CONT  TestAccELBV2TargetGroup_basic
--- PASS: TestAccELBV2TargetGroup_basic (21.71s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elbv2	31.764s
=== RUN   TestAccKMSKey_basic
=== PAUSE TestAccKMSKey_basic
=== CONT  TestAccKMSKey_basic
--- PASS: TestAccKMSKey_basic (24.19s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kms	42.444s
=== RUN   TestAccLambdaFunction_basic
=== PAUSE TestAccLambdaFunction_basic
=== RUN   TestAccLambdaPermission_basic
=== PAUSE TestAccLambdaPermission_basic
=== CONT  TestAccLambdaFunction_basic
=== CONT  TestAccLambdaPermission_basic
--- PASS: TestAccLambdaPermission_basic (30.99s)
--- PASS: TestAccLambdaFunction_basic (41.21s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lambda	47.059s
=== RUN   TestAccMetaPartitionDataSource_basic
=== PAUSE TestAccMetaPartitionDataSource_basic
=== RUN   TestAccMetaRegionDataSource_basic
=== PAUSE TestAccMetaRegionDataSource_basic
=== RUN   TestAccMetaRegionDataSource_endpoint
=== PAUSE TestAccMetaRegionDataSource_endpoint
=== RUN   TestAccMetaRegionDataSource_endpointAndName
=== PAUSE TestAccMetaRegionDataSource_endpointAndName
=== CONT  TestAccMetaPartitionDataSource_basic
=== CONT  TestAccMetaRegionDataSource_endpoint
=== CONT  TestAccMetaRegionDataSource_basic
=== CONT  TestAccMetaRegionDataSource_endpointAndName
--- PASS: TestAccMetaRegionDataSource_basic (10.61s)
--- PASS: TestAccMetaPartitionDataSource_basic (10.68s)
--- PASS: TestAccMetaRegionDataSource_endpoint (10.73s)
--- PASS: TestAccMetaRegionDataSource_endpointAndName (13.25s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/meta	22.758s
=== RUN   TestAccRoute53Record_basic
=== PAUSE TestAccRoute53Record_basic
=== RUN   TestAccRoute53Record_Latency_basic
=== PAUSE TestAccRoute53Record_Latency_basic
=== RUN   TestAccRoute53ZoneDataSource_name
=== PAUSE TestAccRoute53ZoneDataSource_name
=== RUN   TestAccRoute53ZoneDataSource_name_idEmptyString
=== PAUSE TestAccRoute53ZoneDataSource_name_idEmptyString
=== CONT  TestAccRoute53Record_basic
=== CONT  TestAccRoute53ZoneDataSource_name
=== CONT  TestAccRoute53ZoneDataSource_name_idEmptyString
=== CONT  TestAccRoute53Record_Latency_basic
--- PASS: TestAccRoute53ZoneDataSource_name (94.92s)
--- PASS: TestAccRoute53ZoneDataSource_name_idEmptyString (104.47s)
--- PASS: TestAccRoute53Record_basic (167.12s)
--- PASS: TestAccRoute53Record_Latency_basic (189.23s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53	202.888s
=== RUN   TestAccS3BucketACL_updateACL
=== PAUSE TestAccS3BucketACL_updateACL
=== RUN   TestAccS3BucketPolicy_basic
=== PAUSE TestAccS3BucketPolicy_basic
=== RUN   TestAccS3BucketPublicAccessBlock_basic
=== PAUSE TestAccS3BucketPublicAccessBlock_basic
=== RUN   TestAccS3Bucket_Basic_basic
=== PAUSE TestAccS3Bucket_Basic_basic
=== RUN   TestAccS3Bucket_Security_corsUpdate
=== PAUSE TestAccS3Bucket_Security_corsUpdate
=== CONT  TestAccS3BucketACL_updateACL
=== CONT  TestAccS3Bucket_Basic_basic
=== CONT  TestAccS3Bucket_Security_corsUpdate
=== CONT  TestAccS3BucketPublicAccessBlock_basic
=== CONT  TestAccS3BucketPolicy_basic
--- PASS: TestAccS3BucketPublicAccessBlock_basic (20.88s)
--- PASS: TestAccS3BucketPolicy_basic (20.92s)
--- PASS: TestAccS3Bucket_Basic_basic (21.16s)
--- PASS: TestAccS3BucketACL_updateACL (33.03s)
--- PASS: TestAccS3Bucket_Security_corsUpdate (35.15s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	51.747s
=== RUN   TestAccSecretsManagerSecret_basic
=== PAUSE TestAccSecretsManagerSecret_basic
=== RUN   TestAccSecretsManagerSecret_basicReplica
=== PAUSE TestAccSecretsManagerSecret_basicReplica
=== CONT  TestAccSecretsManagerSecret_basic
=== CONT  TestAccSecretsManagerSecret_basicReplica
--- PASS: TestAccSecretsManagerSecret_basic (14.93s)
--- PASS: TestAccSecretsManagerSecret_basicReplica (17.46s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/secretsmanager	42.247s
=== RUN   TestAccSTSCallerIdentityDataSource_basic
=== PAUSE TestAccSTSCallerIdentityDataSource_basic
=== CONT  TestAccSTSCallerIdentityDataSource_basic
--- PASS: TestAccSTSCallerIdentityDataSource_basic (9.00s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sts	29.695s

github-actions · 2024-09-26T23:16:10Z

This functionality has been released in v5.69.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2024-10-28T02:25:22Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

ewbankkit requested a review from a team as a code owner September 23, 2024 20:47

github-actions bot added documentation Introduces or discusses updates to documentation. service/meta Issues and PRs that pertain to the meta service. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Sep 23, 2024

jar-b approved these changes Sep 23, 2024

View reviewed changes

ewbankkit added 24 commits September 24, 2024 09:25

go get github.com/aws/aws-sdk-go-v2/feature/s3/manager.

7ce80e1

go get github.com/aws/aws-sdk-go-v2/service/accessanalyzer.

843c437

go get github.com/aws/aws-sdk-go-v2/service/account.

06b844a

go get github.com/aws/aws-sdk-go-v2/service/acm.

1be3b8e

go get github.com/aws/aws-sdk-go-v2/service/acmpca.

eb073f2

go get github.com/aws/aws-sdk-go-v2/service/amp.

02ae4c3

go get github.com/aws/aws-sdk-go-v2/service/amplify.

5276225

go get github.com/aws/aws-sdk-go-v2/service/apigateway.

227842b

go get github.com/aws/aws-sdk-go-v2/service/apigatewayv2.

f490648

go get github.com/aws/aws-sdk-go-v2/service/appconfig.

ff3c828

go get github.com/aws/aws-sdk-go-v2/service/appfabric.

195034e

go get github.com/aws/aws-sdk-go-v2/service/appflow.

3b48748

go get github.com/aws/aws-sdk-go-v2/service/appintegrations.

bab8c28

go get github.com/aws/aws-sdk-go-v2/service/applicationautoscaling.

b71d673

go get github.com/aws/aws-sdk-go-v2/service/applicationinsights.

9f002ab

go get github.com/aws/aws-sdk-go-v2/service/applicationsignals.

b3cea37

go get github.com/aws/aws-sdk-go-v2/service/appmesh.

9cf4b63

go get github.com/aws/aws-sdk-go-v2/service/apprunner.

d332f2b

go get github.com/aws/aws-sdk-go-v2/service/appstream.

de57b9b

go get github.com/aws/aws-sdk-go-v2/service/appsync.

add95de

go get github.com/aws/aws-sdk-go-v2/service/athena.

2ca3b30

go get github.com/aws/aws-sdk-go-v2/service/auditmanager.

190c070

go get github.com/aws/aws-sdk-go-v2/service/autoscaling.

79e844c

go get github.com/aws/aws-sdk-go-v2/service/autoscalingplans.

1d68529

ewbankkit added 20 commits September 24, 2024 09:31

go get github.com/aws/aws-sdk-go-v2/service/waf.

1d1c247

go get github.com/aws/aws-sdk-go-v2/service/wafregional.

18ef6f2

go get github.com/aws/aws-sdk-go-v2/service/wafv2.

c29cbad

go get github.com/aws/aws-sdk-go-v2/service/wellarchitected.

ad6a593

go get github.com/aws/aws-sdk-go-v2/service/worklink.

bf397ba

go get github.com/aws/aws-sdk-go-v2/service/workspaces.

7537639

go get github.com/aws/aws-sdk-go-v2/service/workspacesweb.

49bb485

go get github.com/aws/aws-sdk-go-v2/service/xray.

1fda2ed

Run 'make clean-tidy'.

95ec94b

flex: Use 'github.com/aws/aws-sdk-go-v2/aws' in unit tests.

ba7f0a6

err.IsUnsupportedOperationInPartitionError: Remove AWS SDK for Go v1 …

14cf39c

…support.

Remove 'TestBackoffDelayer'.

bcad8c8

ConfigureProvider: Use 'aws-sdk-go-base.endpoints'.

e1e86b5

costoptimizationhub: Improve 'findPreferences'.

d483941

'acctest.PreCheckCECostAllocationTagPayerAccount' -> 'ce.testAccPreCh…

82076b5

…eckCostAllocationTagPayerAccount'.

'acctest.PreCheckCECostCategoryPayerAccount' -> 'ce.testAccPreCheckCo…

adbdb56

…stCategoryPayerAccount'.

'acctest.PreCheckCloudSearchAccountAllowListed' -> 'cloudsearch.testA…

7b66d40

…ccPreCheck'.

acctest: Use 'github.com/aws/aws-sdk-go-v2/aws/arn'.

4a8b3f6

acctest: Use 'github.com/aws/aws-sdk-go-v2/aws'.

583b03a

acctest: Use 'aws-sdk-go-base.endpoints'.

4a02b3c

ewbankkit merged commit 9d3cac9 into main Sep 24, 2024
47 checks passed

ewbankkit deleted the td-aws_service-migrate branch September 24, 2024 15:25

github-actions bot added this to the v5.69.0 milestone Sep 24, 2024

terraform-aws-provider bot pushed a commit that referenced this pull request Sep 24, 2024

Update CHANGELOG.md for #39455

ae1327b

github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 26, 2024

ewbankkit mentioned this pull request Oct 17, 2024

[AWS SDK for Go Migration] Meta Data Sources Service #36188

Closed

github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

d/aws_service: Migrate from AWS SDK for Go v1 #39455

d/aws_service: Migrate from AWS SDK for Go v1 #39455

ewbankkit commented Sep 23, 2024

github-actions bot commented Sep 23, 2024

jar-b left a comment

ewbankkit commented Sep 24, 2024

github-actions bot commented Sep 26, 2024

github-actions bot commented Oct 28, 2024

d/aws_service: Migrate from AWS SDK for Go v1 #39455

d/aws_service: Migrate from AWS SDK for Go v1 #39455

Conversation

ewbankkit commented Sep 23, 2024

Description

Relations

Output from Acceptance Testing

github-actions bot commented Sep 23, 2024

Community Note

jar-b left a comment

Choose a reason for hiding this comment

ewbankkit commented Sep 24, 2024

github-actions bot commented Sep 26, 2024

github-actions bot commented Oct 28, 2024