Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TechDebt]: Remove use of errs.Must within service packages #39456

Merged
merged 45 commits into from
Sep 27, 2024
Merged

[TechDebt]: Remove use of errs.Must within service packages #39456

merged 45 commits into from
Sep 27, 2024

Commits on Sep 24, 2024

  1. ci(semgrep): add avoid-errs-Must check 

    This check will match on any use of `errs.Must(...)` within `internal/service/**/`. Errors should be handled explicitly in service packages to avoid the possibility of crashing the provider during execution. This function was originally intended for use while initializing service clients during the `ConfigureProvider` operation, where a panic is the appropriate course of action.
    @jar-b
    jar-b committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    1c3a8cd View commit details
    Browse the repository at this point in the history

  2. account: remove use of errs.Must

    @jar-b
    jar-b committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    a39a441 View commit details
    Browse the repository at this point in the history

  3. acmpca: remove use of errs.Must

    @jar-b
    jar-b committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    46f5b0f View commit details
    Browse the repository at this point in the history

  4. appfabric: remove use of errs.Must

    @jar-b
    jar-b committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    de6e050 View commit details
    Browse the repository at this point in the history

  5. appsync: remove use of errs.Must

    @jar-b
    jar-b committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    489d731 View commit details
    Browse the repository at this point in the history

  6. bedrockagent: remove use of errs.Must

    @jar-b
    jar-b committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    44fd0bf View commit details
    Browse the repository at this point in the history

  7. cloudformation: remove use of errs.Must

    @jar-b
    jar-b committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    bd3c194 View commit details
    Browse the repository at this point in the history

  8. cloudfrontkeyvaluestore: remove use of errs.Must

    @jar-b
    jar-b committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    8da6dc5 View commit details
    Browse the repository at this point in the history

  9. cognitoidp: remove use of errs.Must

    @jar-b
    jar-b committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    9794f22 View commit details
    Browse the repository at this point in the history

  10. computeoptimizer: remove use of errs.Must

    @jar-b
    jar-b committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    6418761 View commit details
    Browse the repository at this point in the history

  11. connect: remove use of errs.Must

    @jar-b
    jar-b committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    7c12a39 View commit details
    Browse the repository at this point in the history

  12. controltower: remove use of errs.Must

    @jar-b
    jar-b committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    fc94c65 View commit details
    Browse the repository at this point in the history

  13. dynamodb: remove use of errs.Must

    @jar-b
    jar-b committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    cbc3e98 View commit details
    Browse the repository at this point in the history

  14. ec2: remove use of errs.Must

    @jar-b
    jar-b committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    ab1022c View commit details
    Browse the repository at this point in the history

  15. elasticache: remove use of errs.Must

    @jar-b
    jar-b committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    14770dd View commit details
    Browse the repository at this point in the history

  16. elbv2: remove use of errs.Must

    @jar-b
    jar-b committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    6cbcd24 View commit details
    Browse the repository at this point in the history

  17. fms: remove use of errs.Must

    @jar-b
    jar-b committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    7a2896d View commit details
    Browse the repository at this point in the history

  18. grafana: remove use of errs.Must

    @jar-b
    jar-b committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    9b86753 View commit details
    Browse the repository at this point in the history

  19. lambda: remove use of errs.Must

    @jar-b
    jar-b committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    d4a7d97 View commit details
    Browse the repository at this point in the history

  20. lexv2models: remove use of errs.Must

    @jar-b
    jar-b committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    43d883e View commit details
    Browse the repository at this point in the history

  21. m2: remove use of errs.Must

    @jar-b
    jar-b committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    1f6bba8 View commit details
    Browse the repository at this point in the history

  22. networkmonitor: remove use of errs.Must

    @jar-b
    jar-b committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    a756de2 View commit details
    Browse the repository at this point in the history

  23. ram: remove use of errs.Must

    @jar-b
    jar-b committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    b8c9660 View commit details
    Browse the repository at this point in the history

  24. redshiftserverless: remove use of errs.Must

    @jar-b
    jar-b committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    9aa74dc View commit details
    Browse the repository at this point in the history

  25. route53: remove use of errs.Must

    @jar-b
    jar-b committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    a1b5fa7 View commit details
    Browse the repository at this point in the history

  26. route53domains: remove use of errs.Must

    @jar-b
    jar-b committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    3ef58c7 View commit details
    Browse the repository at this point in the history

  27. s3control: remove use of errs.Must

    @jar-b
    jar-b committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    20c8985 View commit details
    Browse the repository at this point in the history

  28. securityhub: remove use of errs.Must

    @jar-b
    jar-b committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    8568616 View commit details
    Browse the repository at this point in the history

  29. securitylake: remove use of errs.Must

    @jar-b
    jar-b committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    9e08d8d View commit details
    Browse the repository at this point in the history

  30. ssm: remove use of errs.Must

    @jar-b
    jar-b committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    f02599e View commit details
    Browse the repository at this point in the history

  31. wafv2: remove use of errs.Must

    @jar-b
    jar-b committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    f76139c View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. account: omit id from error if FlattenResourceId fails

    @jar-b
    jar-b committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    27f6e6b View commit details
    Browse the repository at this point in the history

  2. acmpca: omit id from error if FlattenResourceId fails

    @jar-b
    jar-b committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    478750e View commit details
    Browse the repository at this point in the history

  3. cognitoidp: omit id from error if FlattenResourceId fails

    @jar-b
    jar-b committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    f92a3c2 View commit details
    Browse the repository at this point in the history

  4. connect: omit id from error if FlattenResourceId fails

    @jar-b
    jar-b committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    a9b4cbd View commit details
    Browse the repository at this point in the history

  5. controltower: omit id from error if FlattenResourceId fails

    @jar-b
    jar-b committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    8500471 View commit details
    Browse the repository at this point in the history

  6. dynamodb: omit id from error if FlattenResourceId fails

    @jar-b
    jar-b committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    8872350 View commit details
    Browse the repository at this point in the history

  7. elasticache: omit id from error if FlattenResourceId fails

    @jar-b
    jar-b committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    c1e82a6 View commit details
    Browse the repository at this point in the history

  8. lambda: omit id from error if FlattenResourceId fails

    @jar-b
    jar-b committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    fcb8dac View commit details
    Browse the repository at this point in the history

  9. ram: omit id from error if FlattenResourceId fails

    @jar-b
    jar-b committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    597e5b6 View commit details
    Browse the repository at this point in the history

  10. route53: omit id from error if FlattenResourceId fails

    @jar-b
    jar-b committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    578ff16 View commit details
    Browse the repository at this point in the history

  11. securityhub: omit id from error if FlattenResourceId fails

    @jar-b
    jar-b committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    e5996f3 View commit details
    Browse the repository at this point in the history

  12. ssm: omit id from error if FlattenResourceId fails

    @jar-b
    jar-b committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    4dcade9 View commit details
    Browse the repository at this point in the history

  13. wafv2: omit id from error if FlattenResourceId fails

    @jar-b
    jar-b committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    2ead23c View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. Update internal/service/bedrockagent/agent_alias.go 

    Co-authored-by: Kit Ewbank <Kit_Ewbank@hotmail.com>
    @jar-b @ewbankkit
    jar-b and ewbankkit authored Sep 27, 2024
    Configuration menu
    Copy the full SHA
    52df9b9 View commit details
    Browse the repository at this point in the history