Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix aws_elasticache_replication_group recreation on import #39591

Merged

Conversation

vtstanescu
Copy link
Contributor

Description

Fix issue causing aws_elasticache_replication_group to be recreated after import.

Relations

Closes #32835

References

Output from Acceptance Testing

No new acceptance test was created. I'm not sure how to make one to test the import workflow and assert that the resource is not replaced afterwards.

@vtstanescu vtstanescu requested a review from a team as a code owner October 4, 2024 10:30
Copy link

github-actions bot commented Oct 4, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/elasticache Issues and PRs that pertain to the elasticache service. service/appstream Issues and PRs that pertain to the appstream service. generators Relates to code generators. needs-triage Waiting for first response or review from a maintainer. labels Oct 4, 2024
@vtstanescu vtstanescu force-pushed the b-aws_elasticache_replication_group-import branch from 1b66e92 to 79e99e9 Compare October 4, 2024 10:32
@vtstanescu vtstanescu force-pushed the b-aws_elasticache_replication_group-import branch from 79e99e9 to 2b40700 Compare October 4, 2024 10:37
@ewbankkit ewbankkit added bug Addresses a defect in current functionality. and removed service/appstream Issues and PRs that pertain to the appstream service. needs-triage Waiting for first response or review from a maintainer. labels Oct 4, 2024
@ewbankkit ewbankkit self-assigned this Oct 4, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 4, 2024
Copy link

github-actions bot commented Oct 4, 2024

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

--- PASS: TestAccElastiCacheReplicationGroup_basic (787.78s)
--- PASS: TestAccElastiCacheReplicationGroup_basic_v5 (787.82s)
--- PASS: TestAccElastiCacheReplicationGroup_vpc (818.80s)

@ewbankkit
Copy link
Contributor

@vtstanescu Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 3e439b5 into hashicorp:main Oct 4, 2024
16 checks passed
@github-actions github-actions bot added this to the v5.71.0 milestone Oct 4, 2024
@vtstanescu vtstanescu deleted the b-aws_elasticache_replication_group-import branch October 8, 2024 19:58
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 15, 2024
Copy link

This functionality has been released in v5.72.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. documentation Introduces or discusses updates to documentation. generators Relates to code generators. service/elasticache Issues and PRs that pertain to the elasticache service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: security_group_names attribute incorrect on aws_elasticache_replication_group import
2 participants