Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

f/New Resource Authorize VPC Endpoint Access #39846

Merged
merged 17 commits into from
Oct 29, 2024

Conversation

nam054
Copy link
Contributor

@nam054 nam054 commented Oct 23, 2024

Description

New Resource Authroize VPC Endpoint Access

Relations

Closes #33908.

References

Output from Acceptance Testing

> make testacc TESTARGS='-run=TestAccOpenSearchAuthorizeVPCEndpointAccess_' PKG=opensearch
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/opensearch/... -v -count 1 -parallel 20  -run=TestAccOpenSearchAuthorizeVPCEndpointAccess_ -timeout 360m
2024/10/25 09:43:47 Initializing Terraform AWS Provider...
=== RUN   TestAccOpenSearchAuthorizeVPCEndpointAccess_basic
=== PAUSE TestAccOpenSearchAuthorizeVPCEndpointAccess_basic
=== RUN   TestAccOpenSearchAuthorizeVPCEndpointAccess_disappears
=== PAUSE TestAccOpenSearchAuthorizeVPCEndpointAccess_disappears
=== CONT  TestAccOpenSearchAuthorizeVPCEndpointAccess_basic
=== CONT  TestAccOpenSearchAuthorizeVPCEndpointAccess_disappears
--- PASS: TestAccOpenSearchAuthorizeVPCEndpointAccess_basic (2409.46s)
--- PASS: TestAccOpenSearchAuthorizeVPCEndpointAccess_disappears (2509.82s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/opensearch 2516.068s

...

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. generators Relates to code generators. service/opensearch Issues and PRs that pertain to the opensearch service. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Oct 23, 2024
@nam054 nam054 marked this pull request as ready for review October 25, 2024 06:33
@nam054 nam054 requested a review from a team as a code owner October 25, 2024 06:33
@ewbankkit ewbankkit added the new-resource Introduces a new resource. label Oct 29, 2024
@ewbankkit ewbankkit self-assigned this Oct 29, 2024
@ewbankkit
Copy link
Contributor

Needs a CHANGELOG entry.

Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccOpenSearchAuthorizeVPCEndpointAccess_' PKG=opensearch
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/opensearch/... -v -count 1 -parallel 20  -run=TestAccOpenSearchAuthorizeVPCEndpointAccess_ -timeout 360m
2024/10/29 12:18:06 Initializing Terraform AWS Provider...
=== RUN   TestAccOpenSearchAuthorizeVPCEndpointAccess_basic
=== PAUSE TestAccOpenSearchAuthorizeVPCEndpointAccess_basic
=== RUN   TestAccOpenSearchAuthorizeVPCEndpointAccess_disappears
=== PAUSE TestAccOpenSearchAuthorizeVPCEndpointAccess_disappears
=== CONT  TestAccOpenSearchAuthorizeVPCEndpointAccess_basic
=== CONT  TestAccOpenSearchAuthorizeVPCEndpointAccess_disappears
--- PASS: TestAccOpenSearchAuthorizeVPCEndpointAccess_disappears (2145.77s)
--- PASS: TestAccOpenSearchAuthorizeVPCEndpointAccess_basic (2252.11s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/opensearch	2257.363s

@nam054 nam054 merged commit 1fefd6b into main Oct 29, 2024
41 checks passed
@nam054 nam054 deleted the f/opensearch-auth-vpc-endpt-access branch October 29, 2024 20:25
@github-actions github-actions bot added this to the v5.74.0 milestone Oct 29, 2024
terraform-aws-provider bot pushed a commit that referenced this pull request Oct 29, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 31, 2024
Copy link

This functionality has been released in v5.74.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. service/opensearch Issues and PRs that pertain to the opensearch service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Resource]: Opensearch: Authorize VPC endpoint access
2 participants