Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix aws_elasticache_reserved_cache_node data mapping #39945

Merged
merged 4 commits into from
Oct 31, 2024
Merged

Fix aws_elasticache_reserved_cache_node data mapping #39945

merged 4 commits into from
Oct 31, 2024

Conversation

JHBaik
Copy link
Contributor

@JHBaik JHBaik commented Oct 30, 2024

Description

Fix #39451

Relations

Closes #0000

References

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

@JHBaik JHBaik requested a review from a team as a code owner October 30, 2024 14:25
@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/elasticache Issues and PRs that pertain to the elasticache service. needs-triage Waiting for first response or review from a maintainer. labels Oct 30, 2024
@JHBaik
Copy link
Contributor Author

JHBaik commented Oct 30, 2024 •
edited
Loading

Is there any possible way to test irreversible resource like this? (eg. import or mocking test)

@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 31, 2024
@jar-b jar-b self-assigned this Oct 31, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 31, 2024
jar-b added 3 commits October 31, 2024 14:08
@jar-b
Merge branch 'main' into b-aws_elasticache_reserved_cache_node-mapping
f6dc97f
@jar-b
r/aws_elasticache_reserved_cache_node: revert ID struct field name …
e8794cc 
…change

This inconsistency with the AWS data structure is already accounted for by the AutoFlex `flex.WithFieldNamePrefix` option passed to the `flex.Flatten` function. The change to `ReservationARN was left in place.
@jar-b
chore: changelog
fb796e3
jar-b
jar-b approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

We are unable to acceptance test this resource as removal of the reserved cache node requires contacting AWS support. As such, this fix is a best effort implementation and we ask for community feedback on the change. Please link any new bug reports to this PR. Thank you!

@jar-b
Copy link
Member

jar-b commented Oct 31, 2024

Thanks for the fix, @JHBaik! 👍

@jar-b jar-b merged commit 7526509 into hashicorp:main Oct 31, 2024
31 checks passed
@github-actions github-actions bot added this to the v5.75.0 milestone Oct 31, 2024
@JHBaik JHBaik deleted the b-aws_elasticache_reserved_cache_node-mapping branch November 3, 2024 09:20
@pshen pshen mentioned this pull request Nov 8, 2024
Closed
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Nov 11, 2024
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.75.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@jar-b jar-b mentioned this pull request Nov 11, 2024
Merged
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jar-b jar-b jar-b approved these changes

Assignees

@jar-b jar-b

Labels
bug Addresses a defect in current functionality. service/elasticache Issues and PRs that pertain to the elasticache service.
Projects
None yet
Milestone
v5.75.0
Development

Successfully merging this pull request may close these issues.

[Bug]: Cannot use attr.Value basetypes.StringValue in aws_elasticache_reserved_cache_node
3 participants
@JHBaik @jar-b @justinretzolk