Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for zonal_shift_config to EKS cluster #39946

Merged
merged 7 commits into from
Oct 31, 2024

Conversation

bryantbiggs
Copy link
Contributor

@bryantbiggs bryantbiggs commented Oct 30, 2024

Description

  • Add support for zonal_shift_config to EKS cluster

Relations

Closes #39852

References

Output from Acceptance Testing

make testacc TESTS=TestAccEKSClusterDataSource_basic PKG=eks
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/eks/... -v -count 1 -parallel 20 -run='TestAccEKSClusterDataSource_basic'  -timeout 360m
2024/10/30 10:28:37 Initializing Terraform AWS Provider...
=== RUN   TestAccEKSClusterDataSource_basic
=== PAUSE TestAccEKSClusterDataSource_basic
=== CONT  TestAccEKSClusterDataSource_basic
--- PASS: TestAccEKSClusterDataSource_basic (833.23s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/eks	838.630s
make testacc TESTS=TestAccEKSCluster_basic PKG=eks
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/eks/... -v -count 1 -parallel 20 -run='TestAccEKSCluster_basic'  -timeout 360m
2024/10/30 10:54:34 Initializing Terraform AWS Provider...
=== RUN   TestAccEKSCluster_basic
=== PAUSE TestAccEKSCluster_basic
=== CONT  TestAccEKSCluster_basic
--- PASS: TestAccEKSCluster_basic (762.79s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/eks	768.025s
make testacc TESTS=TestAccEKSCluster_zonalShiftConfig PKG=eks
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/eks/... -v -count 1 -parallel 20 -run='TestAccEKSCluster_zonalShiftConfig'  -timeout 360m
2024/10/30 11:10:20 Initializing Terraform AWS Provider...
=== RUN   TestAccEKSCluster_zonalShiftConfig
=== PAUSE TestAccEKSCluster_zonalShiftConfig
=== CONT  TestAccEKSCluster_zonalShiftConfig
--- PASS: TestAccEKSCluster_zonalShiftConfig (776.15s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/eks	781.471s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/eks Issues and PRs that pertain to the eks service. needs-triage Waiting for first response or review from a maintainer. partner Contribution from a partner. labels Oct 30, 2024
@bryantbiggs bryantbiggs marked this pull request as ready for review October 30, 2024 16:23
@bryantbiggs bryantbiggs requested a review from a team as a code owner October 30, 2024 16:23
@github-actions github-actions bot added the service/keyspaces Issues and PRs that pertain to the keyspaces service. label Oct 30, 2024
@jar-b jar-b removed the needs-triage Waiting for first response or review from a maintainer. label Oct 31, 2024
@jar-b jar-b self-assigned this Oct 31, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 31, 2024
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make testacc PKG=eks TESTS=TestAccEKSCluster_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/eks/... -v -count 1 -parallel 20 -run='TestAccEKSCluster_'  -timeout 360m
2024/10/31 11:06:58 Initializing Terraform AWS Provider...

=== NAME  TestAccEKSCluster_Outpost_placement
    cluster_test.go:894: skipping since no Outposts found
--- SKIP: TestAccEKSCluster_Outpost_placement (0.80s)
=== CONT  TestAccEKSCluster_logging
=== NAME  TestAccEKSCluster_Outpost_create
    cluster_test.go:861: skipping since no Outposts found
--- SKIP: TestAccEKSCluster_Outpost_create (0.81s)
=== CONT  TestAccEKSCluster_tags
--- PASS: TestAccEKSCluster_zonalShiftConfig (527.43s)
=== CONT  TestAccEKSCluster_version
--- PASS: TestAccEKSCluster_VPC_securityGroupIDs (610.26s)
--- PASS: TestAccEKSCluster_tags (645.68s)
--- PASS: TestAccEKSCluster_disappears (684.88s)
--- PASS: TestAccEKSCluster_basic (696.13s)
--- PASS: TestAccEKSCluster_logging (697.26s)
--- PASS: TestAccEKSCluster_AccessConfig_create (701.35s)
--- PASS: TestAccEKSCluster_Encryption_create (716.07s)
--- PASS: TestAccEKSCluster_AccessConfig_update (720.54s)
--- PASS: TestAccEKSCluster_upgradePolicy (751.34s)
--- PASS: TestAccEKSCluster_BootstrapSelfManagedAddons_migrate (752.72s)
--- PASS: TestAccEKSCluster_VPC_publicAccessCIDRs (926.05s)
--- PASS: TestAccEKSCluster_VPC_endpointPublicAccess (1120.76s)
--- PASS: TestAccEKSCluster_Network_ipFamily (1189.37s)
--- PASS: TestAccEKSCluster_Encryption_versionUpdate (1221.98s)
--- PASS: TestAccEKSCluster_BootstrapSelfManagedAddons_update (1259.88s)
--- PASS: TestAccEKSCluster_Network_serviceIPv4CIDR (1378.35s)
--- PASS: TestAccEKSCluster_VPC_endpointPrivateAccess (1606.63s)
--- PASS: TestAccEKSCluster_Encryption_update (1616.18s)
--- PASS: TestAccEKSCluster_VPC_securityGroupIDsAndSubnetIDs_update (1638.46s)
--- PASS: TestAccEKSCluster_version (1237.57s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/eks        1771.492s

@jar-b
Copy link
Member

jar-b commented Oct 31, 2024

Thanks for your contribution, @bryantbiggs! 👍

@jar-b jar-b merged commit 09fad67 into hashicorp:main Oct 31, 2024
47 checks passed
@github-actions github-actions bot added this to the v5.74.0 milestone Oct 31, 2024
@bryantbiggs bryantbiggs deleted the feat/eks-zonal-shift branch October 31, 2024 16:55
Copy link

This functionality has been released in v5.74.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
partner Contribution from a partner. service/eks Issues and PRs that pertain to the eks service. service/keyspaces Issues and PRs that pertain to the keyspaces service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: support EKS ARC Zonal shift configuration
2 participants