Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CodeDeploy alarm limit #39971

Merged
merged 5 commits into from
Nov 4, 2024
Merged

Remove CodeDeploy alarm limit #39971

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1f3939a
Remove CodeDeploy alarm limit
AnitaErnszt Oct 31, 2024
dafea53
add file to changelog
AnitaErnszt Oct 31, 2024
0f1b442
Merge branch 'main' into b-remove-deploy-alarm-limit
jar-b Nov 1, 2024
95e73a8
chore: tweak changelog
jar-b Nov 1, 2024
ccc6580
chore: revert cdktf documentation changes
jar-b Nov 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/39971.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:bug
resource/aws_codedeploy_deployment_group: Remove maximum items limit on the `alarm_configuration.alarms` argument
```
1 change: 0 additions & 1 deletion internal/service/deploy/deployment_group.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,6 @@ func resourceDeploymentGroup() *schema.Resource {
Schema: map[string]*schema.Schema{
"alarms": {
Type: schema.TypeSet,
MaxItems: 10,
Optional: true,
Elem: &schema.Schema{Type: schema.TypeString},
},
Expand Down
2 changes: 1 addition & 1 deletion website/docs/r/codedeploy_deployment_group.html.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ This resource supports the following arguments:

You can configure a deployment to stop when a **CloudWatch** alarm detects that a metric has fallen below or exceeded a defined threshold. `alarm_configuration` supports the following:

* `alarms` - (Optional) A list of alarms configured for the deployment group. _A maximum of 10 alarms can be added to a deployment group_.
* `alarms` - (Optional) A list of alarms configured for the deployment group.
* `enabled` - (Optional) Indicates whether the alarm configuration is enabled. This option is useful when you want to temporarily deactivate alarm monitoring for a deployment group without having to add the same alarms again later.
* `ignore_poll_alarm_failure` - (Optional) Indicates whether a deployment should continue if information about the current state of alarms cannot be retrieved from CloudWatch. The default value is `false`.
* `true`: The deployment will proceed even if alarm status information can't be retrieved.
Expand Down
Loading