Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for pod_identity_associations argument for aws_eks_addon #39973

Merged

Conversation

bryantbiggs
Copy link
Contributor

Description

  • Add support for pod_identity_associations argument for aws_eks_addon

Relations

Closes #38357

References

Output from Acceptance Testing

make testacc TESTS=TestAccEKSAddon_podIdentityAssociation PKG=eks
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/eks/... -v -count 1 -parallel 20 -run='TestAccEKSAddon_podIdentityAssociation'  -timeout 360m
2024/10/31 13:36:47 Initializing Terraform AWS Provider...
=== RUN   TestAccEKSAddon_podIdentityAssociation
=== PAUSE TestAccEKSAddon_podIdentityAssociation
=== CONT  TestAccEKSAddon_podIdentityAssociation
--- PASS: TestAccEKSAddon_podIdentityAssociation (640.75s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/eks	646.152s
make testacc TESTS=TestAccEKSAddonDataSource_basic PKG=eks
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/eks/... -v -count 1 -parallel 20 -run='TestAccEKSAddonDataSource_basic'  -timeout 360m
2024/10/31 13:40:32 Initializing Terraform AWS Provider...
=== RUN   TestAccEKSAddonDataSource_basic
=== PAUSE TestAccEKSAddonDataSource_basic
=== CONT  TestAccEKSAddonDataSource_basic
--- PASS: TestAccEKSAddonDataSource_basic (734.58s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/eks	740.896s

@bryantbiggs bryantbiggs requested a review from a team as a code owner October 31, 2024 20:46
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/eks Issues and PRs that pertain to the eks service. needs-triage Waiting for first response or review from a maintainer. partner Contribution from a partner. labels Oct 31, 2024
@bryantbiggs bryantbiggs force-pushed the feat/eks-add-on-pod-identity-association branch from dc5d6e2 to 673f41b Compare November 1, 2024 00:40
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 1, 2024
@jar-b jar-b self-assigned this Nov 4, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Nov 4, 2024
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make testacc PKG=eks TESTS="TestAccEKSAddon_|TestAccEKSAddonDataSource_"
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/eks/... -v -count 1 -parallel 20 -run='TestAccEKSAddon_|TestAccEKSAddonDataSource_'  -timeout 360m
2024/11/04 11:49:54 Initializing Terraform AWS Provider...

--- PASS: TestAccEKSAddon_disappears (506.66s)
--- PASS: TestAccEKSAddon_serviceAccountRoleARN (556.18s)
--- PASS: TestAccEKSAddon_preserve (597.77s)
--- PASS: TestAccEKSAddon_resolveConflicts (633.53s)
--- PASS: TestAccEKSAddon_Disappears_cluster (644.31s)
--- PASS: TestAccEKSAddon_basic (651.14s)
--- PASS: TestAccEKSAddonDataSource_configurationValues (665.82s)
--- PASS: TestAccEKSAddon_addonVersion (673.28s)
--- PASS: TestAccEKSAddon_tags (674.58s)
--- PASS: TestAccEKSAddon_configurationValues (676.50s)
--- PASS: TestAccEKSAddon_podIdentityAssociation (735.19s)
--- PASS: TestAccEKSAddon_deprecated (775.72s)
--- PASS: TestAccEKSAddonDataSource_basic (786.47s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/eks        792.798s

@jar-b
Copy link
Member

jar-b commented Nov 4, 2024

Thanks for your contribution, @bryantbiggs! 👍

@jar-b jar-b merged commit 7a515b4 into hashicorp:main Nov 4, 2024
41 checks passed
@github-actions github-actions bot added this to the v5.75.0 milestone Nov 4, 2024
@bryantbiggs bryantbiggs deleted the feat/eks-add-on-pod-identity-association branch November 4, 2024 19:22
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Nov 11, 2024
Copy link

This functionality has been released in v5.75.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. partner Contribution from a partner. service/eks Issues and PRs that pertain to the eks service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Add support for EKS Addon Pod Identity Associations
3 participants