New Resource: aws_default_internet_gateway

[ewbankkit]

Fixes #2436.

The default Internet Gateway in an AWS region is the sole attached Internet Gateway in that region's default VPC.

Acceptance tests:

 make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsDefaultInternetGateway_'==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -run=TestAccAwsDefaultInternetGateway_ -timeout 120m
=== RUN   TestAccAwsDefaultInternetGateway_basic
--- PASS: TestAccAwsDefaultInternetGateway_basic (14.24s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	14.255s

[jen20]

Do you think we should provide a more strict warning, akin to https://www.terraform.io/docs/providers/aws/r/default_route_table.html, about the fact that Terraform cannot destroy this resource?

[ewbankkit]

@jen20 I think that's already taken care of in the Removing aws_default_internet_gateway from your configuration section below.

[jen20]

Hi @ewbankkit! Thanks for the pull request, and sorry for the delay in getting it reviewed. The code looks good to me - I've left one minor comment on the documentation. If you could let me know your thoughts there we can get this merged.

[ewbankkit]

After thinking about this some more I think the most sustainable solution is to use terraform import to manage the default Internet Gateway.
See remarks here: #2436 (comment).

[e-moshaya]

@ewbankkit any reason why this wasn't merged? Terraform import into each state file is not really an option for us as this a manual step we'd like to avoid.

[ewbankkit]

@e-moshaya As I remember my reasoning was:

• Limit resource sprawl
• There's a "workaround" via terraform import
• Unlike the other VPC default resources there's no concept in the AWS API of default IGW - Once the resource is imported it behaves exactly like any other IGW

[e-moshaya]

@ewbankkit sorry to bring this up again but we've now integrated amazon config and have a rule to check all resources for specific tags. Unfortunately, this is the only resource that is not tagged. importing the resource is really not an option seeing as it's a manual step which defeats the purpose of terraform. Please could you reconsider this pull request?

[ewbankkit]

@e-moshaya I'm happy for someone else to pick up the code.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!