Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New resource - aws_vpc_block_public_access_exclusion #40235

Merged
merged 17 commits into from
Nov 27, 2024
Merged

New resource - aws_vpc_block_public_access_exclusion #40235

merged 17 commits into from
Nov 27, 2024

Conversation

madhavvishnubhatta
Copy link
Contributor

Description

New resource aws_vpc_block_public_access_exclusion to support the feature https://aws.amazon.com/about-aws/whats-new/2024/11/block-public-access-amazon-virtual-private-cloud/

Relations

Along with #40233 these close #40200

References

https://aws.amazon.com/about-aws/whats-new/2024/11/block-public-access-amazon-virtual-private-cloud/
https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_VpcBlockPublicAccessExclusion.html

Output from Acceptance Testing

$ make testacc PKG=ec2 TESTS=TestAccVPCBlockPublicAccessExclusion*
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/ec2/... -v -count 1 -parallel 5 -run='TestAccVPCBlockPublicAccessExclusion*'  -timeout 360m
2024/11/21 13:02:36 Initializing Terraform AWS Provider...
=== RUN   TestAccVPCBlockPublicAccessExclusion_tags
=== PAUSE TestAccVPCBlockPublicAccessExclusion_tags
=== RUN   TestAccVPCBlockPublicAccessExclusion_tags_null
=== PAUSE TestAccVPCBlockPublicAccessExclusion_tags_null
=== RUN   TestAccVPCBlockPublicAccessExclusion_tags_EmptyMap
=== PAUSE TestAccVPCBlockPublicAccessExclusion_tags_EmptyMap
=== RUN   TestAccVPCBlockPublicAccessExclusion_tags_AddOnUpdate
=== PAUSE TestAccVPCBlockPublicAccessExclusion_tags_AddOnUpdate
=== RUN   TestAccVPCBlockPublicAccessExclusion_tags_EmptyTag_OnCreate
=== PAUSE TestAccVPCBlockPublicAccessExclusion_tags_EmptyTag_OnCreate
=== RUN   TestAccVPCBlockPublicAccessExclusion_tags_EmptyTag_OnUpdate_Add
=== PAUSE TestAccVPCBlockPublicAccessExclusion_tags_EmptyTag_OnUpdate_Add
=== RUN   TestAccVPCBlockPublicAccessExclusion_tags_EmptyTag_OnUpdate_Replace
=== PAUSE TestAccVPCBlockPublicAccessExclusion_tags_EmptyTag_OnUpdate_Replace
=== RUN   TestAccVPCBlockPublicAccessExclusion_tags_DefaultTags_providerOnly
=== PAUSE TestAccVPCBlockPublicAccessExclusion_tags_DefaultTags_providerOnly
=== RUN   TestAccVPCBlockPublicAccessExclusion_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccVPCBlockPublicAccessExclusion_tags_DefaultTags_nonOverlapping
=== RUN   TestAccVPCBlockPublicAccessExclusion_tags_DefaultTags_overlapping
=== PAUSE TestAccVPCBlockPublicAccessExclusion_tags_DefaultTags_overlapping
=== RUN   TestAccVPCBlockPublicAccessExclusion_tags_DefaultTags_updateToProviderOnly
=== PAUSE TestAccVPCBlockPublicAccessExclusion_tags_DefaultTags_updateToProviderOnly
=== RUN   TestAccVPCBlockPublicAccessExclusion_tags_DefaultTags_updateToResourceOnly
=== PAUSE TestAccVPCBlockPublicAccessExclusion_tags_DefaultTags_updateToResourceOnly
=== RUN   TestAccVPCBlockPublicAccessExclusion_tags_DefaultTags_emptyResourceTag
=== PAUSE TestAccVPCBlockPublicAccessExclusion_tags_DefaultTags_emptyResourceTag
=== RUN   TestAccVPCBlockPublicAccessExclusion_tags_DefaultTags_emptyProviderOnlyTag
=== PAUSE TestAccVPCBlockPublicAccessExclusion_tags_DefaultTags_emptyProviderOnlyTag
=== RUN   TestAccVPCBlockPublicAccessExclusion_tags_DefaultTags_nullOverlappingResourceTag
=== PAUSE TestAccVPCBlockPublicAccessExclusion_tags_DefaultTags_nullOverlappingResourceTag
=== RUN   TestAccVPCBlockPublicAccessExclusion_tags_DefaultTags_nullNonOverlappingResourceTag
=== PAUSE TestAccVPCBlockPublicAccessExclusion_tags_DefaultTags_nullNonOverlappingResourceTag
=== RUN   TestAccVPCBlockPublicAccessExclusion_tags_ComputedTag_OnCreate
=== PAUSE TestAccVPCBlockPublicAccessExclusion_tags_ComputedTag_OnCreate
=== RUN   TestAccVPCBlockPublicAccessExclusion_tags_ComputedTag_OnUpdate_Add
=== PAUSE TestAccVPCBlockPublicAccessExclusion_tags_ComputedTag_OnUpdate_Add
=== RUN   TestAccVPCBlockPublicAccessExclusion_tags_ComputedTag_OnUpdate_Replace
=== PAUSE TestAccVPCBlockPublicAccessExclusion_tags_ComputedTag_OnUpdate_Replace
=== RUN   TestAccVPCBlockPublicAccessExclusion_tags_IgnoreTags_Overlap_DefaultTag
=== PAUSE TestAccVPCBlockPublicAccessExclusion_tags_IgnoreTags_Overlap_DefaultTag
=== RUN   TestAccVPCBlockPublicAccessExclusion_tags_IgnoreTags_Overlap_ResourceTag
=== PAUSE TestAccVPCBlockPublicAccessExclusion_tags_IgnoreTags_Overlap_ResourceTag
=== RUN   TestAccVPCBlockPublicAccessExclusion_basic_vpc
=== PAUSE TestAccVPCBlockPublicAccessExclusion_basic_vpc
=== RUN   TestAccVPCBlockPublicAccessExclusion_basic_subnet
=== PAUSE TestAccVPCBlockPublicAccessExclusion_basic_subnet
=== RUN   TestAccVPCBlockPublicAccessExclusion_disappears
=== PAUSE TestAccVPCBlockPublicAccessExclusion_disappears
=== CONT  TestAccVPCBlockPublicAccessExclusion_tags
=== CONT  TestAccVPCBlockPublicAccessExclusion_tags_DefaultTags_emptyResourceTag
=== CONT  TestAccVPCBlockPublicAccessExclusion_tags_EmptyTag_OnUpdate_Replace
=== CONT  TestAccVPCBlockPublicAccessExclusion_tags_DefaultTags_overlapping
=== CONT  TestAccVPCBlockPublicAccessExclusion_tags_DefaultTags_updateToResourceOnly
--- PASS: TestAccVPCBlockPublicAccessExclusion_tags_DefaultTags_emptyResourceTag (441.40s)
=== CONT  TestAccVPCBlockPublicAccessExclusion_tags_DefaultTags_updateToProviderOnly
--- PASS: TestAccVPCBlockPublicAccessExclusion_tags_EmptyTag_OnUpdate_Replace (458.68s)
=== CONT  TestAccVPCBlockPublicAccessExclusion_tags_AddOnUpdate
--- PASS: TestAccVPCBlockPublicAccessExclusion_tags_DefaultTags_updateToResourceOnly (458.79s)
=== CONT  TestAccVPCBlockPublicAccessExclusion_tags_EmptyTag_OnUpdate_Add
--- PASS: TestAccVPCBlockPublicAccessExclusion_tags_DefaultTags_overlapping (481.38s)
=== CONT  TestAccVPCBlockPublicAccessExclusion_tags_EmptyTag_OnCreate
--- PASS: TestAccVPCBlockPublicAccessExclusion_tags (485.77s)
=== CONT  TestAccVPCBlockPublicAccessExclusion_tags_EmptyMap
--- PASS: TestAccVPCBlockPublicAccessExclusion_tags_DefaultTags_updateToProviderOnly (417.58s)
=== CONT  TestAccVPCBlockPublicAccessExclusion_tags_ComputedTag_OnUpdate_Replace
=== CONT  TestAccVPCBlockPublicAccessExclusion_disappears
--- PASS: TestAccVPCBlockPublicAccessExclusion_tags_AddOnUpdate (420.12s)
--- PASS: TestAccVPCBlockPublicAccessExclusion_tags_EmptyMap (404.33s)
=== CONT  TestAccVPCBlockPublicAccessExclusion_tags_null
--- PASS: TestAccVPCBlockPublicAccessExclusion_tags_EmptyTag_OnUpdate_Add (438.44s)
=== CONT  TestAccVPCBlockPublicAccessExclusion_basic_subnet
--- PASS: TestAccVPCBlockPublicAccessExclusion_tags_EmptyTag_OnCreate (422.36s)
=== CONT  TestAccVPCBlockPublicAccessExclusion_basic_vpc
--- PASS: TestAccVPCBlockPublicAccessExclusion_disappears (407.69s)
=== CONT  TestAccVPCBlockPublicAccessExclusion_tags_IgnoreTags_Overlap_ResourceTag
--- PASS: TestAccVPCBlockPublicAccessExclusion_tags_null (525.08s)
=== CONT  TestAccVPCBlockPublicAccessExclusion_tags_DefaultTags_providerOnly
=== CONT  TestAccVPCBlockPublicAccessExclusion_tags_DefaultTags_nullNonOverlappingResourceTag
--- PASS: TestAccVPCBlockPublicAccessExclusion_tags_ComputedTag_OnUpdate_Replace (580.54s)
--- PASS: TestAccVPCBlockPublicAccessExclusion_basic_vpc (724.53s)
=== CONT  TestAccVPCBlockPublicAccessExclusion_tags_ComputedTag_OnUpdate_Add
--- PASS: TestAccVPCBlockPublicAccessExclusion_basic_subnet (734.27s)
=== CONT  TestAccVPCBlockPublicAccessExclusion_tags_IgnoreTags_Overlap_DefaultTag
--- PASS: TestAccVPCBlockPublicAccessExclusion_tags_IgnoreTags_Overlap_ResourceTag (389.43s)
=== CONT  TestAccVPCBlockPublicAccessExclusion_tags_ComputedTag_OnCreate
--- PASS: TestAccVPCBlockPublicAccessExclusion_tags_DefaultTags_nullNonOverlappingResourceTag (343.83s)
=== CONT  TestAccVPCBlockPublicAccessExclusion_tags_DefaultTags_nullOverlappingResourceTag
--- PASS: TestAccVPCBlockPublicAccessExclusion_tags_DefaultTags_providerOnly (417.00s)
=== CONT  TestAccVPCBlockPublicAccessExclusion_tags_DefaultTags_emptyProviderOnlyTag
--- PASS: TestAccVPCBlockPublicAccessExclusion_tags_ComputedTag_OnUpdate_Add (389.17s)
=== CONT  TestAccVPCBlockPublicAccessExclusion_tags_DefaultTags_nonOverlapping
--- PASS: TestAccVPCBlockPublicAccessExclusion_tags_ComputedTag_OnCreate (372.59s)
--- PASS: TestAccVPCBlockPublicAccessExclusion_tags_IgnoreTags_Overlap_DefaultTag (426.91s)
--- PASS: TestAccVPCBlockPublicAccessExclusion_tags_DefaultTags_nullOverlappingResourceTag (372.53s)
--- PASS: TestAccVPCBlockPublicAccessExclusion_tags_DefaultTags_emptyProviderOnlyTag (382.82s)
--- PASS: TestAccVPCBlockPublicAccessExclusion_tags_DefaultTags_nonOverlapping (356.85s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2    2374.429s

...

@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. generators Relates to code generators. github_actions Pull requests that update Github_actions code service/vpc Issues and PRs that pertain to the vpc service. needs-triage Waiting for first response or review from a maintainer. partner Contribution from a partner. labels Nov 21, 2024
@madhavvishnubhatta
Copy link
Contributor Author

madhavvishnubhatta commented Nov 21, 2024 •
edited
Loading

There are two failing checks at the moment on this PR.

I am not sure how to avoid this failure as it is a warning for rName in the generated tag tests that is not being used. I looked at the tag tests generation directives but there does not seem to be way to avoid rName being generated. Please let me know if I missed something.

As for this failure regarding the same command runs fine on my machine. I wonder if it just needs to be re-run. Can someone take a look and let me know?

@madhavvishnubhatta madhavvishnubhatta marked this pull request as ready for review November 21, 2024 17:07
@ewbankkit ewbankkit added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 26, 2024
@ewbankkit ewbankkit self-assigned this Nov 26, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Nov 26, 2024
ewbankkit
ewbankkit previously approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

%  make testacc TESTARGS='-run=TestAccVPCBlockPublicAccessExclusion_' PKG=ec2 ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/ec2/... -v -count 1 -parallel 3  -run=TestAccVPCBlockPublicAccessExclusion_ -timeout 360m
2024/11/26 16:36:33 Initializing Terraform AWS Provider...
=== RUN   TestAccVPCBlockPublicAccessExclusion_tags
=== PAUSE TestAccVPCBlockPublicAccessExclusion_tags
=== RUN   TestAccVPCBlockPublicAccessExclusion_tags_null
=== PAUSE TestAccVPCBlockPublicAccessExclusion_tags_null
=== RUN   TestAccVPCBlockPublicAccessExclusion_tags_EmptyMap
=== PAUSE TestAccVPCBlockPublicAccessExclusion_tags_EmptyMap
=== RUN   TestAccVPCBlockPublicAccessExclusion_tags_AddOnUpdate
=== PAUSE TestAccVPCBlockPublicAccessExclusion_tags_AddOnUpdate
=== RUN   TestAccVPCBlockPublicAccessExclusion_tags_EmptyTag_OnCreate
=== PAUSE TestAccVPCBlockPublicAccessExclusion_tags_EmptyTag_OnCreate
=== RUN   TestAccVPCBlockPublicAccessExclusion_tags_EmptyTag_OnUpdate_Add
=== PAUSE TestAccVPCBlockPublicAccessExclusion_tags_EmptyTag_OnUpdate_Add
=== RUN   TestAccVPCBlockPublicAccessExclusion_tags_EmptyTag_OnUpdate_Replace
=== PAUSE TestAccVPCBlockPublicAccessExclusion_tags_EmptyTag_OnUpdate_Replace
=== RUN   TestAccVPCBlockPublicAccessExclusion_tags_DefaultTags_providerOnly
=== PAUSE TestAccVPCBlockPublicAccessExclusion_tags_DefaultTags_providerOnly
=== RUN   TestAccVPCBlockPublicAccessExclusion_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccVPCBlockPublicAccessExclusion_tags_DefaultTags_nonOverlapping
=== RUN   TestAccVPCBlockPublicAccessExclusion_tags_DefaultTags_overlapping
=== PAUSE TestAccVPCBlockPublicAccessExclusion_tags_DefaultTags_overlapping
=== RUN   TestAccVPCBlockPublicAccessExclusion_tags_DefaultTags_updateToProviderOnly
=== PAUSE TestAccVPCBlockPublicAccessExclusion_tags_DefaultTags_updateToProviderOnly
=== RUN   TestAccVPCBlockPublicAccessExclusion_tags_DefaultTags_updateToResourceOnly
=== PAUSE TestAccVPCBlockPublicAccessExclusion_tags_DefaultTags_updateToResourceOnly
=== RUN   TestAccVPCBlockPublicAccessExclusion_tags_DefaultTags_emptyResourceTag
=== PAUSE TestAccVPCBlockPublicAccessExclusion_tags_DefaultTags_emptyResourceTag
=== RUN   TestAccVPCBlockPublicAccessExclusion_tags_DefaultTags_emptyProviderOnlyTag
=== PAUSE TestAccVPCBlockPublicAccessExclusion_tags_DefaultTags_emptyProviderOnlyTag
=== RUN   TestAccVPCBlockPublicAccessExclusion_tags_DefaultTags_nullOverlappingResourceTag
=== PAUSE TestAccVPCBlockPublicAccessExclusion_tags_DefaultTags_nullOverlappingResourceTag
=== RUN   TestAccVPCBlockPublicAccessExclusion_tags_DefaultTags_nullNonOverlappingResourceTag
=== PAUSE TestAccVPCBlockPublicAccessExclusion_tags_DefaultTags_nullNonOverlappingResourceTag
=== RUN   TestAccVPCBlockPublicAccessExclusion_tags_ComputedTag_OnCreate
=== PAUSE TestAccVPCBlockPublicAccessExclusion_tags_ComputedTag_OnCreate
=== RUN   TestAccVPCBlockPublicAccessExclusion_tags_ComputedTag_OnUpdate_Add
=== PAUSE TestAccVPCBlockPublicAccessExclusion_tags_ComputedTag_OnUpdate_Add
=== RUN   TestAccVPCBlockPublicAccessExclusion_tags_ComputedTag_OnUpdate_Replace
=== PAUSE TestAccVPCBlockPublicAccessExclusion_tags_ComputedTag_OnUpdate_Replace
=== RUN   TestAccVPCBlockPublicAccessExclusion_tags_IgnoreTags_Overlap_DefaultTag
=== PAUSE TestAccVPCBlockPublicAccessExclusion_tags_IgnoreTags_Overlap_DefaultTag
=== RUN   TestAccVPCBlockPublicAccessExclusion_tags_IgnoreTags_Overlap_ResourceTag
=== PAUSE TestAccVPCBlockPublicAccessExclusion_tags_IgnoreTags_Overlap_ResourceTag
=== RUN   TestAccVPCBlockPublicAccessExclusion_basicVPC
=== PAUSE TestAccVPCBlockPublicAccessExclusion_basicVPC
=== RUN   TestAccVPCBlockPublicAccessExclusion_basicSubnet
=== PAUSE TestAccVPCBlockPublicAccessExclusion_basicSubnet
=== RUN   TestAccVPCBlockPublicAccessExclusion_disappears
=== PAUSE TestAccVPCBlockPublicAccessExclusion_disappears
=== RUN   TestAccVPCBlockPublicAccessExclusion_update
=== PAUSE TestAccVPCBlockPublicAccessExclusion_update
=== CONT  TestAccVPCBlockPublicAccessExclusion_tags
=== CONT  TestAccVPCBlockPublicAccessExclusion_tags_DefaultTags_emptyProviderOnlyTag
=== CONT  TestAccVPCBlockPublicAccessExclusion_tags_DefaultTags_providerOnly
--- PASS: TestAccVPCBlockPublicAccessExclusion_tags_DefaultTags_emptyProviderOnlyTag (471.72s)
=== CONT  TestAccVPCBlockPublicAccessExclusion_tags_EmptyTag_OnCreate
--- PASS: TestAccVPCBlockPublicAccessExclusion_tags (510.87s)
=== CONT  TestAccVPCBlockPublicAccessExclusion_tags_EmptyTag_OnUpdate_Replace
--- PASS: TestAccVPCBlockPublicAccessExclusion_tags_DefaultTags_providerOnly (524.72s)
=== CONT  TestAccVPCBlockPublicAccessExclusion_tags_EmptyTag_OnUpdate_Add
--- PASS: TestAccVPCBlockPublicAccessExclusion_tags_EmptyTag_OnCreate (224.15s)
=== CONT  TestAccVPCBlockPublicAccessExclusion_tags_DefaultTags_updateToProviderOnly
--- PASS: TestAccVPCBlockPublicAccessExclusion_tags_EmptyTag_OnUpdate_Replace (267.36s)
=== CONT  TestAccVPCBlockPublicAccessExclusion_tags_DefaultTags_emptyResourceTag
--- PASS: TestAccVPCBlockPublicAccessExclusion_tags_EmptyTag_OnUpdate_Add (261.52s)
=== CONT  TestAccVPCBlockPublicAccessExclusion_tags_DefaultTags_updateToResourceOnly
--- PASS: TestAccVPCBlockPublicAccessExclusion_tags_DefaultTags_updateToProviderOnly (261.14s)
=== CONT  TestAccVPCBlockPublicAccessExclusion_tags_DefaultTags_overlapping
--- PASS: TestAccVPCBlockPublicAccessExclusion_tags_DefaultTags_emptyResourceTag (368.64s)
=== CONT  TestAccVPCBlockPublicAccessExclusion_tags_DefaultTags_nonOverlapping
--- PASS: TestAccVPCBlockPublicAccessExclusion_tags_DefaultTags_updateToResourceOnly (390.20s)
=== CONT  TestAccVPCBlockPublicAccessExclusion_tags_IgnoreTags_Overlap_DefaultTag
--- PASS: TestAccVPCBlockPublicAccessExclusion_tags_DefaultTags_overlapping (459.94s)
=== CONT  TestAccVPCBlockPublicAccessExclusion_update
--- PASS: TestAccVPCBlockPublicAccessExclusion_tags_IgnoreTags_Overlap_DefaultTag (446.89s)
=== CONT  TestAccVPCBlockPublicAccessExclusion_disappears
--- PASS: TestAccVPCBlockPublicAccessExclusion_tags_DefaultTags_nonOverlapping (498.95s)
=== CONT  TestAccVPCBlockPublicAccessExclusion_basicSubnet
--- PASS: TestAccVPCBlockPublicAccessExclusion_update (455.83s)
=== CONT  TestAccVPCBlockPublicAccessExclusion_basicVPC
--- PASS: TestAccVPCBlockPublicAccessExclusion_disappears (258.12s)
=== CONT  TestAccVPCBlockPublicAccessExclusion_tags_IgnoreTags_Overlap_ResourceTag
--- PASS: TestAccVPCBlockPublicAccessExclusion_basicSubnet (236.38s)
=== CONT  TestAccVPCBlockPublicAccessExclusion_tags_null
--- PASS: TestAccVPCBlockPublicAccessExclusion_tags_null (187.40s)
=== CONT  TestAccVPCBlockPublicAccessExclusion_tags_ComputedTag_OnCreate
--- PASS: TestAccVPCBlockPublicAccessExclusion_tags_IgnoreTags_Overlap_ResourceTag (188.64s)
=== CONT  TestAccVPCBlockPublicAccessExclusion_tags_ComputedTag_OnUpdate_Replace
--- PASS: TestAccVPCBlockPublicAccessExclusion_basicVPC (199.22s)
=== CONT  TestAccVPCBlockPublicAccessExclusion_tags_ComputedTag_OnUpdate_Add
--- PASS: TestAccVPCBlockPublicAccessExclusion_tags_ComputedTag_OnUpdate_Replace (273.34s)
=== CONT  TestAccVPCBlockPublicAccessExclusion_tags_DefaultTags_nullNonOverlappingResourceTag
--- PASS: TestAccVPCBlockPublicAccessExclusion_tags_ComputedTag_OnUpdate_Add (272.14s)
=== CONT  TestAccVPCBlockPublicAccessExclusion_tags_DefaultTags_nullOverlappingResourceTag
--- PASS: TestAccVPCBlockPublicAccessExclusion_tags_ComputedTag_OnCreate (282.65s)
=== CONT  TestAccVPCBlockPublicAccessExclusion_tags_AddOnUpdate
--- PASS: TestAccVPCBlockPublicAccessExclusion_tags_AddOnUpdate (258.67s)
=== CONT  TestAccVPCBlockPublicAccessExclusion_tags_EmptyMap
--- PASS: TestAccVPCBlockPublicAccessExclusion_tags_DefaultTags_nullNonOverlappingResourceTag (268.08s)
--- PASS: TestAccVPCBlockPublicAccessExclusion_tags_DefaultTags_nullOverlappingResourceTag (267.48s)
--- PASS: TestAccVPCBlockPublicAccessExclusion_tags_EmptyMap (249.96s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	2866.347s
% make testacc TESTARGS='-run=TestAccVPCBlockPublicAccessOptions_serial' PKG=ec2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccVPCBlockPublicAccessOptions_serial -timeout 360m
2024/11/26 16:12:34 Initializing Terraform AWS Provider...
=== RUN   TestAccVPCBlockPublicAccessOptions_serial
=== PAUSE TestAccVPCBlockPublicAccessOptions_serial
=== CONT  TestAccVPCBlockPublicAccessOptions_serial
=== RUN   TestAccVPCBlockPublicAccessOptions_serial/basic
=== RUN   TestAccVPCBlockPublicAccessOptions_serial/update
--- PASS: TestAccVPCBlockPublicAccessOptions_serial (1250.64s)
    --- PASS: TestAccVPCBlockPublicAccessOptions_serial/basic (525.18s)
    --- PASS: TestAccVPCBlockPublicAccessOptions_serial/update (725.45s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	1255.850s

johnsonaj
johnsonaj previously approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

% make testacc TESTARGS='-run=TestAccVPCBlockPublicAccessExclusion_' PKG=ec2

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccVPCBlockPublicAccessExclusion_ -timeout 360m
2024/11/27 08:15:33 Initializing Terraform AWS Provider...
--- PASS: TestAccVPCBlockPublicAccessExclusion_disappears (516.59s)
--- PASS: TestAccVPCBlockPublicAccessExclusion_tags_EmptyMap (541.38s)
--- PASS: TestAccVPCBlockPublicAccessExclusion_basicVPC (543.84s)
--- PASS: TestAccVPCBlockPublicAccessExclusion_tags_DefaultTags_emptyResourceTag (551.19s)
--- PASS: TestAccVPCBlockPublicAccessExclusion_tags_DefaultTags_emptyProviderOnlyTag (551.29s)
--- PASS: TestAccVPCBlockPublicAccessExclusion_tags_ComputedTag_OnCreate (551.77s)
--- PASS: TestAccVPCBlockPublicAccessExclusion_basicSubnet (556.30s)
--- PASS: TestAccVPCBlockPublicAccessExclusion_tags_AddOnUpdate (561.00s)
--- PASS: TestAccVPCBlockPublicAccessExclusion_tags_EmptyTag_OnUpdate_Replace (561.02s)
--- PASS: TestAccVPCBlockPublicAccessExclusion_tags_DefaultTags_updateToResourceOnly (562.16s)
--- PASS: TestAccVPCBlockPublicAccessExclusion_tags_DefaultTags_updateToProviderOnly (562.64s)
--- PASS: TestAccVPCBlockPublicAccessExclusion_tags_ComputedTag_OnUpdate_Replace (563.37s)
--- PASS: TestAccVPCBlockPublicAccessExclusion_tags_IgnoreTags_Overlap_DefaultTag (570.21s)
--- PASS: TestAccVPCBlockPublicAccessExclusion_tags_EmptyTag_OnUpdate_Add (577.13s)
--- PASS: TestAccVPCBlockPublicAccessExclusion_tags (594.85s)
--- PASS: TestAccVPCBlockPublicAccessExclusion_tags_DefaultTags_providerOnly (609.42s)
--- PASS: TestAccVPCBlockPublicAccessExclusion_tags_EmptyTag_OnCreate (756.44s)
--- PASS: TestAccVPCBlockPublicAccessExclusion_update (782.89s)
--- PASS: TestAccVPCBlockPublicAccessExclusion_tags_DefaultTags_overlapping (937.89s)
--- PASS: TestAccVPCBlockPublicAccessExclusion_tags_IgnoreTags_Overlap_ResourceTag (937.90s)
--- PASS: TestAccVPCBlockPublicAccessExclusion_tags_DefaultTags_nullOverlappingResourceTag (461.00s)
--- PASS: TestAccVPCBlockPublicAccessExclusion_tags_null (500.44s)
--- PASS: TestAccVPCBlockPublicAccessExclusion_tags_DefaultTags_nullNonOverlappingResourceTag (470.77s)
--- PASS: TestAccVPCBlockPublicAccessExclusion_tags_ComputedTag_OnUpdate_Add (493.81s)
--- PASS: TestAccVPCBlockPublicAccessExclusion_tags_DefaultTags_nonOverlapping (693.15s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	1241.501s

@ewbankkit ewbankkit merged commit 90aea1c into hashicorp:main Nov 27, 2024
43 checks passed
@github-actions github-actions bot added this to the v5.79.0 milestone Nov 27, 2024
@ewbankkit
Copy link
Contributor

@madhavvishnubhatta Thanks for the contribution 🎉 👏.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnsonaj johnsonaj johnsonaj approved these changes

@ewbankkit ewbankkit ewbankkit left review comments

@breathingdust breathingdust Awaiting requested review from breathingdust

@justinretzolk justinretzolk Awaiting requested review from justinretzolk

Assignees

@ewbankkit ewbankkit

Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. github_actions Pull requests that update Github_actions code new-resource Introduces a new resource. partner Contribution from a partner. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. service/vpc Issues and PRs that pertain to the vpc service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.79.0
Development

Successfully merging this pull request may close these issues.

[New Resource]: Support for VPC Block Public Access
3 participants
@madhavvishnubhatta @ewbankkit @johnsonaj