Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_eks_cluster: Add support for EKS Hybrid nodes #40371

Merged
merged 12 commits into from
Dec 2, 2024

Conversation

bryantbiggs
Copy link
Contributor

@bryantbiggs bryantbiggs commented Dec 1, 2024

Description

  • Add support for EKS Hybrid nodes

⚠️ Requires #40380

Relations

Closes #40372.

References

Output from Acceptance Testing

make testacc PKG=eks TESTS=TestAccEKSCluster_RemoteNetwork_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/eks/... -v -count 1 -parallel 20 -run='TestAccEKSCluster_RemoteNetwork_'  -timeout 360m
2024/11/29 16:49:46 Initializing Terraform AWS Provider...
=== RUN   TestAccEKSCluster_RemoteNetwork_Node
=== PAUSE TestAccEKSCluster_RemoteNetwork_Node
=== RUN   TestAccEKSCluster_RemoteNetwork_Pod
=== PAUSE TestAccEKSCluster_RemoteNetwork_Pod
=== CONT  TestAccEKSCluster_RemoteNetwork_Node
=== CONT  TestAccEKSCluster_RemoteNetwork_Pod
--- PASS: TestAccEKSCluster_RemoteNetwork_Node (673.12s)
--- PASS: TestAccEKSCluster_RemoteNetwork_Pod (916.39s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/eks	923.312s
make testacc PKG=eks TESTS=TestAccEKSClusterDataSource_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/eks/... -v -count 1 -parallel 20 -run='TestAccEKSClusterDataSource_'  -timeout 360m
2024/11/29 17:28:38 Initializing Terraform AWS Provider...
=== RUN   TestAccEKSClusterDataSource_basic
=== PAUSE TestAccEKSClusterDataSource_basic
=== RUN   TestAccEKSClusterDataSource_outpost
=== PAUSE TestAccEKSClusterDataSource_outpost
=== RUN   TestAccEKSClusterDataSource_remoteNetwork
=== PAUSE TestAccEKSClusterDataSource_remoteNetwork
=== CONT  TestAccEKSClusterDataSource_basic
=== CONT  TestAccEKSClusterDataSource_remoteNetwork
=== CONT  TestAccEKSClusterDataSource_outpost
    cluster_data_source_test.go:79: skipping since no Outposts found
--- SKIP: TestAccEKSClusterDataSource_outpost (0.92s)
--- PASS: TestAccEKSClusterDataSource_basic (566.37s)
--- PASS: TestAccEKSClusterDataSource_remoteNetwork (582.80s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/eks

Copy link

github-actions bot commented Dec 1, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/eks Issues and PRs that pertain to the eks service. needs-triage Waiting for first response or review from a maintainer. partner Contribution from a partner. labels Dec 1, 2024
@bryantbiggs bryantbiggs force-pushed the feat/eks-hybrid-nodes branch from 139f510 to d42a31e Compare December 1, 2024 21:14
@bryantbiggs bryantbiggs force-pushed the feat/eks-hybrid-nodes branch from d42a31e to ef49bb1 Compare December 2, 2024 15:41
@bryantbiggs bryantbiggs marked this pull request as ready for review December 2, 2024 15:41
@bryantbiggs bryantbiggs requested a review from a team as a code owner December 2, 2024 15:41
@gdavison gdavison self-assigned this Dec 2, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Dec 2, 2024
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed a comment when reviewing

website/docs/r/eks_cluster.html.markdown Outdated Show resolved Hide resolved
bryantbiggs and others added 2 commits December 2, 2024 12:24
Co-authored-by: Graham Davison <g.m.davison@computer.org>
@bryantbiggs
Copy link
Contributor Author

make testacc PKG=eks TESTS=TestAccEKSCluster_RemoteNetwork_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/eks/... -v -count 1 -parallel 20 -run='TestAccEKSCluster_RemoteNetwork_'  -timeout 360m
2024/12/02 12:06:54 Initializing Terraform AWS Provider...
=== RUN   TestAccEKSCluster_RemoteNetwork_Node
=== PAUSE TestAccEKSCluster_RemoteNetwork_Node
=== RUN   TestAccEKSCluster_RemoteNetwork_Pod
=== PAUSE TestAccEKSCluster_RemoteNetwork_Pod
=== CONT  TestAccEKSCluster_RemoteNetwork_Node
=== CONT  TestAccEKSCluster_RemoteNetwork_Pod
--- PASS: TestAccEKSCluster_RemoteNetwork_Node (496.33s)
--- PASS: TestAccEKSCluster_RemoteNetwork_Pod (678.89s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/eks	686.739s
make testacc PKG=eks TESTS=TestAccEKSClusterDataSource_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/eks/... -v -count 1 -parallel 20 -run='TestAccEKSClusterDataSource_'  -timeout 360m
2024/12/02 12:27:53 Initializing Terraform AWS Provider...
=== RUN   TestAccEKSClusterDataSource_basic
=== PAUSE TestAccEKSClusterDataSource_basic
=== RUN   TestAccEKSClusterDataSource_outpost
=== PAUSE TestAccEKSClusterDataSource_outpost
=== RUN   TestAccEKSClusterDataSource_remoteNetwork
=== PAUSE TestAccEKSClusterDataSource_remoteNetwork
=== CONT  TestAccEKSClusterDataSource_basic
=== CONT  TestAccEKSClusterDataSource_remoteNetwork
=== CONT  TestAccEKSClusterDataSource_outpost
    cluster_data_source_test.go:79: skipping since no Outposts found
--- SKIP: TestAccEKSClusterDataSource_outpost (0.90s)
--- PASS: TestAccEKSClusterDataSource_remoteNetwork (630.20s)
--- PASS: TestAccEKSClusterDataSource_basic (655.89s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/eks	661.333s

Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚀

--- PASS: TestAccEKSCluster_BootstrapSelfManagedAddons_migrate (563.36s)
--- PASS: TestAccEKSCluster_zonalShiftConfig (580.70s)
--- PASS: TestAccEKSCluster_tags (622.03s)
--- PASS: TestAccEKSClusterDataSource_basic (635.57s)
--- PASS: TestAccEKSCluster_RemoteNetwork_Node (637.44s)
--- PASS: TestAccEKSCluster_RemoteNetwork_Pod (651.74s)
--- PASS: TestAccEKSCluster_Encryption_create (656.18s)
--- PASS: TestAccEKSCluster_upgradePolicy (658.09s)
--- PASS: TestAccEKSClusterDataSource_remoteNetwork (667.40s)
--- PASS: TestAccEKSCluster_basic (701.18s)
--- PASS: TestAccEKSCluster_AccessConfig_update (703.71s)
--- PASS: TestAccEKSCluster_disappears (710.53s)
--- PASS: TestAccEKSCluster_logging (732.94s)
--- PASS: TestAccEKSCluster_AccessConfig_create (733.60s)
--- PASS: TestAccEKSCluster_VPC_securityGroupIDs (496.29s)
--- PASS: TestAccEKSCluster_VPC_endpointPublicAccess (1172.23s)
--- PASS: TestAccEKSCluster_Encryption_versionUpdate (1194.02s)
--- PASS: TestAccEKSCluster_Network_ipFamily (1204.70s)
--- PASS: TestAccEKSCluster_BootstrapSelfManagedAddons_update (1253.80s)
--- PASS: TestAccEKSCluster_version (1297.37s)
--- PASS: TestAccEKSCluster_VPC_publicAccessCIDRs (801.51s)
--- PASS: TestAccEKSCluster_Encryption_update (1557.97s)
--- PASS: TestAccEKSCluster_Network_serviceIPv4CIDR (1199.98s)
--- PASS: TestAccEKSCluster_VPC_endpointPrivateAccess (1400.00s)
--- PASS: TestAccEKSCluster_VPC_securityGroupIDsAndSubnetIDs_update (1428.91s)

@gdavison gdavison merged commit b1f44a7 into hashicorp:main Dec 2, 2024
41 checks passed
@github-actions github-actions bot removed the needs-triage Waiting for first response or review from a maintainer. label Dec 2, 2024
@github-actions github-actions bot added this to the v5.79.0 milestone Dec 2, 2024
@bryantbiggs bryantbiggs deleted the feat/eks-hybrid-nodes branch December 2, 2024 21:49
Copy link

github-actions bot commented Dec 3, 2024

This functionality has been released in v5.79.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Dec 3, 2024
Copy link

github-actions bot commented Jan 3, 2025

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. partner Contribution from a partner. service/eks Issues and PRs that pertain to the eks service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Amazon EKS Hybrid Nodes
2 participants