-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/aws_eks_cluster: Add support for EKS Hybrid nodes #40371
Conversation
Community NoteVoting for Prioritization
For Submitters
|
139f510
to
d42a31e
Compare
…anges to be made on new cluster
Co-authored-by: Graham Davison <gdavison@hashicorp.com>
Co-authored-by: Graham Davison <gdavison@hashicorp.com>
d42a31e
to
ef49bb1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed a comment when reviewing
Co-authored-by: Graham Davison <g.m.davison@computer.org>
make testacc PKG=eks TESTS=TestAccEKSCluster_RemoteNetwork_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/eks/... -v -count 1 -parallel 20 -run='TestAccEKSCluster_RemoteNetwork_' -timeout 360m
2024/12/02 12:06:54 Initializing Terraform AWS Provider...
=== RUN TestAccEKSCluster_RemoteNetwork_Node
=== PAUSE TestAccEKSCluster_RemoteNetwork_Node
=== RUN TestAccEKSCluster_RemoteNetwork_Pod
=== PAUSE TestAccEKSCluster_RemoteNetwork_Pod
=== CONT TestAccEKSCluster_RemoteNetwork_Node
=== CONT TestAccEKSCluster_RemoteNetwork_Pod
--- PASS: TestAccEKSCluster_RemoteNetwork_Node (496.33s)
--- PASS: TestAccEKSCluster_RemoteNetwork_Pod (678.89s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/eks 686.739s make testacc PKG=eks TESTS=TestAccEKSClusterDataSource_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/eks/... -v -count 1 -parallel 20 -run='TestAccEKSClusterDataSource_' -timeout 360m
2024/12/02 12:27:53 Initializing Terraform AWS Provider...
=== RUN TestAccEKSClusterDataSource_basic
=== PAUSE TestAccEKSClusterDataSource_basic
=== RUN TestAccEKSClusterDataSource_outpost
=== PAUSE TestAccEKSClusterDataSource_outpost
=== RUN TestAccEKSClusterDataSource_remoteNetwork
=== PAUSE TestAccEKSClusterDataSource_remoteNetwork
=== CONT TestAccEKSClusterDataSource_basic
=== CONT TestAccEKSClusterDataSource_remoteNetwork
=== CONT TestAccEKSClusterDataSource_outpost
cluster_data_source_test.go:79: skipping since no Outposts found
--- SKIP: TestAccEKSClusterDataSource_outpost (0.90s)
--- PASS: TestAccEKSClusterDataSource_remoteNetwork (630.20s)
--- PASS: TestAccEKSClusterDataSource_basic (655.89s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/eks 661.333s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 🚀
--- PASS: TestAccEKSCluster_BootstrapSelfManagedAddons_migrate (563.36s)
--- PASS: TestAccEKSCluster_zonalShiftConfig (580.70s)
--- PASS: TestAccEKSCluster_tags (622.03s)
--- PASS: TestAccEKSClusterDataSource_basic (635.57s)
--- PASS: TestAccEKSCluster_RemoteNetwork_Node (637.44s)
--- PASS: TestAccEKSCluster_RemoteNetwork_Pod (651.74s)
--- PASS: TestAccEKSCluster_Encryption_create (656.18s)
--- PASS: TestAccEKSCluster_upgradePolicy (658.09s)
--- PASS: TestAccEKSClusterDataSource_remoteNetwork (667.40s)
--- PASS: TestAccEKSCluster_basic (701.18s)
--- PASS: TestAccEKSCluster_AccessConfig_update (703.71s)
--- PASS: TestAccEKSCluster_disappears (710.53s)
--- PASS: TestAccEKSCluster_logging (732.94s)
--- PASS: TestAccEKSCluster_AccessConfig_create (733.60s)
--- PASS: TestAccEKSCluster_VPC_securityGroupIDs (496.29s)
--- PASS: TestAccEKSCluster_VPC_endpointPublicAccess (1172.23s)
--- PASS: TestAccEKSCluster_Encryption_versionUpdate (1194.02s)
--- PASS: TestAccEKSCluster_Network_ipFamily (1204.70s)
--- PASS: TestAccEKSCluster_BootstrapSelfManagedAddons_update (1253.80s)
--- PASS: TestAccEKSCluster_version (1297.37s)
--- PASS: TestAccEKSCluster_VPC_publicAccessCIDRs (801.51s)
--- PASS: TestAccEKSCluster_Encryption_update (1557.97s)
--- PASS: TestAccEKSCluster_Network_serviceIPv4CIDR (1199.98s)
--- PASS: TestAccEKSCluster_VPC_endpointPrivateAccess (1400.00s)
--- PASS: TestAccEKSCluster_VPC_securityGroupIDsAndSubnetIDs_update (1428.91s)
This functionality has been released in v5.79.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Relations
Closes #40372.
References
Output from Acceptance Testing