Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Updated aurora serverless v2 min capacity to allow zero ACU #40427

Conversation

garym-krrv
Copy link

@garym-krrv garym-krrv commented Dec 4, 2024

Description

Relations

Closes #40421

References

This configuration is valid with the new release of Serverless v2
https://aws.amazon.com/blogs/database/introducing-scaling-to-0-capacity-with-amazon-aurora-serverless-v2/

Output from Acceptance Testing

@garym-krrv garym-krrv requested a review from a team as a code owner December 4, 2024 00:38
Copy link

github-actions bot commented Dec 4, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/rds Issues and PRs that pertain to the rds service. needs-triage Waiting for first response or review from a maintainer. labels Dec 4, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @garym-krrv 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Dec 4, 2024
@garym-krrv garym-krrv changed the title Updated aurora serverless v2 min capacity to allow zero ACU fix: Updated aurora serverless v2 min capacity to allow zero ACU Dec 4, 2024
@garym-krrv garym-krrv changed the title fix: Updated aurora serverless v2 min capacity to allow zero ACU fix Updated aurora serverless v2 min capacity to allow zero ACU Dec 4, 2024
@callumthomson
Copy link

Duplicate of #40230

Also as @markbaird mentioned in #40226, additional work is required to complete the new serverless v2 scale to zero functionality:

There's also a new setting that goes along with this feature, similar to the Serverless v1 setting, named SecondsUntilAutoPause in the API. It is in the ServerlessV2ScalingConfiguration block along with the MinCapacity and MaxCapacity settings.

@garym-krrv
Copy link
Author

Duplicate of #40230

Also as @markbaird mentioned in #40226, additional work is required to complete the new serverless v2 scale to zero functionality:

There's also a new setting that goes along with this feature, similar to the Serverless v1 setting, named SecondsUntilAutoPause in the API. It is in the ServerlessV2ScalingConfiguration block along with the MinCapacity and MaxCapacity settings.

Your right.. I will cancel this PR

@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Dec 4, 2024
Copy link

github-actions bot commented Jan 4, 2025

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/rds Issues and PRs that pertain to the rds service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: serverlessv2_scaling_configuration doesnt support 0 ACU
3 participants