Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/api_gateway_domain_name_access_association - new resource #40566

Merged
merged 11 commits into from
Dec 17, 2024
Merged

r/api_gateway_domain_name_access_association - new resource #40566

merged 11 commits into from
Dec 17, 2024

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Dec 13, 2024 •
edited
Loading

Description

Relations

Closes #40274
Relates #40364
Relates #40447

References

Output from Acceptance Testing

% make testacc TESTS=TestAccAPIGatewayDomainNameAccessAssociation_ PKG=apigateway

--- PASS: TestAccAPIGatewayDomainNameAccessAssociation_basic (157.58s)

@DrFaust92
domain name access association
4b5ff9f 
Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/apigateway Issues and PRs that pertain to the apigateway service. generators Relates to code generators. needs-triage Waiting for first response or review from a maintainer. external-maintainer Contribution from a trusted external contributor. labels Dec 13, 2024
@DrFaust92 DrFaust92 added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 13, 2024
@DrFaust92
changelog
2ca7476 
Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
@DrFaust92
docs
ffde65f 
Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
@DrFaust92 DrFaust92 marked this pull request as ready for review December 13, 2024 23:41
@DrFaust92 DrFaust92 requested a review from a team as a code owner December 13, 2024 23:41
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Dec 13, 2024
@ewbankkit ewbankkit self-assigned this Dec 15, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Dec 15, 2024
@ewbankkit
Merge branch 'main' into HEAD
f294261
@ewbankkit
r/aws_api_gateway_domain_name: No 'domain_name_arn' attribute -- corr…
eb0ca1c 
…ect 'arn' for private custom domain names.
@ewbankkit
Generate 'getDomainNameAccessAssociationsPages'.
248f1ab
@ewbankkit
'findDomainNameAccessAssociationByID' -> 'findDomainNameAccessAssocia…
2ec3acc 
…tionByARN'.
@ewbankkit
Fixup 'testAccDomainNameAccessAssociationConfig_basic'.
122409a
@ewbankkit
Acceptance test output:
39843eb 
% make testacc TESTARGS='-run=TestAccAPIGatewayDomainNameAccessAssociation_' PKG=apigateway ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/apigateway/... -v -count 1 -parallel 3  -run=TestAccAPIGatewayDomainNameAccessAssociation_ -timeout 360m
2024/12/16 17:46:34 Initializing Terraform AWS Provider...
=== RUN   TestAccAPIGatewayDomainNameAccessAssociation_tags
=== PAUSE TestAccAPIGatewayDomainNameAccessAssociation_tags
=== RUN   TestAccAPIGatewayDomainNameAccessAssociation_tags_null
=== PAUSE TestAccAPIGatewayDomainNameAccessAssociation_tags_null
=== RUN   TestAccAPIGatewayDomainNameAccessAssociation_tags_EmptyMap
=== PAUSE TestAccAPIGatewayDomainNameAccessAssociation_tags_EmptyMap
=== RUN   TestAccAPIGatewayDomainNameAccessAssociation_tags_AddOnUpdate
=== PAUSE TestAccAPIGatewayDomainNameAccessAssociation_tags_AddOnUpdate
=== RUN   TestAccAPIGatewayDomainNameAccessAssociation_tags_EmptyTag_OnCreate
=== PAUSE TestAccAPIGatewayDomainNameAccessAssociation_tags_EmptyTag_OnCreate
=== RUN   TestAccAPIGatewayDomainNameAccessAssociation_tags_EmptyTag_OnUpdate_Add
=== PAUSE TestAccAPIGatewayDomainNameAccessAssociation_tags_EmptyTag_OnUpdate_Add
=== RUN   TestAccAPIGatewayDomainNameAccessAssociation_tags_EmptyTag_OnUpdate_Replace
=== PAUSE TestAccAPIGatewayDomainNameAccessAssociation_tags_EmptyTag_OnUpdate_Replace
=== RUN   TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_providerOnly
=== PAUSE TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_providerOnly
=== RUN   TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_nonOverlapping
=== RUN   TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_overlapping
=== PAUSE TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_overlapping
=== RUN   TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_updateToProviderOnly
=== PAUSE TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_updateToProviderOnly
=== RUN   TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_updateToResourceOnly
=== PAUSE TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_updateToResourceOnly
=== RUN   TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_emptyResourceTag
=== PAUSE TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_emptyResourceTag
=== RUN   TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_emptyProviderOnlyTag
=== PAUSE TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_emptyProviderOnlyTag
=== RUN   TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_nullOverlappingResourceTag
=== PAUSE TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_nullOverlappingResourceTag
=== RUN   TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_nullNonOverlappingResourceTag
=== PAUSE TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_nullNonOverlappingResourceTag
=== RUN   TestAccAPIGatewayDomainNameAccessAssociation_tags_ComputedTag_OnCreate
=== PAUSE TestAccAPIGatewayDomainNameAccessAssociation_tags_ComputedTag_OnCreate
=== RUN   TestAccAPIGatewayDomainNameAccessAssociation_tags_ComputedTag_OnUpdate_Add
=== PAUSE TestAccAPIGatewayDomainNameAccessAssociation_tags_ComputedTag_OnUpdate_Add
=== RUN   TestAccAPIGatewayDomainNameAccessAssociation_tags_ComputedTag_OnUpdate_Replace
=== PAUSE TestAccAPIGatewayDomainNameAccessAssociation_tags_ComputedTag_OnUpdate_Replace
=== RUN   TestAccAPIGatewayDomainNameAccessAssociation_tags_IgnoreTags_Overlap_DefaultTag
=== PAUSE TestAccAPIGatewayDomainNameAccessAssociation_tags_IgnoreTags_Overlap_DefaultTag
=== RUN   TestAccAPIGatewayDomainNameAccessAssociation_tags_IgnoreTags_Overlap_ResourceTag
=== PAUSE TestAccAPIGatewayDomainNameAccessAssociation_tags_IgnoreTags_Overlap_ResourceTag
=== RUN   TestAccAPIGatewayDomainNameAccessAssociation_basic
=== PAUSE TestAccAPIGatewayDomainNameAccessAssociation_basic
=== RUN   TestAccAPIGatewayDomainNameAccessAssociation_disappears
=== PAUSE TestAccAPIGatewayDomainNameAccessAssociation_disappears
=== CONT  TestAccAPIGatewayDomainNameAccessAssociation_tags
=== CONT  TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_emptyResourceTag
=== CONT  TestAccAPIGatewayDomainNameAccessAssociation_tags_ComputedTag_OnUpdate_Replace
--- PASS: TestAccAPIGatewayDomainNameAccessAssociation_tags_ComputedTag_OnUpdate_Replace (155.42s)
=== CONT  TestAccAPIGatewayDomainNameAccessAssociation_basic
--- PASS: TestAccAPIGatewayDomainNameAccessAssociation_tags (236.75s)
=== CONT  TestAccAPIGatewayDomainNameAccessAssociation_disappears
--- PASS: TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_emptyResourceTag (236.76s)
=== CONT  TestAccAPIGatewayDomainNameAccessAssociation_tags_EmptyTag_OnUpdate_Replace
--- PASS: TestAccAPIGatewayDomainNameAccessAssociation_basic (98.29s)
=== CONT  TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_updateToResourceOnly
--- PASS: TestAccAPIGatewayDomainNameAccessAssociation_disappears (124.21s)
=== CONT  TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_updateToProviderOnly
--- PASS: TestAccAPIGatewayDomainNameAccessAssociation_tags_EmptyTag_OnUpdate_Replace (146.97s)
=== CONT  TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_overlapping
--- PASS: TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_updateToResourceOnly (248.23s)
=== CONT  TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_nonOverlapping
--- PASS: TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_updateToProviderOnly (146.23s)
=== CONT  TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_providerOnly
--- PASS: TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_overlapping (225.04s)
=== CONT  TestAccAPIGatewayDomainNameAccessAssociation_tags_IgnoreTags_Overlap_ResourceTag
--- PASS: TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_nonOverlapping (165.59s)
=== CONT  TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_nullNonOverlappingResourceTag
--- PASS: TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_providerOnly (207.34s)
=== CONT  TestAccAPIGatewayDomainNameAccessAssociation_tags_ComputedTag_OnUpdate_Add
--- PASS: TestAccAPIGatewayDomainNameAccessAssociation_tags_IgnoreTags_Overlap_ResourceTag (164.73s)
=== CONT  TestAccAPIGatewayDomainNameAccessAssociation_tags_ComputedTag_OnCreate
--- PASS: TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_nullNonOverlappingResourceTag (159.31s)
=== CONT  TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_nullOverlappingResourceTag
--- PASS: TestAccAPIGatewayDomainNameAccessAssociation_tags_ComputedTag_OnUpdate_Add (164.12s)
=== CONT  TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_emptyProviderOnlyTag
--- PASS: TestAccAPIGatewayDomainNameAccessAssociation_tags_ComputedTag_OnCreate (161.14s)
=== CONT  TestAccAPIGatewayDomainNameAccessAssociation_tags_AddOnUpdate
--- PASS: TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_nullOverlappingResourceTag (158.69s)
=== CONT  TestAccAPIGatewayDomainNameAccessAssociation_tags_EmptyTag_OnUpdate_Add
--- PASS: TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_emptyProviderOnlyTag (159.16s)
=== CONT  TestAccAPIGatewayDomainNameAccessAssociation_tags_EmptyTag_OnCreate
--- PASS: TestAccAPIGatewayDomainNameAccessAssociation_tags_AddOnUpdate (145.09s)
=== CONT  TestAccAPIGatewayDomainNameAccessAssociation_tags_IgnoreTags_Overlap_DefaultTag
--- PASS: TestAccAPIGatewayDomainNameAccessAssociation_tags_EmptyTag_OnUpdate_Add (136.54s)
=== CONT  TestAccAPIGatewayDomainNameAccessAssociation_tags_EmptyMap
--- PASS: TestAccAPIGatewayDomainNameAccessAssociation_tags_EmptyTag_OnCreate (124.86s)
=== CONT  TestAccAPIGatewayDomainNameAccessAssociation_tags_null
--- PASS: TestAccAPIGatewayDomainNameAccessAssociation_tags_IgnoreTags_Overlap_DefaultTag (147.56s)
--- PASS: TestAccAPIGatewayDomainNameAccessAssociation_tags_EmptyMap (115.36s)
--- PASS: TestAccAPIGatewayDomainNameAccessAssociation_tags_null (104.34s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/apigateway	1273.788s
@ewbankkit
r/aws_api_gateway_domain_name_access_association: Migrate to Terrafor…
072376d 
…m Plugin Framework.
ewbankkit
ewbankkit previously approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccAPIGatewayDomainNameAccessAssociation_' PKG=apigateway ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/apigateway/... -v -count 1 -parallel 3  -run=TestAccAPIGatewayDomainNameAccessAssociation_ -timeout 360m
2024/12/17 08:45:26 Initializing Terraform AWS Provider...
=== RUN   TestAccAPIGatewayDomainNameAccessAssociation_tags
=== PAUSE TestAccAPIGatewayDomainNameAccessAssociation_tags
=== RUN   TestAccAPIGatewayDomainNameAccessAssociation_tags_null
=== PAUSE TestAccAPIGatewayDomainNameAccessAssociation_tags_null
=== RUN   TestAccAPIGatewayDomainNameAccessAssociation_tags_EmptyMap
=== PAUSE TestAccAPIGatewayDomainNameAccessAssociation_tags_EmptyMap
=== RUN   TestAccAPIGatewayDomainNameAccessAssociation_tags_AddOnUpdate
=== PAUSE TestAccAPIGatewayDomainNameAccessAssociation_tags_AddOnUpdate
=== RUN   TestAccAPIGatewayDomainNameAccessAssociation_tags_EmptyTag_OnCreate
=== PAUSE TestAccAPIGatewayDomainNameAccessAssociation_tags_EmptyTag_OnCreate
=== RUN   TestAccAPIGatewayDomainNameAccessAssociation_tags_EmptyTag_OnUpdate_Add
=== PAUSE TestAccAPIGatewayDomainNameAccessAssociation_tags_EmptyTag_OnUpdate_Add
=== RUN   TestAccAPIGatewayDomainNameAccessAssociation_tags_EmptyTag_OnUpdate_Replace
=== PAUSE TestAccAPIGatewayDomainNameAccessAssociation_tags_EmptyTag_OnUpdate_Replace
=== RUN   TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_providerOnly
=== PAUSE TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_providerOnly
=== RUN   TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_nonOverlapping
=== RUN   TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_overlapping
=== PAUSE TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_overlapping
=== RUN   TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_updateToProviderOnly
=== PAUSE TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_updateToProviderOnly
=== RUN   TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_updateToResourceOnly
=== PAUSE TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_updateToResourceOnly
=== RUN   TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_emptyResourceTag
=== PAUSE TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_emptyResourceTag
=== RUN   TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_emptyProviderOnlyTag
=== PAUSE TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_emptyProviderOnlyTag
=== RUN   TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_nullOverlappingResourceTag
=== PAUSE TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_nullOverlappingResourceTag
=== RUN   TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_nullNonOverlappingResourceTag
=== PAUSE TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_nullNonOverlappingResourceTag
=== RUN   TestAccAPIGatewayDomainNameAccessAssociation_tags_ComputedTag_OnCreate
=== PAUSE TestAccAPIGatewayDomainNameAccessAssociation_tags_ComputedTag_OnCreate
=== RUN   TestAccAPIGatewayDomainNameAccessAssociation_tags_ComputedTag_OnUpdate_Add
=== PAUSE TestAccAPIGatewayDomainNameAccessAssociation_tags_ComputedTag_OnUpdate_Add
=== RUN   TestAccAPIGatewayDomainNameAccessAssociation_tags_ComputedTag_OnUpdate_Replace
=== PAUSE TestAccAPIGatewayDomainNameAccessAssociation_tags_ComputedTag_OnUpdate_Replace
=== RUN   TestAccAPIGatewayDomainNameAccessAssociation_tags_IgnoreTags_Overlap_DefaultTag
=== PAUSE TestAccAPIGatewayDomainNameAccessAssociation_tags_IgnoreTags_Overlap_DefaultTag
=== RUN   TestAccAPIGatewayDomainNameAccessAssociation_tags_IgnoreTags_Overlap_ResourceTag
=== PAUSE TestAccAPIGatewayDomainNameAccessAssociation_tags_IgnoreTags_Overlap_ResourceTag
=== RUN   TestAccAPIGatewayDomainNameAccessAssociation_basic
=== PAUSE TestAccAPIGatewayDomainNameAccessAssociation_basic
=== RUN   TestAccAPIGatewayDomainNameAccessAssociation_disappears
=== PAUSE TestAccAPIGatewayDomainNameAccessAssociation_disappears
=== CONT  TestAccAPIGatewayDomainNameAccessAssociation_tags
=== CONT  TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_emptyResourceTag
=== CONT  TestAccAPIGatewayDomainNameAccessAssociation_tags_EmptyTag_OnUpdate_Replace
--- PASS: TestAccAPIGatewayDomainNameAccessAssociation_tags_EmptyTag_OnUpdate_Replace (129.85s)
=== CONT  TestAccAPIGatewayDomainNameAccessAssociation_tags_ComputedTag_OnUpdate_Replace
--- PASS: TestAccAPIGatewayDomainNameAccessAssociation_tags (227.14s)
=== CONT  TestAccAPIGatewayDomainNameAccessAssociation_disappears
--- PASS: TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_emptyResourceTag (230.04s)
=== CONT  TestAccAPIGatewayDomainNameAccessAssociation_basic
--- PASS: TestAccAPIGatewayDomainNameAccessAssociation_tags_ComputedTag_OnUpdate_Replace (164.03s)
=== CONT  TestAccAPIGatewayDomainNameAccessAssociation_tags_IgnoreTags_Overlap_ResourceTag
--- PASS: TestAccAPIGatewayDomainNameAccessAssociation_basic (128.38s)
=== CONT  TestAccAPIGatewayDomainNameAccessAssociation_tags_IgnoreTags_Overlap_DefaultTag
--- PASS: TestAccAPIGatewayDomainNameAccessAssociation_tags_IgnoreTags_Overlap_ResourceTag (151.62s)
=== CONT  TestAccAPIGatewayDomainNameAccessAssociation_tags_AddOnUpdate
--- PASS: TestAccAPIGatewayDomainNameAccessAssociation_tags_IgnoreTags_Overlap_DefaultTag (167.95s)
=== CONT  TestAccAPIGatewayDomainNameAccessAssociation_tags_EmptyTag_OnUpdate_Add
--- PASS: TestAccAPIGatewayDomainNameAccessAssociation_disappears (302.49s)
=== CONT  TestAccAPIGatewayDomainNameAccessAssociation_tags_EmptyTag_OnCreate
--- PASS: TestAccAPIGatewayDomainNameAccessAssociation_tags_AddOnUpdate (171.38s)
=== CONT  TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_nullNonOverlappingResourceTag
--- PASS: TestAccAPIGatewayDomainNameAccessAssociation_tags_EmptyTag_OnCreate (162.90s)
=== CONT  TestAccAPIGatewayDomainNameAccessAssociation_tags_ComputedTag_OnUpdate_Add
--- PASS: TestAccAPIGatewayDomainNameAccessAssociation_tags_EmptyTag_OnUpdate_Add (190.23s)
=== CONT  TestAccAPIGatewayDomainNameAccessAssociation_tags_ComputedTag_OnCreate
--- PASS: TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_nullNonOverlappingResourceTag (130.63s)
=== CONT  TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_overlapping
=== CONT  TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_updateToResourceOnly
--- PASS: TestAccAPIGatewayDomainNameAccessAssociation_tags_ComputedTag_OnUpdate_Add (134.65s)
--- PASS: TestAccAPIGatewayDomainNameAccessAssociation_tags_ComputedTag_OnCreate (130.09s)
=== CONT  TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_updateToProviderOnly
--- PASS: TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_overlapping (182.01s)
=== CONT  TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_nonOverlapping
--- PASS: TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_updateToResourceOnly (146.38s)
=== CONT  TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_nullOverlappingResourceTag
--- PASS: TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_updateToProviderOnly (146.55s)
=== CONT  TestAccAPIGatewayDomainNameAccessAssociation_tags_EmptyMap
--- PASS: TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_nonOverlapping (145.81s)
=== CONT  TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_emptyProviderOnlyTag
--- PASS: TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_nullOverlappingResourceTag (137.35s)
=== CONT  TestAccAPIGatewayDomainNameAccessAssociation_tags_null
--- PASS: TestAccAPIGatewayDomainNameAccessAssociation_tags_EmptyMap (180.63s)
=== CONT  TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_providerOnly
--- PASS: TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_emptyProviderOnlyTag (130.39s)
--- PASS: TestAccAPIGatewayDomainNameAccessAssociation_tags_null (96.95s)
--- PASS: TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_providerOnly (140.01s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/apigateway	1320.571s

@ewbankkit
Copy link
Contributor

@DrFaust92 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 94b71ea into hashicorp:main Dec 17, 2024
43 checks passed
@github-actions github-actions bot added this to the v5.82.0 milestone Dec 17, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Dec 19, 2024
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.82.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YakDriver YakDriver YakDriver approved these changes

@ewbankkit ewbankkit ewbankkit left review comments

Assignees

@ewbankkit ewbankkit

Labels
documentation Introduces or discusses updates to documentation. external-maintainer Contribution from a trusted external contributor. generators Relates to code generators. new-resource Introduces a new resource. service/apigateway Issues and PRs that pertain to the apigateway service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.82.0
Development

Successfully merging this pull request may close these issues.

API Gateway custom domain names for private REST APIs
3 participants
@DrFaust92 @ewbankkit @YakDriver