Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

waf: Ensure RegexMatch predicate type is consistently supported and documented #4069

Merged
merged 1 commit into from
Apr 12, 2018
Merged

waf: Ensure RegexMatch predicate type is consistently supported and documented #4069

merged 1 commit into from
Apr 12, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Apr 5, 2018

RegexMatch was missing from:

  • aws_waf_rate_based_rule
  • aws_waf_rule
  • aws_wafregional_rate_based_rule

Reference: #4068

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. documentation Introduces or discusses updates to documentation. service/waf Issues and PRs that pertain to the waf service. labels Apr 5, 2018
@bflad bflad added this to the v1.14.0 milestone Apr 5, 2018
@ghost ghost added size/M Managed by automation to categorize the size of a PR. and removed documentation Introduces or discusses updates to documentation. labels Apr 5, 2018
@bflad bflad mentioned this pull request Apr 5, 2018
Closed
@bflad bflad requested a review from a team April 5, 2018 13:39
@kchristensen
Copy link

Looks like this didn't make it into 1.14.0 :(

@bflad bflad modified the milestones: v1.14.0, v1.15.0 Apr 6, 2018
katbyte
katbyte approved these changes Apr 12, 2018
View reviewed changes
Copy link
Contributor

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bflad bflad merged commit 1436396 into master Apr 12, 2018
@bflad bflad deleted the f-waf-predicate-type branch April 12, 2018 19:18
bflad added a commit that referenced this pull request Apr 12, 2018
@bflad
Update CHANGELOG for #4069
14170e3
@bflad
Copy link
Contributor Author

bflad commented Apr 18, 2018

This has been released in version 1.15.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 6, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/waf Issues and PRs that pertain to the waf service. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v1.15.0
Development

Successfully merging this pull request may close these issues.
3 participants
@bflad @kchristensen @katbyte