f/aws_rds_cluster-add-enhanced-monitoring

[Dansyuqri]

Description

This PR adds the monitoring_interval and monitoring_role_arn input parameters to the aws_rds_cluster resource. This allows enhanced monitoring to be set at the RDS Cluster level.

Relations

Closes #40966

References

See --monitoring-interval and --monitoring-role-arn
https://docs.aws.amazon.com/cli/latest/reference/rds/modify-db-cluster.html#options

Output from Acceptance Testing

% make testacc TESTS=TestAccRDSCluster_enhancedMonitoring_enabledToDisabled PKG=rds
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSCluster_enhancedMonitoring_enabledToDisabled'  -timeout 360m
=== RUN   TestAccRDSCluster_enhancedMonitoring_enabledToDisabled
=== PAUSE TestAccRDSCluster_enhancedMonitoring_enabledToDisabled
=== CONT  TestAccRDSCluster_enhancedMonitoring_enabledToDisabled
--- PASS: TestAccRDSCluster_enhancedMonitoring_enabledToDisabled (1720.28s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/rds        1724.393s

% make testacc TESTS=TestAccRDSCluster_enhancedMonitoring_enabledToUpdatedMonitoringInterval PKG=rds
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSCluster_enhancedMonitoring_enabledToUpdatedMonitoringInterval'  -timeout 360m
=== RUN   TestAccRDSCluster_enhancedMonitoring_enabledToUpdatedMonitoringInterval
=== PAUSE TestAccRDSCluster_enhancedMonitoring_enabledToUpdatedMonitoringInterval
=== CONT  TestAccRDSCluster_enhancedMonitoring_enabledToUpdatedMonitoringInterval
--- PASS: TestAccRDSCluster_enhancedMonitoring_enabledToUpdatedMonitoringInterval (1643.39s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/rds        1647.481s

% make testacc TESTS=TestAccRDSCluster_enhancedMonitoring_disabledToEnabled PKG=rds
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSCluster_enhancedMonitoring_disabledToEnabled'  -timeout 360m
=== RUN   TestAccRDSCluster_enhancedMonitoring_disabledToEnabled
=== PAUSE TestAccRDSCluster_enhancedMonitoring_disabledToEnabled
=== CONT  TestAccRDSCluster_enhancedMonitoring_disabledToEnabled
--- PASS: TestAccRDSCluster_enhancedMonitoring_disabledToEnabled (1437.99s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/rds        1445.990s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccRDSCluster_basic\|TestAccRDSCluster_enhancedMonitoring' PKG=rds
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.5 test ./internal/service/rds/... -v -count 1 -parallel 20  -run=TestAccRDSCluster_basic\|TestAccRDSCluster_enhancedMonitoring -timeout 360m -vet=off
2025/02/05 16:26:30 Initializing Terraform AWS Provider...
=== RUN   TestAccRDSCluster_basic
=== PAUSE TestAccRDSCluster_basic
=== RUN   TestAccRDSCluster_enhancedMonitoring_enabledToUpdatedMonitoringInterval
=== PAUSE TestAccRDSCluster_enhancedMonitoring_enabledToUpdatedMonitoringInterval
=== RUN   TestAccRDSCluster_enhancedMonitoring_enabledToDisabled
=== PAUSE TestAccRDSCluster_enhancedMonitoring_enabledToDisabled
=== RUN   TestAccRDSCluster_enhancedMonitoring_disabledToEnabled
=== PAUSE TestAccRDSCluster_enhancedMonitoring_disabledToEnabled
=== CONT  TestAccRDSCluster_basic
=== CONT  TestAccRDSCluster_enhancedMonitoring_enabledToDisabled
=== CONT  TestAccRDSCluster_enhancedMonitoring_enabledToUpdatedMonitoringInterval
=== CONT  TestAccRDSCluster_enhancedMonitoring_disabledToEnabled
--- PASS: TestAccRDSCluster_basic (106.78s)
--- PASS: TestAccRDSCluster_enhancedMonitoring_enabledToDisabled (1364.67s)
--- PASS: TestAccRDSCluster_enhancedMonitoring_enabledToUpdatedMonitoringInterval (1365.37s)
--- PASS: TestAccRDSCluster_enhancedMonitoring_disabledToEnabled (1370.12s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	1375.681s

[johnsonaj]

LGTM 🚀

[ewbankkit]

@Dansyuqri Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.86.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!