Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_cloudfront_distribution: Add cache_behavior field_level_encryption_id attribute #4102

Merged
merged 2 commits into from
Apr 6, 2018
Merged

resource/aws_cloudfront_distribution: Add cache_behavior field_level_encryption_id attribute #4102

merged 2 commits into from
Apr 6, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Apr 6, 2018 •
edited
Loading

Fixes #4091 and unblocks v1.14.0 release. I have created a followup issue associated with the new field level encryption configuration resource to properly test this new attribute: #4101

Tests

11 tests passed (all tests)
=== RUN   TestAccAWSCloudFrontDistribution_Origin_EmptyDomainName
--- PASS: TestAccAWSCloudFrontDistribution_Origin_EmptyDomainName (1.53s)
=== RUN   TestAccAWSCloudFrontDistribution_Origin_EmptyOriginID
--- PASS: TestAccAWSCloudFrontDistribution_Origin_EmptyOriginID (1.55s)
=== RUN   TestAccAWSCloudFrontDistribution_importBasic
--- PASS: TestAccAWSCloudFrontDistribution_importBasic (1356.52s)
=== RUN   TestAccAWSCloudFrontDistribution_noOptionalItemsConfig
--- PASS: TestAccAWSCloudFrontDistribution_noOptionalItemsConfig (1360.24s)
=== RUN   TestAccAWSCloudFrontDistribution_IsIPV6EnabledConfig
--- PASS: TestAccAWSCloudFrontDistribution_IsIPV6EnabledConfig (1360.97s)
=== RUN   TestAccAWSCloudFrontDistribution_S3Origin
--- PASS: TestAccAWSCloudFrontDistribution_S3Origin (1361.33s)
=== RUN   TestAccAWSCloudFrontDistribution_multiOrigin
--- PASS: TestAccAWSCloudFrontDistribution_multiOrigin (1362.51s)
=== RUN   TestAccAWSCloudFrontDistribution_customOrigin
--- PASS: TestAccAWSCloudFrontDistribution_customOrigin (1362.54s)
=== RUN   TestAccAWSCloudFrontDistribution_noCustomErrorResponseConfig
--- PASS: TestAccAWSCloudFrontDistribution_noCustomErrorResponseConfig (1362.91s)
=== RUN   TestAccAWSCloudFrontDistribution_HTTP11Config
--- PASS: TestAccAWSCloudFrontDistribution_HTTP11Config (1363.86s)
=== RUN   TestAccAWSCloudFrontDistribution_S3OriginWithTags
--- PASS: TestAccAWSCloudFrontDistribution_S3OriginWithTags (1364.49s)

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/cloudfront Issues and PRs that pertain to the cloudfront service. labels Apr 6, 2018
@bflad bflad added this to the v1.14.0 milestone Apr 6, 2018
@ghost ghost added the size/M Managed by automation to categorize the size of a PR. label Apr 6, 2018
@bflad bflad mentioned this pull request Apr 6, 2018
Closed
@bflad bflad requested a review from a team April 6, 2018 16:07
tombuildsstuff
tombuildsstuff approved these changes Apr 6, 2018
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bflad bflad merged commit 6d94983 into master Apr 6, 2018
@bflad bflad deleted the f-aws_cloudfront_distribution-fieldlevelencryptionid branch April 6, 2018 17:01
bflad added a commit that referenced this pull request Apr 6, 2018
@bflad
Update CHANGELOG for #4102
470e8c2
@bflad
Copy link
Contributor Author

bflad commented Apr 6, 2018

This has been released in version 1.14.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@bflad bflad mentioned this pull request Apr 17, 2018
Merged
@ghost
Copy link

ghost commented Apr 6, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/cloudfront Issues and PRs that pertain to the cloudfront service. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v1.14.0
Development

Successfully merging this pull request may close these issues.

CloudFront Distributions Failing to Delete on master
2 participants
@bflad @tombuildsstuff