Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aws_guardduty_malware_scan_settings resource #41622

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

twelsh-aw
Copy link
Contributor

@twelsh-aw twelsh-aw commented Mar 2, 2025

Description

Adds aws_guardduty_malware_scan_settings resource. This allows configuring scan criteria (tag filtering) and volume retention policies for EC2 malware scanning.

I tried my best to make it line up with the API schema (it's a little funky), but it's not one-to-one so custom flatten/expand functions are needed

Relations

Closes #33979

References

Output from Acceptance Testing

╰─ make testacc TESTS=TestAccGuardDutyMalwareScanSettings PKG=guardduty
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.5 test ./internal/service/guardduty/... -v -count 1 -parallel 20 -run='TestAccGuardDutyMalwareScanSettings'  -timeout 360m -vet=off
2025/03/01 22:08:18 Initializing Terraform AWS Provider...
=== RUN   TestAccGuardDutyMalwareScanSettings_basic
--- PASS: TestAccGuardDutyMalwareScanSettings_basic (26.74s)
=== RUN   TestAccGuardDutyMalwareScanSettings_scanResourceCriteria
--- PASS: TestAccGuardDutyMalwareScanSettings_scanResourceCriteria (48.52s)
=== RUN   TestAccGuardDutyMalwareScanSettings_disappears
--- PASS: TestAccGuardDutyMalwareScanSettings_disappears (13.70s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/guardduty  95.355s
...

Copy link

github-actions bot commented Mar 2, 2025

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/guardduty Issues and PRs that pertain to the guardduty service. generators Relates to code generators. needs-triage Waiting for first response or review from a maintainer. labels Mar 2, 2025
@twelsh-aw twelsh-aw marked this pull request as ready for review March 2, 2025 03:23
@twelsh-aw twelsh-aw requested a review from a team as a code owner March 2, 2025 03:23
TBD if there is a better way, but this is intentional as currently setup
@ewbankkit ewbankkit added the new-resource Introduces a new resource. label Mar 3, 2025
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. generators Relates to code generators. new-resource Introduces a new resource. service/guardduty Issues and PRs that pertain to the guardduty service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Support ScanResourceCriteria for GuardDuty
3 participants