Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use update timeout value in ec2_instance_state if greater than hard-coded instanceStopTimeout or instanceStartTimeout #41642

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

redartera
Copy link

@redartera redartera commented Mar 3, 2025

Description

The update timeout isn't used when starting/stopping an EC2 instance, instead the hard-coded instanceStopTimeout and instanceStartTimeout are used. This PR uses the update timeout value if greater than either one of constant values. This is useful when dealing with large EC2 instances (e.g. p3dn.24xlarge) that take a very long time to start/stop.

@redartera redartera requested a review from a team as a code owner March 3, 2025 20:48
Copy link

github-actions bot commented Mar 3, 2025

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/ec2 Issues and PRs that pertain to the ec2 service. needs-triage Waiting for first response or review from a maintainer. labels Mar 3, 2025
@redartera redartera changed the title Merge remote-tracking branch 'origin/main' into ec2-instance-state-update-timeout Use update timeout value in ec2_instance_state if greater than hard-coded instanceStopTimeout or instanceStartTimeout Mar 3, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @redartera 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants