Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RDS Aurora Global Cluster Data Source #41669

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

theherk
Copy link
Contributor

@theherk theherk commented Mar 5, 2025

Description

Add a data source matching the resource reader for `aws_rds_global_cluster

Unfortunately, I created this before seeing that #37286 existed. However it is currently out of sync, so perhaps this is still warranted.

I did start with the latest framework type coming from skaff, but had some issues with tagging, and thought it would be better to keep consistent with the matching resource anyway, so the sdk type is used here.

Relations

Output from Acceptance Testing

ᐅ make testacc TESTS=TestAccRDSGlobalClusterDataSource PKG=rds ACCTEST_PARALLELISM=4
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.5 test ./internal/service/rds/... -v -count 1 -parallel 4 -run='TestAccRDSGlobalClusterDataSource'  -timeout 360m -vet=off
2025/03/05 14:11:27 Initializing Terraform AWS Provider...
=== RUN   TestAccRDSGlobalClusterDataSource_basic
=== PAUSE TestAccRDSGlobalClusterDataSource_basic
=== RUN   TestAccRDSGlobalClusterDataSource_withTags
=== PAUSE TestAccRDSGlobalClusterDataSource_withTags
=== CONT  TestAccRDSGlobalClusterDataSource_basic
=== CONT  TestAccRDSGlobalClusterDataSource_withTags
--- PASS: TestAccRDSGlobalClusterDataSource_basic (16.86s)
--- PASS: TestAccRDSGlobalClusterDataSource_withTags (17.51s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	22.904s

Unfortunately, I created this before seeing that hashicorp#37286 existed. However
it is currently out of sync, so perhaps this is still warranted.

I did start with the latest framework type coming from skaff, but had
some issues with tagging, and thought it would be better to keep
consistent with the matching resource anyway, so the sdk type is used
here.

References:

- hashicorp#13289
- hashicorp#20171
@theherk theherk requested a review from a team as a code owner March 5, 2025 14:36
Copy link

github-actions bot commented Mar 5, 2025

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/rds Issues and PRs that pertain to the rds service. generators Relates to code generators. needs-triage Waiting for first response or review from a maintainer. labels Mar 5, 2025
@justinretzolk justinretzolk added new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-data-source Introduces a new data source. service/rds Issues and PRs that pertain to the rds service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New data source: aws_rds_global_cluster
2 participants