Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore godebug tlskyber=0 #41740

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Restore godebug tlskyber=0 #41740

wants to merge 3 commits into from
+7 −0

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Mar 7, 2025 •
edited
Loading

Description

Restores the godebug tlskyber=0 directive in go.mod.

Relations

Closes #41732.
Closes #41731.
Relates #41655.
Relates #39432.
Relates #39256.

Output from Acceptance Testing

% make sane
make: Sane Smoke Tests (x tests of Top y resources)
make: Like 'sanity' except full output and stops soon after 1st error
make: NOTE: NOT an exhaustive set of tests! Finds big problems only.
2025/03/07 16:10:29 Initializing Terraform AWS Provider...
=== RUN   TestAccIAMInstanceProfile_tags
=== PAUSE TestAccIAMInstanceProfile_tags
=== RUN   TestAccIAMInstanceProfile_basic
=== PAUSE TestAccIAMInstanceProfile_basic
=== RUN   TestAccIAMPolicyDocumentDataSource_basic
=== PAUSE TestAccIAMPolicyDocumentDataSource_basic
=== RUN   TestAccIAMPolicyDocumentDataSource_sourceConflicting
=== PAUSE TestAccIAMPolicyDocumentDataSource_sourceConflicting
=== RUN   TestAccIAMPolicy_tags
=== PAUSE TestAccIAMPolicy_tags
=== RUN   TestAccIAMPolicy_basic
=== PAUSE TestAccIAMPolicy_basic
=== RUN   TestAccIAMPolicy_policy
=== PAUSE TestAccIAMPolicy_policy
=== RUN   TestAccIAMRolePolicyAttachment_basic
=== PAUSE TestAccIAMRolePolicyAttachment_basic
=== RUN   TestAccIAMRolePolicyAttachment_disappears
=== PAUSE TestAccIAMRolePolicyAttachment_disappears
=== RUN   TestAccIAMRolePolicyAttachment_Disappears_role
=== PAUSE TestAccIAMRolePolicyAttachment_Disappears_role
=== RUN   TestAccIAMRolePolicy_basic
=== PAUSE TestAccIAMRolePolicy_basic
=== RUN   TestAccIAMRolePolicy_unknownsInPolicy
=== PAUSE TestAccIAMRolePolicy_unknownsInPolicy
=== RUN   TestAccIAMRole_basic
=== PAUSE TestAccIAMRole_basic
=== RUN   TestAccIAMRole_namePrefix
=== PAUSE TestAccIAMRole_namePrefix
=== RUN   TestAccIAMRole_disappears
=== PAUSE TestAccIAMRole_disappears
=== RUN   TestAccIAMRole_InlinePolicy_basic
=== PAUSE TestAccIAMRole_InlinePolicy_basic
=== CONT  TestAccIAMInstanceProfile_tags
=== CONT  TestAccIAMRolePolicyAttachment_disappears
=== CONT  TestAccIAMPolicy_tags
=== CONT  TestAccIAMRole_basic
=== CONT  TestAccIAMRole_InlinePolicy_basic
=== CONT  TestAccIAMPolicy_policy
=== CONT  TestAccIAMRole_namePrefix
=== CONT  TestAccIAMPolicyDocumentDataSource_basic
=== CONT  TestAccIAMPolicyDocumentDataSource_sourceConflicting
=== CONT  TestAccIAMPolicy_basic
=== CONT  TestAccIAMRolePolicy_unknownsInPolicy
=== CONT  TestAccIAMRolePolicyAttachment_Disappears_role
=== CONT  TestAccIAMRolePolicy_basic
=== CONT  TestAccIAMRole_disappears
=== CONT  TestAccIAMRolePolicyAttachment_basic
=== CONT  TestAccIAMInstanceProfile_basic
--- PASS: TestAccIAMPolicyDocumentDataSource_basic (12.08s)
--- PASS: TestAccIAMPolicyDocumentDataSource_sourceConflicting (12.15s)
--- PASS: TestAccIAMRole_disappears (15.90s)
--- PASS: TestAccIAMRolePolicyAttachment_disappears (16.77s)
--- PASS: TestAccIAMRolePolicyAttachment_Disappears_role (16.90s)
--- PASS: TestAccIAMRole_basic (18.16s)
--- PASS: TestAccIAMPolicy_basic (18.16s)
--- PASS: TestAccIAMRole_namePrefix (18.27s)
--- PASS: TestAccIAMRolePolicy_basic (18.78s)
--- PASS: TestAccIAMRolePolicy_unknownsInPolicy (19.30s)
--- PASS: TestAccIAMInstanceProfile_basic (22.78s)
--- PASS: TestAccIAMPolicy_policy (26.25s)
--- PASS: TestAccIAMRolePolicyAttachment_basic (26.72s)
--- PASS: TestAccIAMRole_InlinePolicy_basic (33.87s)
--- PASS: TestAccIAMPolicy_tags (51.49s)
--- PASS: TestAccIAMInstanceProfile_tags (72.97s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/iam	78.883s
2025/03/07 16:12:10 Initializing Terraform AWS Provider...
=== RUN   TestAccLogsGroup_basic
=== PAUSE TestAccLogsGroup_basic
=== RUN   TestAccLogsGroup_multiple
=== PAUSE TestAccLogsGroup_multiple
=== CONT  TestAccLogsGroup_basic
=== CONT  TestAccLogsGroup_multiple
--- PASS: TestAccLogsGroup_multiple (12.01s)
--- PASS: TestAccLogsGroup_basic (15.33s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/logs	21.171s
2025/03/07 16:12:23 Initializing Terraform AWS Provider...
=== RUN   TestAccVPCDataSource_basic
=== PAUSE TestAccVPCDataSource_basic
=== RUN   TestAccVPCRouteTableAssociation_Subnet_basic
=== PAUSE TestAccVPCRouteTableAssociation_Subnet_basic
=== RUN   TestAccVPCRouteTable_basic
=== PAUSE TestAccVPCRouteTable_basic
=== RUN   TestAccVPCSecurityGroupRule_race
=== PAUSE TestAccVPCSecurityGroupRule_race
=== RUN   TestAccVPCSecurityGroupRule_protocolChange
=== PAUSE TestAccVPCSecurityGroupRule_protocolChange
=== RUN   TestAccVPCSecurityGroup_basic
=== PAUSE TestAccVPCSecurityGroup_basic
=== RUN   TestAccVPCSecurityGroup_egressMode
=== PAUSE TestAccVPCSecurityGroup_egressMode
=== RUN   TestAccVPCSecurityGroup_vpcAllEgress
=== PAUSE TestAccVPCSecurityGroup_vpcAllEgress
=== RUN   TestAccVPCSubnet_basic
=== PAUSE TestAccVPCSubnet_basic
=== RUN   TestAccVPC_tenancy
=== PAUSE TestAccVPC_tenancy
=== CONT  TestAccVPCDataSource_basic
=== CONT  TestAccVPCSecurityGroup_basic
=== CONT  TestAccVPCSecurityGroup_egressMode
=== CONT  TestAccVPCSecurityGroupRule_race
=== CONT  TestAccVPCSecurityGroupRule_protocolChange
=== CONT  TestAccVPCRouteTable_basic
=== CONT  TestAccVPCSubnet_basic
=== CONT  TestAccVPC_tenancy
=== CONT  TestAccVPCSecurityGroup_vpcAllEgress
=== CONT  TestAccVPCRouteTableAssociation_Subnet_basic
--- PASS: TestAccVPCRouteTable_basic (21.07s)
--- PASS: TestAccVPCSubnet_basic (21.15s)
--- PASS: TestAccVPCSecurityGroup_basic (23.03s)
--- PASS: TestAccVPCSecurityGroup_vpcAllEgress (23.78s)
--- PASS: TestAccVPCRouteTableAssociation_Subnet_basic (24.82s)
--- PASS: TestAccVPCDataSource_basic (30.10s)
--- PASS: TestAccVPCSecurityGroup_egressMode (43.59s)
--- PASS: TestAccVPC_tenancy (45.27s)
--- PASS: TestAccVPCSecurityGroupRule_protocolChange (51.93s)
--- PASS: TestAccVPCSecurityGroupRule_race (162.85s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	173.314s
2025/03/07 16:12:18 Initializing Terraform AWS Provider...
=== RUN   TestAccECSService_basic
=== PAUSE TestAccECSService_basic
=== RUN   TestAccECSTaskDefinition_basic
=== PAUSE TestAccECSTaskDefinition_basic
=== CONT  TestAccECSService_basic
=== CONT  TestAccECSTaskDefinition_basic
--- PASS: TestAccECSTaskDefinition_basic (22.99s)
--- PASS: TestAccECSService_basic (68.84s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecs	74.774s
2025/03/07 16:12:31 Initializing Terraform AWS Provider...
=== RUN   TestAccELBV2TargetGroup_basic
=== PAUSE TestAccELBV2TargetGroup_basic
=== CONT  TestAccELBV2TargetGroup_basic
--- PASS: TestAccELBV2TargetGroup_basic (20.09s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elbv2	38.933s
2025/03/07 16:12:27 Initializing Terraform AWS Provider...
=== RUN   TestAccKMSKey_basic
=== PAUSE TestAccKMSKey_basic
=== CONT  TestAccKMSKey_basic
--- PASS: TestAccKMSKey_basic (23.23s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kms	37.803s
2025/03/07 16:15:36 Initializing Terraform AWS Provider...
=== RUN   TestAccLambdaFunction_basic
=== PAUSE TestAccLambdaFunction_basic
=== RUN   TestAccLambdaPermission_basic
=== PAUSE TestAccLambdaPermission_basic
=== CONT  TestAccLambdaFunction_basic
=== CONT  TestAccLambdaPermission_basic
--- PASS: TestAccLambdaPermission_basic (30.68s)
--- PASS: TestAccLambdaFunction_basic (41.38s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lambda	51.555s
2025/03/07 16:15:32 Initializing Terraform AWS Provider...
=== RUN   TestAccMetaPartitionDataSource_basic
=== PAUSE TestAccMetaPartitionDataSource_basic
=== RUN   TestAccMetaRegionDataSource_basic
=== PAUSE TestAccMetaRegionDataSource_basic
=== RUN   TestAccMetaRegionDataSource_endpoint
=== PAUSE TestAccMetaRegionDataSource_endpoint
=== CONT  TestAccMetaPartitionDataSource_basic
=== CONT  TestAccMetaRegionDataSource_endpoint
=== CONT  TestAccMetaRegionDataSource_basic
--- PASS: TestAccMetaRegionDataSource_endpoint (10.37s)
--- PASS: TestAccMetaRegionDataSource_basic (10.42s)
--- PASS: TestAccMetaPartitionDataSource_basic (10.42s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/meta	16.281s
2025/03/07 16:15:40 Initializing Terraform AWS Provider...
=== RUN   TestAccRoute53Record_basic
=== PAUSE TestAccRoute53Record_basic
=== RUN   TestAccRoute53Record_Latency_basic
=== PAUSE TestAccRoute53Record_Latency_basic
=== RUN   TestAccRoute53ZoneDataSource_name
=== PAUSE TestAccRoute53ZoneDataSource_name
=== CONT  TestAccRoute53Record_basic
=== CONT  TestAccRoute53ZoneDataSource_name
=== CONT  TestAccRoute53Record_Latency_basic
--- PASS: TestAccRoute53ZoneDataSource_name (71.30s)
--- PASS: TestAccRoute53Record_basic (152.93s)
--- PASS: TestAccRoute53Record_Latency_basic (170.29s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53	183.937s
2025/03/07 16:15:49 Initializing Terraform AWS Provider...
=== RUN   TestAccS3BucketACL_updateACL
=== PAUSE TestAccS3BucketACL_updateACL
=== RUN   TestAccS3BucketPolicy_basic
=== PAUSE TestAccS3BucketPolicy_basic
=== RUN   TestAccS3BucketPublicAccessBlock_basic
=== PAUSE TestAccS3BucketPublicAccessBlock_basic
=== RUN   TestAccS3Bucket_Basic_basic
=== PAUSE TestAccS3Bucket_Basic_basic
=== RUN   TestAccS3Bucket_Security_corsUpdate
=== PAUSE TestAccS3Bucket_Security_corsUpdate
=== RUN   TestAccS3Object_basic
=== PAUSE TestAccS3Object_basic
=== CONT  TestAccS3BucketACL_updateACL
=== CONT  TestAccS3Bucket_Basic_basic
=== CONT  TestAccS3Bucket_Security_corsUpdate
=== CONT  TestAccS3BucketPolicy_basic
=== CONT  TestAccS3Object_basic
=== CONT  TestAccS3BucketPublicAccessBlock_basic
--- PASS: TestAccS3Object_basic (20.49s)
--- PASS: TestAccS3BucketPublicAccessBlock_basic (20.49s)
--- PASS: TestAccS3BucketPolicy_basic (20.87s)
--- PASS: TestAccS3Bucket_Basic_basic (21.31s)
--- PASS: TestAccS3BucketACL_updateACL (32.33s)
--- PASS: TestAccS3Bucket_Security_corsUpdate (34.07s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	54.368s
2025/03/07 16:15:57 Initializing Terraform AWS Provider...
=== RUN   TestAccSSMParameterEphemeral_basic
=== PAUSE TestAccSSMParameterEphemeral_basic
=== CONT  TestAccSSMParameterEphemeral_basic
--- PASS: TestAccSSMParameterEphemeral_basic (12.15s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ssm	40.616s
2025/03/07 16:15:53 Initializing Terraform AWS Provider...
=== RUN   TestAccSecretsManagerSecret_basic
=== PAUSE TestAccSecretsManagerSecret_basic
=== CONT  TestAccSecretsManagerSecret_basic
--- PASS: TestAccSecretsManagerSecret_basic (14.14s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/secretsmanager	38.345s
2025/03/07 16:15:45 Initializing Terraform AWS Provider...
=== RUN   TestAccSTSCallerIdentityDataSource_basic
=== PAUSE TestAccSTSCallerIdentityDataSource_basic
=== CONT  TestAccSTSCallerIdentityDataSource_basic
--- PASS: TestAccSTSCallerIdentityDataSource_basic (10.21s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sts	26.048s

@ewbankkit ewbankkit requested a review from a team as a code owner March 7, 2025 21:07
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2025

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. size/XS Managed by automation to categorize the size of a PR. labels Mar 7, 2025
@ewbankkit ewbankkit added the provider Pertains to the provider itself, rather than any interaction with AWS. label Mar 7, 2025
jar-b
jar-b approved these changes Mar 7, 2025
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ewbankkit ewbankkit mentioned this pull request Mar 7, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jar-b jar-b jar-b approved these changes

Assignees
No one assigned
Labels
prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. provider Pertains to the provider itself, rather than any interaction with AWS. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
No milestone
2 participants
@ewbankkit @jar-b