Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ECS cluster data source: Return error on multiple clusters with same name #4286

Merged
merged 1 commit into from
Apr 20, 2018
Merged

ECS cluster data source: Return error on multiple clusters with same name #4286

merged 1 commit into from
Apr 20, 2018

Conversation

gheine
Copy link

@gheine gheine commented Apr 20, 2018

No description provided.

@ghost ghost added the size/S Managed by automation to categorize the size of a PR. label Apr 20, 2018
@gheine gheine mentioned this pull request Apr 20, 2018
Merged
@bflad bflad added service/ecs Issues and PRs that pertain to the ecs service. technical-debt Addresses areas of the codebase that need refactoring or redesign. labels Apr 20, 2018
@bflad bflad added this to the v1.16.0 milestone Apr 20, 2018
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. and removed technical-debt Addresses areas of the codebase that need refactoring or redesign. labels Apr 20, 2018
bflad
bflad approved these changes Apr 20, 2018
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix (in the unlikely scenario it does happen as names are supposed to be unique)! 🚀

1 test passed (all tests)
=== RUN   TestAccAWSEcsDataSource_ecsCluster
--- PASS: TestAccAWSEcsDataSource_ecsCluster (33.08s)

@bflad bflad merged commit 2689fe8 into hashicorp:master Apr 20, 2018
bflad added a commit that referenced this pull request Apr 20, 2018
@bflad
Update CHANGELOG for #4286
a884c84
@gheine gheine deleted the ecs_cluster branch April 24, 2018 09:33
@bflad
Copy link
Contributor

bflad commented Apr 25, 2018

This has been released in version 1.16.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 6, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ecs Issues and PRs that pertain to the ecs service. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v1.16.0
Development

Successfully merging this pull request may close these issues.
2 participants
@gheine @bflad