Skip to content

Conversation

@gdavison
Copy link
Contributor

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

Adds List support for aws_subnet

Output from Acceptance Testing

% make testacc PKG=ec2 TESTS=TestAccVPCSubnet_List_

--- PASS: TestAccVPCSubnet_List_ExcludeDefaultSubnets (51.33s)
--- PASS: TestAccVPCSubnet_List_SubnetIDs (52.10s)
--- PASS: TestAccVPCSubnet_List_FilteredSubnetIDs (54.28s)
--- PASS: TestAccVPCSubnet_List_Basic (54.29s)
--- PASS: TestAccVPCSubnet_List_Filtered (54.29s)
--- PASS: TestAccVPCSubnet_List_RegionOverride (55.75s)

@gdavison gdavison requested a review from a team as a code owner October 15, 2025 21:19
@github-actions
Copy link
Contributor

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/ec2 Issues and PRs that pertain to the ec2 service. sweeper Pertains to changes to or issues with the sweeper. generators Relates to code generators. service/vpc Issues and PRs that pertain to the vpc service. size/XL Managed by automation to categorize the size of a PR. labels Oct 15, 2025
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make t K=ec2 T=TestAccVPCSubnet_List_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 f-list-subnets 🌿...
TF_ACC=1 go1.24.8 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCSubnet_List_'  -timeout 360m -vet=off
go: downloading github.com/hashicorp/terraform-plugin-testing v1.14.0-beta.1.0.20251013071646-7ed2ee242705
2025/10/16 11:03:28 Creating Terraform AWS Provider (SDKv2-style)...
2025/10/16 11:03:29 Initializing Terraform AWS Provider (SDKv2-style)...

    vpc_subnet_list_test.go:438: Skipping because ExpectError is not currently supported for Query mode
--- SKIP: TestAccVPCSubnet_List_Filtered_DefaultForAZ (0.00s)
--- PASS: TestAccVPCSubnet_List_ExcludeDefaultSubnets (18.17s)
--- PASS: TestAccVPCSubnet_List_Basic (19.58s)
--- PASS: TestAccVPCSubnet_List_Filtered (19.59s)
--- PASS: TestAccVPCSubnet_List_FilteredSubnetIDs (19.92s)
--- PASS: TestAccVPCSubnet_List_SubnetIDs (21.88s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        28.852s

@gdavison gdavison merged commit 9550818 into main Oct 16, 2025
72 checks passed
@gdavison gdavison deleted the f-list-subnets branch October 16, 2025 15:32
@github-actions
Copy link
Contributor

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v6.17.0 milestone Oct 16, 2025
terraform-aws-provider bot pushed a commit that referenced this pull request Oct 16, 2025
@github-actions
Copy link
Contributor

This functionality has been released in v6.17.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 16, 2025
@jar-b jar-b added the new-list-resource Introduces list resource support. label Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-list-resource Introduces list resource support. service/ec2 Issues and PRs that pertain to the ec2 service. service/vpc Issues and PRs that pertain to the vpc service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants