Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource - Glue crawlers #4484

Closed
wants to merge 60 commits into from
Closed

New resource - Glue crawlers #4484

Show file tree
Hide file tree
Changes from 27 commits
Commits
Show all changes
60 commits
Select commit Hold shift + click to select a range
76aee79
WIP - Add AWS Glue Crawler
darrenhaken Jan 18, 2018
c3cbbe7
Merge branch 'master' of github.com:terraform-providers/terraform-pro…
darrenhaken Mar 13, 2018
b0ba213
WIP - Finally got a failing test with the bare min of crawler
darrenhaken Mar 13, 2018
1b0babf
WIP with failing test
darrenhaken Mar 15, 2018
8eb8421
Merge remote-tracking branch 'upstream/master' into glue_crawlers
darrenhaken Apr 28, 2018
f579f8d
Switch service role for Glue
darrenhaken Apr 28, 2018
f43a0a2
make glue crawler creation wait for role ready
f0rk May 30, 2018
9396692
Merge pull request #1 from f0rk/glue_crawlers_fork
darrenhaken May 31, 2018
9ca8a90
Add description and schedule to glue crawlers
darrenhaken May 31, 2018
71db475
Merge remote-tracking branch 'upstream/master' into glue_crawlers
darrenhaken Jun 1, 2018
6801b72
Add classifiers to glue crawlers
darrenhaken Jun 1, 2018
97496eb
Add glue crawler table prefix
darrenhaken Jun 1, 2018
d41e67f
Merge remote-tracking branch 'upstream/master' into glue_crawlers
darrenhaken Jun 12, 2018
b5fbdf4
Change role names to not use the default.
darrenhaken Jun 12, 2018
cf9b1e2
Change classifier name
darrenhaken Jun 12, 2018
8f1f921
Add schema change policy
darrenhaken Jun 13, 2018
8287580
Add creating glue db as part of tests.
darrenhaken Jun 14, 2018
a78ca5d
Add glue crawler s3 targets
darrenhaken Jun 15, 2018
15569a0
Add s3 target exclusions to glue crawler
darrenhaken Jun 16, 2018
030df68
Fix assertion for glue crawler basic test
darrenhaken Jun 16, 2018
8e02838
WIP for glue JDBC crawlers
darrenhaken Jun 17, 2018
dac4615
Remove experiment on Glue JDBC crawler
darrenhaken Jun 17, 2018
0f087a3
Attempt to add full glue access but test still fails
darrenhaken Jun 17, 2018
2d2b9c3
Change name on Glue JDBC crawler
darrenhaken Jun 18, 2018
9d9d676
Add classifiers to glue crawlers
darrenhaken Jun 18, 2018
43ed483
Add glue crawler configuration
darrenhaken Jun 18, 2018
35e1ee4
Merge remote-tracking branch 'upstream/master' into glue_crawlers
darrenhaken Jun 18, 2018
7e625f9
resource/aws_kinesis_firehose_delivery_stream: Support data_format_co…
bflad Jun 5, 2018
5c397f1
resource/aws_kinesis_firehose_delivery_stream: Fix imports formatting…
bflad Jun 15, 2018
fcd0f8b
resource/aws_kinesis_firehose_delivery_stream: Remove else statements…
bflad Jun 15, 2018
b497605
resource/aws_kinesis_firehose_delivery_stream: Implement ConflictsWit…
bflad Jun 15, 2018
5da31f8
add new resource aws_neptune_cluster_parameter_group
saravanan30erd Jun 16, 2018
689b0bb
add acceptance test
saravanan30erd Jun 16, 2018
0659c60
add document for neptune_cluster_parameter_group
saravanan30erd Jun 16, 2018
03a7c40
fix the issue in setting tags
saravanan30erd Jun 17, 2018
a2ec019
resource/aws_cognito_user_pool_client: Prevent panic with updating re…
bflad Jun 18, 2018
7e2307c
tests/resource/aws_kinesis_firehose_delivery_stream: Verify updates t…
bflad Jun 18, 2018
3c9c2fa
resource/aws_kinesis_firehose_delivery_stream: Mark data_format_conve…
bflad Jun 18, 2018
26fb58c
Update CHANGELOG for #4842
bflad Jun 18, 2018
357bb86
fix the unit testing
saravanan30erd Jun 18, 2018
c8d17fe
corrections based on feedback
saravanan30erd Jun 18, 2018
a2fb36f
Update CHANGELOG for #4868
bflad Jun 18, 2018
59a9dc4
tests/resource/aws_neptune_cluster_parameter_group: Enhance acceptanc…
bflad Jun 18, 2018
53709e3
Update CHANGELOG for #4860
bflad Jun 18, 2018
e016ace
resource/aws_neptune_parameter_group: Support tags argument and arn a…
bflad Jun 18, 2018
037be34
Add enabled_cloudwatch_logs_exports to rds cluster resource
Jun 18, 2018
e34e4ac
New Data Source: aws_vpc_dhcp_options
bflad Jun 18, 2018
e39ad32
data-source/aws_vpc_dhcp_options: Support filter argument
bflad Jun 19, 2018
cfa0c87
data-source/aws_vpc_dhcp_options: Fix imports formatting
bflad Jun 19, 2018
2f3d7eb
data-source/aws_vpc_dhcp_options: Remove ValidateFunc from dhcp_optio…
bflad Jun 19, 2018
35f1f9d
tests/data-source/aws_vpc_dhcp_options: Check no matching, multiple m…
bflad Jun 19, 2018
c7f2925
tests/resource/aws_neptune_parameter_group: Use %q instead of "%s" in…
bflad Jun 19, 2018
a8e0dc2
Update CHANGELOG for #4873
bflad Jun 19, 2018
3be906a
Update CHANGELOG for #4878
bflad Jun 19, 2018
aff7114
[squash] review remarks
Jun 19, 2018
e146939
Update CHANGELOG for #4875
bflad Jun 19, 2018
51a1ae0
Rename glue crawler resource
darrenhaken Jun 20, 2018
e5832d7
Made some of the glue crawler changes based on PR feedback
darrenhaken Jun 20, 2018
1f05ca1
Add random names to glue crawler tests
darrenhaken Jun 20, 2018
ac4b520
Revert a change for glue crawler schema change
darrenhaken Jun 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions aws/provider.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,6 +412,7 @@ func Provider() terraform.ResourceProvider {
"aws_glue_catalog_table": resourceAwsGlueCatalogTable(),
"aws_glue_classifier": resourceAwsGlueClassifier(),
"aws_glue_connection": resourceAwsGlueConnection(),
"aws_glue_catalog_crawler": resourceAwsGlueCatalogCrawler(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably remove _catalog from the resource/file names, and Catalog from the function names everywhere to match the API, which just refers to these objects without including catalog in the naming.

You know this already but this resource is missing documentation in website/docs/r/glue_crawler.html.markdown and a sidebar link in website/aws.erb 😉

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

"aws_glue_job": resourceAwsGlueJob(),
"aws_glue_trigger": resourceAwsGlueTrigger(),
"aws_guardduty_detector": resourceAwsGuardDutyDetector(),
Expand Down
Loading