Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix documentation description of replica_kms_key_id #4684

Merged
merged 1 commit into from
May 30, 2018
Merged

fix documentation description of replica_kms_key_id #4684

merged 1 commit into from
May 30, 2018

Conversation

jbruett
Copy link
Contributor

@jbruett jbruett commented May 29, 2018

This property requires the ARN, not the ID, ultimately the whole thing should be renamed. you can see the AWS documentation here: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-s3-bucket-encryptionconfiguration.html

@jbruett
fix description of replica_kms_key_id
273d6ac 
This property requires the ARN, not the ID, ultimately the whole thing should be renamed.  you can see the AWS documentation here: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-s3-bucket-encryptionconfiguration.html
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. labels May 29, 2018
@bflad bflad added the service/s3 Issues and PRs that pertain to the s3 service. label May 29, 2018
bflad
bflad approved these changes May 30, 2018
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thanks! 🚀

@bflad bflad added this to the v1.21.0 milestone May 30, 2018
@bflad bflad merged commit c9b2f22 into hashicorp:master May 30, 2018
@ghost
Copy link

ghost commented Apr 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. service/s3 Issues and PRs that pertain to the s3 service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v1.21.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jbruett @bflad