Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_cloudfront_distribution: Allow create and update retries on InvalidViewerCertificate for eventual consistency issues #4698

Merged
merged 1 commit into from
Jun 2, 2018
Merged

resource/aws_cloudfront_distribution: Allow create and update retries on InvalidViewerCertificate for eventual consistency issues #4698

merged 1 commit into from
Jun 2, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented May 30, 2018 •
edited
Loading

Fixes #4687

Changes proposed in this pull request:

  • Allow 1 minute for ACM/IAM certificate eventual consistency when creating/updating CloudFront Distributions

Output from acceptance testing:

12 tests passed (all tests)
=== RUN   TestAccAWSCloudFrontDistribution_Origin_EmptyOriginID
--- PASS: TestAccAWSCloudFrontDistribution_Origin_EmptyOriginID (1.65s)
=== RUN   TestAccAWSCloudFrontDistribution_Origin_EmptyDomainName
--- PASS: TestAccAWSCloudFrontDistribution_Origin_EmptyDomainName (1.72s)
=== RUN   TestAccAWSCloudFrontDistribution_IsIPV6EnabledConfig
--- PASS: TestAccAWSCloudFrontDistribution_IsIPV6EnabledConfig (829.68s)
=== RUN   TestAccAWSCloudFrontDistribution_noCustomErrorResponseConfig
--- PASS: TestAccAWSCloudFrontDistribution_noCustomErrorResponseConfig (831.77s)
=== RUN   TestAccAWSCloudFrontDistribution_orderedCacheBehavior
--- PASS: TestAccAWSCloudFrontDistribution_orderedCacheBehavior (832.59s)
=== RUN   TestAccAWSCloudFrontDistribution_multiOrigin
--- PASS: TestAccAWSCloudFrontDistribution_multiOrigin (833.93s)
=== RUN   TestAccAWSCloudFrontDistribution_S3Origin
--- PASS: TestAccAWSCloudFrontDistribution_S3Origin (834.06s)
=== RUN   TestAccAWSCloudFrontDistribution_HTTP11Config
--- PASS: TestAccAWSCloudFrontDistribution_HTTP11Config (834.15s)
=== RUN   TestAccAWSCloudFrontDistribution_noOptionalItemsConfig
--- PASS: TestAccAWSCloudFrontDistribution_noOptionalItemsConfig (834.69s)
=== RUN   TestAccAWSCloudFrontDistribution_S3OriginWithTags
--- PASS: TestAccAWSCloudFrontDistribution_S3OriginWithTags (835.48s)
=== RUN   TestAccAWSCloudFrontDistribution_importBasic
--- PASS: TestAccAWSCloudFrontDistribution_importBasic (837.82s)
=== RUN   TestAccAWSCloudFrontDistribution_customOrigin
--- PASS: TestAccAWSCloudFrontDistribution_customOrigin (838.97s)

@bflad
resource/aws_cloudfront_distribution: Add create and update retries o…
ed585a6 
…n InvalidViewerCertificate for eventual consistency issues
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/cloudfront Issues and PRs that pertain to the cloudfront service. labels May 30, 2018
@ghost ghost added the size/M Managed by automation to categorize the size of a PR. label May 30, 2018
@bflad bflad mentioned this pull request May 30, 2018
Closed
@bflad bflad requested a review from a team May 30, 2018 14:52
@bflad bflad added this to the v1.22.0 milestone Jun 2, 2018
@bflad bflad merged commit 26edc10 into master Jun 2, 2018
@bflad bflad deleted the f-aws_cloudfront_distribution-cert-retries branch June 2, 2018 21:46
bflad added a commit that referenced this pull request Jun 2, 2018
@bflad
Update CHANGELOG for #4698
90ec81a
@bflad
Copy link
Contributor Author

bflad commented Jun 5, 2018

This has been released in version 1.22.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@nywilken nywilken mentioned this pull request Jun 11, 2019
Closed
@ghost
Copy link

ghost commented Apr 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paddycarver paddycarver paddycarver approved these changes

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/cloudfront Issues and PRs that pertain to the cloudfront service. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v1.22.0
Development

Successfully merging this pull request may close these issues.

aws_acm_certificate is eventually consistent, causes direct dependencies to fail
2 participants
@bflad @paddycarver