Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_eks_cluster: Ensure arn is available as an attribute #4766

Merged
merged 1 commit into from
Jun 6, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jun 6, 2018

The addition of the Arn attribute from the API was an addition that occurred between EKS preview and GA. While I added the d.Set() for it, unfortunately I missed the testing for the new attribute which would have caught this.

Fixes #4764

Changes proposed in this pull request:

  • Add arn attribute to schema and properly acceptance test the new attribute in the aws_eks_cluster resource and data source

Output from acceptance testing:

Pending in TeamCity

@bflad bflad added bug Addresses a defect in current functionality. service/eks Issues and PRs that pertain to the eks service. labels Jun 6, 2018
@bflad bflad added this to the v1.23.0 milestone Jun 6, 2018
@bflad bflad requested a review from a team June 6, 2018 15:43
@ghost ghost added the size/XS Managed by automation to categorize the size of a PR. label Jun 6, 2018
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bflad bflad merged commit c4e687c into master Jun 6, 2018
@bflad bflad deleted the b-aws_eks_cluster-arn branch June 6, 2018 19:18
bflad added a commit that referenced this pull request Jun 6, 2018
@bflad
Copy link
Contributor Author

bflad commented Jun 14, 2018

This has been released in version 1.23.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/eks Issues and PRs that pertain to the eks service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_eks_cluster not exporting arn attribute as per docs
2 participants